From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbcETSi1 (ORCPT ); Fri, 20 May 2016 14:38:27 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:35168 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbcETSi0 (ORCPT ); Fri, 20 May 2016 14:38:26 -0400 From: Paul Moore To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, sgrubb@redhat.com, eparis@redhat.com Subject: Re: [PATCH] audit: fixup: log on errors from filter user rules Date: Fri, 20 May 2016 14:38:22 -0400 Message-ID: <2799769.XiOflrRcky@sifl> Organization: Red Hat User-Agent: KMail/4.14.10 (Linux/4.5.2-gentoo; KDE/4.14.19; x86_64; ; ) In-Reply-To: <52272665ce6c4b1dd18ca1b6a4fdafa8634c77e8.1463366687.git.rgb@redhat.com> References: <52272665ce6c4b1dd18ca1b6a4fdafa8634c77e8.1463366687.git.rgb@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, May 15, 2016 10:47:39 PM Richard Guy Briggs wrote: > In commit 724e4fcc the intention was to pass any errors back from > audit_filter_user_rules() to audit_filter_user(). Add that code. > > Signed-off-by: Richard Guy Briggs > --- > kernel/auditfilter.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Looks good to me; queued up and should appear in audit#next after the merge window closes. > diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c > index b8ff9e1..96c9a1b 100644 > --- a/kernel/auditfilter.c > +++ b/kernel/auditfilter.c > @@ -1339,8 +1339,8 @@ static int audit_filter_user_rules(struct audit_krule > *rule, int type, break; > } > > - if (!result) > - return 0; > + if (result <= 0) > + return result; > } > switch (rule->action) { > case AUDIT_NEVER: *state = AUDIT_DISABLED; break; -- paul moore security @ redhat