From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 98357445AD3; Mon, 20 Jul 2026 17:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784570212; cv=none; b=ZjymbQY+rIZTBH2VtlMBBlRkQmmc2mDXT1DyCLisYRNyJmbSyRR9hU0xd7S4ZiZynji3YqUG/CNeLR4V9r9fpv7vf/p66aZWdtOqr/M+W926cWI/Z95pQl8wdHtq77ScfIdp06CvFlBDWpSceyZpeHOddfWnwoDgXUVfhr/uRq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784570212; c=relaxed/simple; bh=SkixE224soWrrcHibLZOzDF6dZMgPntKaiJ5Bvw64vE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KYMna8ylzcNnn5Sg8fnCL8VlTz2Gl8dw+MyqiVXDe/MoM4GdnQvJj6hhx6PScpV+Ogyp7R+uzEsSy4tMSN50CaaX66l53Xup2Us2FC53RE2bDbUCBs6dr1xt3os3OwKkx9EM07SuWWUuAqejKEi6Xsk/Q1OmfxllKnsTUSxPhz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=JRNyBrKb; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="JRNyBrKb" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC239143D; Mon, 20 Jul 2026 10:56:40 -0700 (PDT) Received: from [192.168.20.93] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13B0C3F86F; Mon, 20 Jul 2026 10:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784570205; bh=SkixE224soWrrcHibLZOzDF6dZMgPntKaiJ5Bvw64vE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JRNyBrKbRG5+iwjey7s0Tv+9eiAuYLT4Wu8n9RMz3U1PRW1m84oFMG/DW3UqmxTDs ZDMt+Kqob3NelfynPFV/ViyeOtRfOmp5l9rRHrdHTyxGNOOWuKQBuVf3UNfFqBVzRI soyxtmEXCB3gGCKYQqbXLfAUbZ8yMuvGDlQ5vcLU= Message-ID: <279d48e9-9a10-4057-ba60-76fad79fde79@arm.com> Date: Mon, 20 Jul 2026 12:56:29 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] cpupower: Add generic CPPC performance display To: Thorsten Leemhuis , linux-pm@vger.kernel.org Cc: trenn@suse.com, shuah@kernel.org, jwyatt@redhat.com, jkacur@redhat.com, kaushlendra.kumar@intel.com, sashal@kernel.org, fj5851bi@fujitsu.com, rui.zhang@intel.com, linux-kernel@vger.kernel.org References: <20260709221344.1919794-1-jeremy.linton@arm.com> <20260709221344.1919794-2-jeremy.linton@arm.com> Content-Language: en-US From: Jeremy Linton In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/18/26 1:12 AM, Thorsten Leemhuis wrote: > On 7/10/26 00:13, Jeremy Linton wrote: >> Arm64 machines, and possibly others, use the standard ACPI defined CPPC >> infrastructure. cpupower has CPPC support, but it's largely written >> around the intricacies of AMD processors, using platform MSRs to avoid >> shortcomings in the specification. >> >> [...] >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "helpers/helpers.h" >> +#include "cpufreq.h" >> +#include "acpi_cppc.h" >> + >> +#define cppc_to_frequency(perf) (roundf(slope * (perf) + intercept)) > FYI, this patch showed up in -next yesterday and I suspect it caused > this build error for me on x86_64: > > """ CC cpupower > /usr/bin/ld.bfd: /tmp/ccjOeWLF.ltrans0.ltrans.o: in function > `get_perf_cap.isra.0': > /builddir/build/BUILD/kernel-7.2.0-build/kernel-next-20260717/linux-7.2.0-0.0.next.20260717.330.vanilla.fc44.x86_64/tools/power/cpupower/utils/helpers/cppc.c:39:(.text+0x45cc): > undefined reference to `roundf' > /usr/bin/ld.bfd: > /tmp/ccjOeWLF.ltrans0.ltrans.o:/builddir/build/BUILD/kernel-7.2.0-build/kernel-next-20260717/linux-7.2.0-0.0.next.20260717.330.vanilla.fc44.x86_64/tools/power/cpupower/utils/helpers/cppc.c:49:(.text+0x46a2): > undefined reference to `roundf' > collect2: error: ld returned 1 exit status > make: *** [Makefile:238: cpupower] Error 1 Right, when its not inline it needs -lm, I will toss a patch against it in a moment. > """ >> [...] > > Full log: > https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-44-x86_64/10739303-next-next-all/builder-live.log.gz > > Ciao, Thorsten