From: Dave Hansen <dave.hansen@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, tglx@linutronix.de
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
stable@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()
Date: Mon, 19 Nov 2018 15:43:23 -0800 [thread overview]
Message-ID: <279dadae-9148-465c-7ec6-3f37e026c6c9@intel.com> (raw)
In-Reply-To: <154266954452.2939184.974606608701109493.stgit@dwillia2-desk3.amr.corp.intel.com>
On 11/19/18 3:19 PM, Dan Williams wrote:
> Andy wondered why a path that can sleep was using __flush_tlb_all() [1]
> and Dave confirmed the expectation for TLB flush is for modifying /
> invalidating existing pte entries, but not initial population [2].
I _think_ this is OK.
But, could we sprinkle a few WARN_ON_ONCE(p*_present()) calls in there
to help us sleep at night?
next prev parent reply other threads:[~2018-11-19 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 23:19 Dan Williams
2018-11-19 23:43 ` Dave Hansen [this message]
2018-11-19 23:48 ` Dan Williams
2018-11-20 2:59 ` Williams, Dan J
2018-11-20 9:03 ` Peter Zijlstra
2018-11-21 22:36 ` Dan Williams
2018-12-05 18:06 ` [tip:x86/mm] generic/pgtable: Introduce set_pte_safe() tip-bot for Dan Williams
2018-11-20 8:52 ` [PATCH] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279dadae-9148-465c-7ec6-3f37e026c6c9@intel.com \
--to=dave.hansen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®