From: Paolo Valente <paolo.valente@linaro.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: Jan Kara <jack@suse.cz>,
tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH -next v6 3/3] block, bfq: do not idle if only one group is activated
Date: Sat, 28 May 2022 10:30:34 +0200 [thread overview]
Message-ID: <27B0AE8B-C134-4BA1-B84F-39C659CB2B10@linaro.org> (raw)
In-Reply-To: <20220523131818.2798712-4-yukuai3@huawei.com>
> Il giorno 23 mag 2022, alle ore 15:18, Yu Kuai <yukuai3@huawei.com> ha scritto:
>
> Now that root group is counted into 'num_groups_with_busy_queues',
> 'num_groups_with_busy_queues > 0' is always true in
> bfq_asymmetric_scenario(). Thus change the condition to '> 1'.
>
> On the other hand, this change can enable concurrent sync io if only
> one group is activated.
This is ok. Yet, if the mistakes I found in the other two patches are
actual errors, I wonder how these changes made it to pass your tests.
Thanks,
Paolo
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> ---
> block/bfq-iosched.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 609b4e894684..142e1ca4600f 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -812,7 +812,7 @@ bfq_pos_tree_add_move(struct bfq_data *bfqd, struct bfq_queue *bfqq)
> * much easier to maintain the needed state:
> * 1) all active queues have the same weight,
> * 2) all active queues belong to the same I/O-priority class,
> - * 3) there are no active groups.
> + * 3) there are one active group at most.
> * In particular, the last condition is always true if hierarchical
> * support or the cgroups interface are not enabled, thus no state
> * needs to be maintained in this case.
> @@ -844,7 +844,7 @@ static bool bfq_asymmetric_scenario(struct bfq_data *bfqd,
>
> return varied_queue_weights || multiple_classes_busy
> #ifdef CONFIG_BFQ_GROUP_IOSCHED
> - || bfqd->num_groups_with_busy_queues > 0
> + || bfqd->num_groups_with_busy_queues > 1
> #endif
> ;
> }
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-05-28 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 13:18 [PATCH -next v6 0/3] support concurrent sync io for bfq on a specail occasion Yu Kuai
2022-05-23 13:18 ` [PATCH -next v6 1/3] block, bfq: record how many queues are busy in bfq_group Yu Kuai
2022-05-28 8:18 ` Paolo Valente
2022-05-28 8:37 ` Yu Kuai
2022-05-23 13:18 ` [PATCH -next v6 2/3] block, bfq: refactor the counting of 'num_groups_with_pending_reqs' Yu Kuai
2022-05-28 8:27 ` Paolo Valente
2022-05-28 8:39 ` Yu Kuai
2022-05-28 8:41 ` Paolo Valente
2022-05-23 13:18 ` [PATCH -next v6 3/3] block, bfq: do not idle if only one group is activated Yu Kuai
2022-05-28 8:30 ` Paolo Valente [this message]
2022-05-28 8:18 ` [PATCH -next v6 0/3] support concurrent sync io for bfq on a specail occasion Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27B0AE8B-C134-4BA1-B84F-39C659CB2B10@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®