From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rohit kumar <rohitkr@codeaurora.org>,
plai@codeaurora.org, bgoswami@codeaurora.org,
rohkumar@qti.qualcomm.com, lgirdwood@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: apq8096: set card as device drvdata
Date: Wed, 6 Jun 2018 10:16:51 +0100 [thread overview]
Message-ID: <27a8b03f-a276-e3fd-7921-1fde47284237@linaro.org> (raw)
In-Reply-To: <1528275324-4878-1-git-send-email-rohitkr@codeaurora.org>
On 06/06/18 09:55, Rohit kumar wrote:
> snd_soc_card is retrieved as device drvdata during unbind().
> Set it as drvdata during bind() to avoid memory corruption during
> unbind().
>
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
Thanks for the patch,
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/qcom/apq8096.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c
> index 561cd42..239b8cb 100644
> --- a/sound/soc/qcom/apq8096.c
> +++ b/sound/soc/qcom/apq8096.c
> @@ -140,6 +140,7 @@ static int apq8096_bind(struct device *dev)
>
> component_bind_all(dev, card);
> card->dev = dev;
> + dev_set_drvdata(dev, card);
> ret = apq8096_sbc_parse_of(card);
> if (ret) {
> dev_err(dev, "Error parsing OF data\n");
>
next prev parent reply other threads:[~2018-06-06 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 8:55 Rohit kumar
2018-06-06 9:16 ` Srinivas Kandagatla [this message]
2018-06-18 12:00 ` Applied "ASoC: qcom: apq8096: set card as device drvdata" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27a8b03f-a276-e3fd-7921-1fde47284237@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=rohitkr@codeaurora.org \
--cc=rohkumar@qti.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®