Re: [PATCH v5 0/2] Add eMMC support for Stratix 10 SoCDK

[Dinh Nguyen <dinguyen@kernel.org>]

On 2/23/26 00:45, Ng, Tze Yee wrote:
> On 26/1/2026 2:19 pm, Ng, Tze Yee wrote:
>> From: Ng Tze Yee <tzeyee.ng@altera.com>
>>
>> The first patch adds the device tree binding documentation for the new
>> board compatible string. The second patch introduces a new base device
>> tree include file (socfpga_stratix10_socdk.dtsi) containing common board
>> configurations, and the eMMC-specific device tree file
>> (socfpga_stratix10_socdk_emmc.dts) that includes the base dtsi along
>> with eMMC controller configuration.
>>
>> This follows a hierarchical structure:
>> - socfpga_stratix10.dtsi: SoC-level definitions
>> - socfpga_stratix10_socdk.dtsi: Board-level common configurations
>> - socfpga_stratix10_socdk_emmc.dts: eMMC daughter board specifics
>>
>> Changes in v5:
>> - Move Acked-by's above the Signed-off-by: and remove the empty
>> line between them.
>> - No code change
>>
>> Changes in v4:
>> - Included Acked-by from Rob Herring and Krzysztof Kozlowski in the second
>>     patch commit message
>> - No code change
>>
>> Changes in v3:
>> - Refactor socfpga_stratix10_socdk.dts to use the new common dtsi file,
>>     eliminating code duplication
>> - Move gmac2 and i2c2 nodes from socfpga_stratix10_socdk.dtsi to
>>     socfpga_stratix10_socdk_emmc.dts as they are specific to the eMMC
>>     daughter board variant
>> - Fix PHY address in socfpga_stratix10_socdk.dts from @0 to @4
>>
>> Changes in v2:
>> - Introduced socfpga_stratix10_socdk.dtsi for common board settings
>> - Updated socfpga_stratix10_socdk_emmc.dts to include the new dtsi
>> - Added fallback compatible string "altr,socfpga-stratix10-socdk" in
>>     the binding documentation for broader compatibility
>>
>> Ng Tze Yee (2):
>>     dt-bindings: altera: Add fallback compatible for Stratix 10 SoCDK eMMC
>>       variant
>>     arm64: dts: socfpga: stratix10: Add emmc support
>>
>>    .../devicetree/bindings/arm/altera.yaml       |  6 ++
>>    arch/arm64/boot/dts/altera/Makefile           |  1 +
>>    .../dts/altera/socfpga_stratix10_socdk.dts    | 67 +--------------
>>    .../dts/altera/socfpga_stratix10_socdk.dtsi   | 71 ++++++++++++++++
>>    .../altera/socfpga_stratix10_socdk_emmc.dts   | 81 +++++++++++++++++++
>>    5 files changed, 161 insertions(+), 65 deletions(-)
>>    create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtsi
>>    create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts
>>
> 
> Hi maintainers,
> 
> I would like to gently ping on this patch series that was submitted. The
> series has received Acked-by from Rob Herring and Krzysztof Kozlowski
> for the dt-bindings patch in v4, and all requested changes have been
> addressed in v5.
> 
> Patch series link:
> https://lore.kernel.org/all/cover.1769407657.git.tzeyee.ng@altera.com/
> 
> Could you please let me know if there are any concerns or additional
> changes needed for this series to be merged?
> 
> Thanks for your time and consideration.
> 

This series look good to me, but can you rebase it to v7.0-rc1? I'm 
getting a conflict.

Thanks,
Dinh