From: Hans de Goede <hdegoede@redhat.com>
To: "Kate Hsuan" <hpa@redhat.com>, "Pavel Machek" <pavel@ucw.cz>,
"Lee Jones" <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"André Apitzsch" <git@apitzsch.eu>,
linux-kernel@vger.kernel.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v7 6/6] platform: x86-android-tablets: others: Set the LED trigger to charging_orange_full_green for Xiaomi pad2
Date: Mon, 29 Apr 2024 13:10:26 +0200 [thread overview]
Message-ID: <27aefc94-3bf3-44bd-8689-22e0c984855f@redhat.com> (raw)
In-Reply-To: <20240424065212.263784-7-hpa@redhat.com>
Hi,
On 4/24/24 8:52 AM, Kate Hsuan wrote:
> Set the default trigger to bq27520-0-charging-orange-full-green. The LED
> will show orange when the battery is charging. The LED will show green
> when the battery status is full.
>
> Signed-off-by: Kate Hsuan <hpa@redhat.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/x86-android-tablets/other.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/x86-android-tablets/other.c b/drivers/platform/x86/x86-android-tablets/other.c
> index c77d56454f2d..52032a874b7f 100644
> --- a/drivers/platform/x86/x86-android-tablets/other.c
> +++ b/drivers/platform/x86/x86-android-tablets/other.c
> @@ -610,7 +610,7 @@ static const struct property_entry ktd2026_rgb_led_props[] = {
> PROPERTY_ENTRY_U32("reg", 0),
> PROPERTY_ENTRY_U32("color", LED_COLOR_ID_RGB),
> PROPERTY_ENTRY_STRING("function", "indicator"),
> - PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging"),
> + PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging-orange-full-green"),
> { }
> };
>
next prev parent reply other threads:[~2024-04-29 11:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 6:52 [PATCH v7 0/6] KTD2026 indicator LED for X86 Xiaomi Pad2 Kate Hsuan
2024-04-24 6:52 ` [PATCH v7 1/6] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Kate Hsuan
2024-04-29 11:05 ` Hans de Goede
2024-04-24 6:52 ` [PATCH v7 2/6] leds: rgb: leds-ktd202x: I2C ID tables for KTD2026 and 2027 Kate Hsuan
2024-04-29 11:08 ` Hans de Goede
2024-05-03 2:55 ` Kate Hsuan
2024-04-24 6:52 ` [PATCH v7 3/6] leds: core: Add led_mc_set_brightness() function Kate Hsuan
2024-04-24 6:52 ` [PATCH v7 4/6] leds: trigger: Add led_mc_trigger_event() function Kate Hsuan
2024-04-24 6:52 ` [PATCH v7 5/6] power: supply: power-supply-leds: Add charging_orange_full_green trigger for RGB LED Kate Hsuan
2024-04-29 11:10 ` Hans de Goede
2024-05-02 14:15 ` Hans de Goede
2024-04-24 6:52 ` [PATCH v7 6/6] platform: x86-android-tablets: others: Set the LED trigger to charging_orange_full_green for Xiaomi pad2 Kate Hsuan
2024-04-29 11:10 ` Hans de Goede [this message]
2024-04-29 11:13 ` [PATCH v7 0/6] KTD2026 indicator LED for X86 Xiaomi Pad2 Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27aefc94-3bf3-44bd-8689-22e0c984855f@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=git@apitzsch.eu \
--cc=hpa@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®