From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E2317BB11 for ; Wed, 10 Apr 2024 19:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712777785; cv=none; b=h5yjh76GMsGJOEzG+mnm0IcpGKtdmpRGbOzE6MZKVayoUJle8jjide+ZIqtuVbynabKc62RQPxPfyyCKmts7W4XycqW4tUpAXTxuWos9s0KqgbbHKLUXrfl2LfgrN5slh4E2FZak2DViFHJ0YyzaJfKxD3LqJ6ui27jF/Xn3w8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712777785; c=relaxed/simple; bh=yAnbcmDwl3OuHgvaNtG8x03gYr58md37yMsRGiUDil0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g/ySJt5NuTlwdER8b//CfPpmATEwQ5h/uFtv6wAr4/wnOl1VTo9GnxLRjsy+I+lJPDi8naUhx0cLnMES7QHiQgNhv9mXSL19oggdiN9NdN23ZXEHsSs7JG2wIFvUp4LoyZhw9BpDT9axCigtfXeYuOxGYyutx3MIFeKaacWSjhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FnSyrZcO; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FnSyrZcO" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-34682953048so611829f8f.3 for ; Wed, 10 Apr 2024 12:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712777782; x=1713382582; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=2x6xXhx5ta6qCNkF8JTjCy7KYrE7GzNg9QfPMjxG4Ho=; b=FnSyrZcO9dj21FaNqKXEhVtajdVeybyQBcHqNajAuw+rFLxnJLFna/5bjDvsfz2FY+ JUK/dWMKW9g80fjhfcaqX5+9CskijfxbGe17pNkGUox39E2L8sfzhGBQ/m5xzJFeP9zM WBLC/GQr6upLKoKeowvld3EcAyEpgof5GXDXWguG2xpKtYLedC9JqtTe4TBbJmTn26mo gkf27n/H0LdWf0meg8f+W+Z4wPLFJrcn0swZsI//cWiEXoWGlqUtMDxTDXJLUZpV+lbI zUzvqUeuP835xE33pYhMCvGHAVZm8cutEz5smWMzzzPcWTEXLDb9PKfkxrgNZD8Awvxo TPaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712777782; x=1713382582; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2x6xXhx5ta6qCNkF8JTjCy7KYrE7GzNg9QfPMjxG4Ho=; b=jhbyZs2UXYePaYWbts4OFLMgtVYzl0cCKsHTGkg/8eKYmPSTbKkp7JYDZYd/MeOVIM 8F3xWQ6tO6QNrJVlSoCyJ6GV2OaZtupWD/VPmEavgfVuzMH4juMMQxjTzlQGt6yqOYhB UI9cEwWbvpCgd9MG4Yc5sLgdFDxybVZ4qtOpfkP4wwf6zabCIZyxsWJmuxP+9DIywEB6 gD3LPDqxU8xETrs2Y9Es5Kq63ZXIjLFumFKnqjbS4sRkpY3nqFj2sho5ZZ1CONSdG6RC spHLPbH3v8aLt//x2Xk6/rp0R7HexC37Uxot97410BVi/Ol+J6oBqTWwOcxQoLxIXHwE mXoQ== X-Forwarded-Encrypted: i=1; AJvYcCVPVQNMPJ0IGa+8G8G3DNl5sliJvKgepxIx4cmrKoFyvr5anCWUoPig8tRAFuKFmqQrIEUDdYJwIL7fqdw+ih+bIJ3lnDsJzjntFcBg X-Gm-Message-State: AOJu0Ywok4TngM5/18gIHrOYbXmyf8Eeodzo/FwRvHkEtF9PJC44TmAW B1XOnk5kJBC7dGd+PbLJ91GoqFapPnkQSz0XAnNLCb7JxzYfZdCVNmCyfXP1fIg= X-Google-Smtp-Source: AGHT+IGQ+ZXXuRcuNYXAv3QzvL2nb2ivdWBkz7NW8d8cmnUbnnTjaSqkVeWpgVuLIFfZAStNCHbj+g== X-Received: by 2002:a5d:4a45:0:b0:343:955d:822d with SMTP id v5-20020a5d4a45000000b00343955d822dmr3186449wrs.7.1712777781987; Wed, 10 Apr 2024 12:36:21 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id i11-20020adfe48b000000b0034330c9eccasm14488284wrm.79.2024.04.10.12.36.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 12:36:21 -0700 (PDT) Message-ID: <27b4b37b-c736-4d6b-98f0-0856e09ec5b6@linaro.org> Date: Wed, 10 Apr 2024 21:36:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] dt-bindings: phy: qcom,ipq8074-qmp-pcie: add ipq9574 gen3x2 PHY To: mr.nuke.me@gmail.com, Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240409190833.3485824-1-mr.nuke.me@gmail.com> <20240409190833.3485824-6-mr.nuke.me@gmail.com> <019180df-67b9-438b-a10d-f92fd4ddec03@linaro.org> <33461c22-21a3-023b-4750-c69304471ea8@gmail.com> <2379377e-ca1c-453f-bb74-186ab738ce39@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/04/2024 18:29, mr.nuke.me@gmail.com wrote: > > > On 4/10/24 02:02, Krzysztof Kozlowski wrote: >> On 10/04/2024 08:59, Krzysztof Kozlowski wrote: >>> On 09/04/2024 22:19, mr.nuke.me@gmail.com wrote: >>>>> >>>>> >>>>>> >>>>>> clock-names: >>>>>> items: >>>>>> - const: aux >>>>>> - const: cfg_ahb >>>>>> - const: pipe >>>>>> + - const: anoc >>>>>> + - const: snoc >>>>> >>>>> OK, you did not test it. Neither this, nor DTS. I stop review, please >>>>> test first. >>>> >>>> I ran both `checkpatch.pl` and `make dt_binding_check`. What in this >>>> patch makes you say I "did not test it", and what test or tests did I miss? >>>> >>> >>> ... and no, you did not. If you tested, you would easily see error: >>> clock-names: ['aux', 'cfg_ahb', 'pipe'] is too short >>> >>> When you receive comment from reviewer, please investigate thoroughly >>> what could get wrong. Don't answer just to get rid of reviewer. It's >>> fine to make mistakes, but if reviewer points to issue and you >>> immediately respond "no issue", that's waste of my time. >> >> To clarify: "no issue" response is waste of my time. If you responded >> "oh, I see the error, but I don't know how to fix it", it would be ok, I >> can clarify and help in this. > > I apologize if I gave you this impression. I tried to follow the testing > process, it did not turn out as expected. Obviously, I missed something. > I tried to ask what I missed, and in order for that question to make > sense, I need to describe what I tried. > > It turns out what I missed was "make check_dtbs". I only found that out > after an automated email from Rob describing some troubleshooting steps. No, the dt_binding_check fails. You don't need to go to dtbs_check even, because the binding already has a failure. > > If I may have a few sentences to rant, I see the dt-schema as a hurdle > to making an otherwise useful change. I am told I can ask for help when > I get stuck, yet I manage to insult the maintainer by aking for help. I > find this very intimidating. I don't feel insulted but I feel my time is wasted if I tell you to test your binding and you immediately within few minutes respond "I tested", but then: 1. Bot confirms it was not tested, 2. I apply your patch and test it and see the failure. Best regards, Krzysztof