From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A793B6C0F for ; Tue, 17 Mar 2026 12:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773749388; cv=none; b=LDP+dbK/wAibGBT6fJqQt8UWOfW/YZXgV2c9k85VIZwh9TYGPCIx0tGcQ9KHR5RvC7iNsuGXzvIbtue2fQ7VF7eUYRjy609V57zrlljuz5lzL+1XynXf8wAhWK1hhTVe3zVoy3QxoMbKruj59drNbMzkwnIMIA/86+RtrfPDcV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773749388; c=relaxed/simple; bh=iWkKyWZAAuG0ORdfNAxtO5CUGZ+Y+pgWbF3QQdkr1AY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fn2EQPPmW9zT0CF0IsCsLiwxsloudPN31jP4VRk+IGhiH5T6/GDfpKfpvZTlEmfbZOyx+6Wok6xJYRAKFoHMxTChG01qDIHWFPQ8UM5pY4oDp5ieiin1+siQqJ3BxCh0E8NRl10fJSBg01qAPfaoEmoXaMY1Wk22ynwdcxC8PLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RKn/nB+m; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hd4L68GN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RKn/nB+m"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hd4L68GN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773749386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7HW8O6rPgR7FauUXL+o5Ae/r1xKJYBrSjy0JypWWimA=; b=RKn/nB+mgAkxC+KvWTZNxvVOAx1x11Tw/RfcTk12Q8ASRKTYVZpSYci02pVN22AvcjKLVw tIUoOr6c17Tyb8ue4/WY/3GeOSx4Y9mT+JZIMMldWNhOyVJ679RLNbU+CmBcO4P80Z+juV ahX1lIRyGiOWPi87f/Nxs7F8RrSSOIU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-nNWvtQ-9OMWe2ZYUfuM2gQ-1; Tue, 17 Mar 2026 08:09:45 -0400 X-MC-Unique: nNWvtQ-9OMWe2ZYUfuM2gQ-1 X-Mimecast-MFC-AGG-ID: nNWvtQ-9OMWe2ZYUfuM2gQ_1773749384 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-485397788b3so53033495e9.2 for ; Tue, 17 Mar 2026 05:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773749384; x=1774354184; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7HW8O6rPgR7FauUXL+o5Ae/r1xKJYBrSjy0JypWWimA=; b=Hd4L68GNXenG9J+uQYh5mgbB8rM3KhfmzE4CME1PphOR1JyR6ZlfZOoX16aA5du/r6 dfBThKl1WLAoV4uoDnDIzw8UsRAY+enbTOHmX69ynrsTQTnuMJ6QhzyChQZrj81LGxJA DukDHFu/mNglwnFQ/8inaj1GXSb56B9Y94LhbF5S4UjiDF2zgS6uqoRaNRsvL332qCh5 FY8fGHu/ZUVmsfEQB2l6qGLKD/8J0DxFmkbREXeR58LFnE6solCGH7QhZWYusxNQCYy4 cQpBdO5PFle0mysRqVM8moC7xAzB4doLzG0TU2gBi6EKWmDS/24Zf5DkCNJtitSGk/jr +iJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773749384; x=1774354184; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7HW8O6rPgR7FauUXL+o5Ae/r1xKJYBrSjy0JypWWimA=; b=mQWQ6+O/TUS5zoE6avu13WY5aDyeYYPRUqjgs8nHOBhOVAItWjODge4y7aIo0bhRWe PvsL9qNrdd7+loOmMXUHBN3+pl7+KRoWH0Zm4vyg2IJ3Ve44Sp08VfNQkUB/RUdm62h7 qvjvabPCwqrGWes7s5Y2QhfAeDAFQh4MXWbVaKSd3+I6ArNLn8RyWhsgKsqayeZhiSfk KewoVbxCgjbG4j77bB9SqHTbcRGZtxdpBjUEJHcbv2KOvfm3K0ffK/DZ1OdCkzP1MA+b iYe7WvUfjijYs6TSVezRdBCAgp4JS4ZxU+z1j34WxZpXgXtvqWpeIq+lc/8GzZMqxX45 vwtg== X-Gm-Message-State: AOJu0YzVbOUcHrRGo8gpFMaqAd8gvBYIVziN46GWodqyI5ZYZhnu1Bq8 X8lyUXwO11yPEWCW2oHLWVnXLTLGqD/OkRZZ5tf8aJzQXeVC6S8vVUOA7GR/4nZQJKXCU3ukVdD S1PXHrh78guNH7gSYkseLRXZ2c5flS4qHZH/cOK5M1ffB7O0wDoNIS+zYuYq3BJqJbg== X-Gm-Gg: ATEYQzwd6p7R4T02pvTkqLpWcnhTFiuZoQXjDZWPyT8M3SlAA6mJLAmTuPEFTYxfF1o z9sFGQpYaG5sRzv532ZQpTw0Iqr4HiZL8RN5jL3poArHYGFo9BH4Jq/lL+vlO5mmyr0o3PhEsKh qjbfScU5hwziBZ7R3dbdhj5s0BHoOIbW3wBsz1vSbYQIkE2Lp4U0Lwc8TMf+5mR50boR1YBoOvy b+MuGF9Lj4/39xGtOh4LIhkYFgXotSbBx4Iyei5fMUtqFIwrKNfZT8OWzoDFSIVeYBOHn/sMhbE dYReEF0InpzJjSqAl3ST5VIAfp30uiaUSOm2YOKbE532lKqijDiVwelhLQBsfk4oH6j2Ggkg6rP LC7Ui+CKb7sxl/bgdotDo8ROUCjkIbfKaoJsJ9eEbJKxi2+ZAXil7EFw= X-Received: by 2002:a05:600c:4592:b0:485:3dfc:57a with SMTP id 5b1f17b1804b1-4855671044fmr284696825e9.32.1773749384136; Tue, 17 Mar 2026 05:09:44 -0700 (PDT) X-Received: by 2002:a05:600c:4592:b0:485:3dfc:57a with SMTP id 5b1f17b1804b1-4855671044fmr284696185e9.32.1773749383627; Tue, 17 Mar 2026 05:09:43 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48634a7ac93sm41144035e9.2.2026.03.17.05.09.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 05:09:43 -0700 (PDT) Message-ID: <27b77086-4f08-4d97-bc7a-2b5a4754a5af@redhat.com> Date: Tue, 17 Mar 2026 13:09:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] amd-xgbe: synchronize KR training with device operations To: Raju Rangoju , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch, Thomas.Lendacky@amd.com, maxime.chevallier@bootlin.com References: <20260313134210.3824872-1-Raju.Rangoju@amd.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260313134210.3824872-1-Raju.Rangoju@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/13/26 2:42 PM, Raju Rangoju wrote: > @@ -2115,7 +2160,9 @@ static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata, > XP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, COMMAND, cmd); > XP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, sub_cmd); > > - /* Issue the command */ > + /* Acquire mailbox lock for firmware command */ > + guard(mutex)(&pdata->mailbox_lock); Also note that Documentation/process/maintainer-netdev.rst states: Use of ``guard()`` is discouraged within any function longer than 20 lines, ``scoped_guard()`` is considered more readable. Using normal lock/unlock is still (weakly) preferred. /P