mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Yan <yanaijie@huawei.com>
To: Wenchao Hao <haowenchao2@huawei.com>,
	John Garry <john.g.garry@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Damien Le Moal <dlemoal@kernel.org>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <louhongxiang@huawei.com>
Subject: Re: [PATCH] scsi:libsas: Simplify sas_queue_reset and remove unused code
Date: Mon, 31 Jul 2023 09:44:39 +0800	[thread overview]
Message-ID: <27bb586c-af75-c2da-1b07-02bfb08e5891@huawei.com> (raw)
In-Reply-To: <20230729102451.2452826-1-haowenchao2@huawei.com>

Hi Wenchao,

On 2023/7/29 18:24, Wenchao Hao wrote:
> sas_queue_reset is always called with param "wait" set to 0, so
> remove it from this function's param list. And remove unused
> function sas_wait_eh.

I did not find any users passing '1' to sas_queue_reset() in the git 
history. It seems it is never used. So It's ok to remove it, I guess.

Just one nit, there should be a blank between "scsi:" and "libsas" in 
the subject:

scsi: libsas: Simplify sas_queue_reset and remove unused code

Otherwise looks good to me:
Reviewed-by: Jason Yan <yanaijie@huawei.com>

  reply	other threads:[~2023-07-31  1:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29 10:24 Wenchao Hao
2023-07-31  1:44 ` Jason Yan [this message]
2023-07-31  2:05   ` Damien Le Moal
2023-07-31  2:30     ` Jason Yan
2023-08-15  2:18 ` Damien Le Moal
2023-08-30 12:52 ` haowenchao (C)
2023-08-31  1:25   ` Martin K. Petersen
2023-09-05 10:18 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27bb586c-af75-c2da-1b07-02bfb08e5891@huawei.com \
    --to=yanaijie@huawei.com \
    --cc=dlemoal@kernel.org \
    --cc=haowenchao2@huawei.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=louhongxiang@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®