From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5043C28CC0 for ; Thu, 30 May 2019 15:14:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 846F625C57 for ; Thu, 30 May 2019 15:14:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbfE3POC (ORCPT ); Thu, 30 May 2019 11:14:02 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:48000 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726359AbfE3POC (ORCPT ); Thu, 30 May 2019 11:14:02 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9535BBF56C35CC8F4E14; Thu, 30 May 2019 23:13:58 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Thu, 30 May 2019 23:13:54 +0800 Subject: Re: [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static To: , References: <20190418133633.3908-1-yuehaibing@huawei.com> CC: From: Yuehaibing Message-ID: <27bd7584-174f-5f1d-c8a6-68d819d6fa00@huawei.com> Date: Thu, 30 May 2019 23:13:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190418133633.3908-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Friendly ping... On 2019/4/18 21:36, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/phy/ti/phy-am654-serdes.c:250:12: warning: > symbol 'serdes_am654_xlate' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/phy/ti/phy-am654-serdes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/ti/phy-am654-serdes.c b/drivers/phy/ti/phy-am654-serdes.c > index d376920..f8edd08 100644 > --- a/drivers/phy/ti/phy-am654-serdes.c > +++ b/drivers/phy/ti/phy-am654-serdes.c > @@ -247,8 +247,8 @@ static void serdes_am654_release(struct phy *x) > mux_control_deselect(phy->control); > } > > -struct phy *serdes_am654_xlate(struct device *dev, struct of_phandle_args > - *args) > +static struct phy *serdes_am654_xlate(struct device *dev, > + struct of_phandle_args *args) > { > struct serdes_am654 *am654_phy; > struct phy *phy; >