From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10D652F60CC for ; Tue, 7 Apr 2026 12:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566621; cv=none; b=oYqAeyz3qiOQPOK+hJRnCBPdsXEKaqJjo8MSCpfbDGotTpFST8hgJiCDKo8ZgDR9alJ+fmv4Qbde0crHC2SgLgyPaWZKqsCwmXEo/8xxM5tS9DfL8tmer8fsNbWjQzfCTSCS10ye85D/Lo8Isd5oQ9pnr63k3nJXTaTPNXC7AxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566621; c=relaxed/simple; bh=vzmhas1Xj2z21+PdqsIMST2aK6g3TxINF5b/tKwSCAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bAhCuWlED/3TSeK+B8Yzp9SkkdN+ca2yG4PgwjkeLi+dAxLODmPtKpaPf+b7XhAx1AZ5zdK5Z5XeibNNz/V1lBen+EKShKSh62kjFt8u+kHXncX6LQZ4bDYQHTIspqrsj+nMcDbEBk1hhepssL9NLbkzUoY2EJtCGVDo5MfsOwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pZP1dxY+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cbyrDteU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pZP1dxY+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cbyrDteU" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637Chec73815666 for ; Tue, 7 Apr 2026 12:56:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WV+YzP7McTVo1FvY2lfizBt5kEJJS5AS/KHKnX29eC4=; b=pZP1dxY+4BdPDAbP IeRNkXqcwimQLTE2JJxjFJ+WUlVonvj25tLnayb8ACem8POM1IYjjbxnMDDB+9OM hFxY1PnWEmnnmTVlVn7mtPRQ4sChIk28QYNzKEZBts3lJ4ZQD3c5vfy1gnMPNVCk Gz71Fe+naX6qphASeW4z/zJnIvlbFqXhJJCFW4yhPsHC9mTEGeRKiVdLqawiLGVD ZJo4t3cPW+bZXVOxoDXngdjDSKAzmpN5mPW1Vi1w7gnjEzcrZq/+1jFnjrqEAsNB a2t6Zur9O/AGzOQwWMl425Y6wlkc+YHN7TJGw9CRoNTOeNpbwOin2HKNubydfUK8 KN67nA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr4tt6x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 12:56:58 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50b27636835so17371971cf.3 for ; Tue, 07 Apr 2026 05:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775566617; x=1776171417; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WV+YzP7McTVo1FvY2lfizBt5kEJJS5AS/KHKnX29eC4=; b=cbyrDteUnMlEmDi3YvWIQqIZgGoa6e+lA1ko48tWCnCtAOrfoVoUWhLmzQmW4zp5Iq Ikw6e3Uemq8h//XVNEP8ltr3V8vafACZtM7jyTdMfJf+fyh8grsmltNJ0y1cehSK9dxm j1UfPJdmRhfCPqOULgYaqXr7skw9cOMhTyQwZxF2kxdbAZO2cXxA6ecAAnAuNPo4laE4 ZgG9LEoBQIAsXDFarq56sDI4q2489oUzGaHJM5XLMgTA6+ZjEWsLzh4yvdW9RJtrOmSf xtmYhQu/ZTI3lZnkJA0Pi753dFhqfnBd9jV7Svw6tJmoqiI2otyQEH+4ukmEAIx4CveT AZ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775566617; x=1776171417; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WV+YzP7McTVo1FvY2lfizBt5kEJJS5AS/KHKnX29eC4=; b=dDyvLROaSfkdFZWrMzNjKePlT25v29w5EhaQeE9zYZnwSWdrW5Siyxz5rFboCGme3t Eqkv/HsuEgV/qneCc2W75KLlGwy08Dj8/5BLHZ2MhtInmTk966wo+8L1v00sZXIQfarM /tAaKqtoSTi4Gf2+OcukmtcQe9/wbOvkRm9DIf8ugVN8V7bE+a9sklXm0QL80R2LzQc/ jbg9SvmiUBF2mQEBxFdcWrpW18kMDP2oGKCj2iNYyiU1P7gFvJp+vcTNkZJViskQnKwP 5c6IDkdXdAmUZIlTy3LnkWMwZWHbYBsY2dUCDNPGPdwYehka4zfjTJlWAVMaEfjulVRg OLlA== X-Forwarded-Encrypted: i=1; AJvYcCU1IPdWUb40hXIPnXRfHtu4laKngTHf03XsA+sJO4DgBzv6hk9R+K+H/ekxZdyileW7sFa152Y6gyfTH5E=@vger.kernel.org X-Gm-Message-State: AOJu0YyIgttlcEY7+6kxmEW1HR1WohpBuhxBDzHfL2GK2l/SzGYhIO7p /OssHNgtIPIjRK1ovraZODM3WQx3BzV9pHV9iuw7Ccf+AIVQy5kzQ9Zs0ydNnvYY4dG6cPicje6 C/fPrjQ2IhBbpU099c+ar1e+bdgSvlJzZGB2U4DeEHLLAEXoF94YpWy2k8MRrFpxg4pc= X-Gm-Gg: AeBDiesT1IpAdYvgzUUr232YvOcA/fD4V6ZYBykzPQepzRuUR9T5JKQ4mPWuRRxqMAV sqoZQde97oi9J28a6mrdn3/JjPgz1AUy1Feqevc1jvoIzCcOKLZZq0wpOlpkKYOQ/DtaAtv01VO JxeQL8tOzw7O3Kgf64CKlUOll1HR4M+NkJ5tXg2Q9649Usg020QKQPIV8czL9SsA/faLMJY1TVC 0lbcId5C7cwzR5gvsPMGRrIc5JPZB8hiUT23GeTceHoDvbx48KIwpk6wdte4XIkf51qBvHN6HIk DCcDsnWnm8Xm61e+wEuQ/sBeW/vA1TnaJsCGl4hSVeEfISFDC3O/4iAx6rsZPDWExeIquo78+ZJ kLPrt8HYXrmuQXetGH9g0JLjQJKoUCWZ3/I/WU8yAn/lqljVY4FQqme/BYk2gi0g7cDCeJMmHKM kYNxA= X-Received: by 2002:a05:6214:202b:b0:89c:e371:2b42 with SMTP id 6a1803df08f44-8a701be0578mr215920626d6.2.1775566617513; Tue, 07 Apr 2026 05:56:57 -0700 (PDT) X-Received: by 2002:a05:6214:202b:b0:89c:e371:2b42 with SMTP id 6a1803df08f44-8a701be0578mr215920346d6.2.1775566617050; Tue, 07 Apr 2026 05:56:57 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cec6aabsm556663566b.34.2026.04.07.05.56.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 05:56:56 -0700 (PDT) Message-ID: <27c48c9c-32ba-4f92-834e-637dc728c6d3@oss.qualcomm.com> Date: Tue, 7 Apr 2026 14:56:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] soc: qcom: rpmh: Add support to read back resource settings To: Kamal Wadhwa , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Maulik Shah References: <20260407-read-rpmh-v3-v3-0-34079f92691c@oss.qualcomm.com> <20260407-read-rpmh-v3-v3-1-34079f92691c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260407-read-rpmh-v3-v3-1-34079f92691c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dO6WXuZb c=1 sm=1 tr=0 ts=69d4ff1a cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=aI3X9z-TDy9Gq4s1KZ4A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: MgkHZeQFCalX4puXhmUJSp7Pvyv2x_s7 X-Proofpoint-ORIG-GUID: MgkHZeQFCalX4puXhmUJSp7Pvyv2x_s7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEyMSBTYWx0ZWRfX0t0jcYKiokzt fK+K4pGwu+2Han114jmM3lICl0qjxGssWsHN2hsul4enieSWIawQyEAjxpnwb+Cgs8IUKitUeWA TyG1MGHTh1zmW28n/E6wHEN4u0XjedDbcgfgf5IU17UZflMTo6Rmjmm6ZTmqj794soOObge7X21 tLZsbyL5fnUtnAqw7zq//b43uQoPxKl1tVTpH8F2OjCXWW+/zOnwmwEWhjGAOIbH/3wZAMoRypf BzY5mpgUdrhV614ZUz+kNKtFB0qDtVWnxPnpVHRQagc+sNOIV+vTuCsYp/1q4Vooj0rHng9+BtL 19o0dvxO0gJE5U6PQeMrfNWMAOTb9ODfwutXeJ2gpFenX+d0OmGiaGmOr2nw+XPi7i8jELZoQMA G8FZI7lBD5waq6uNtWxHaRTRuUJDEWaAHDvOGQJgcOPY75rXZaQYIddxntur9/p9QVwDPBtGdj/ DMchN7tCPk6aFby4ogg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070121 On 4/7/26 6:43 AM, Kamal Wadhwa wrote: > From: Maulik Shah > > All rpmh_*() APIs so far have supported placing votes for various resource > settings but the H/W also have option to read resource settings. > > Add new rpmh_read() API to allow clients to read back resource setting > from H/W. This will be useful for clients like regulators, which currently > don't have a way to know the settings applied during bootloader stage. > > Signed-off-by: Maulik Shah > Signed-off-by: Kamal Wadhwa > --- [...] > @@ -453,6 +454,11 @@ static irqreturn_t tcs_tx_done(int irq, void *p) > > trace_rpmh_tx_done(drv, i, req); > > + if (req->is_read) { > + reg = drv->regs[RSC_DRV_CMD_RESP_DATA]; > + req->cmds[0].data = read_tcs_reg(drv, reg, i); Does this break if we send a request that contains a read request at index != 0, or chain multiple read commands? (is that possible?) Or perhaps this is fine, because the only way to "legally" send a read command is rpmh_read() which sends a message with just a single read command? Otherwise this patch looks good to me Konrad