From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753239AbdJLU3b (ORCPT ); Thu, 12 Oct 2017 16:29:31 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:36463 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbdJLU3a (ORCPT ); Thu, 12 Oct 2017 16:29:30 -0400 Subject: Re: [PATCH v4 0/5] sparc64: Optimize fls and __fls To: Vijay Kumar , davem@davemloft.net Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, rob.gardner@oracle.com, sam@ravnborg.org, anthony.yznaga@oracle.com References: <1507747806-10251-1-git-send-email-vijay.ac.kumar@oracle.com> From: Babu Moger Organization: Oracle Corporation Message-ID: <27c87a08-f4cc-cfe4-d944-25f8f703b664@oracle.com> Date: Thu, 12 Oct 2017 15:29:14 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507747806-10251-1-git-send-email-vijay.ac.kumar@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looked at all the patches. Looks good to me. Reviewed-by: Babu Moger On 10/11/2017 1:50 PM, Vijay Kumar wrote: > SPARC provides lzcnt instruction (with VIS3) which can be used to > optimize fls, __fls and fls64 functions. For the systems that supports > lzcnt instruction, we now do boot time patching to use sparc > optimized fls, __fls and fls64 functions. > > v3->v4: > - Fixed a typo. > v2->v3: > - Using ENTRY(), ENDPROC() for assembler functions. > - Removed BITS_PER_LONG from __fls. > - Using generic fls64(). > - Replaced lzcnt instruction with .word directive. > v1->v2: > - Fixed delay slot issue. > > Vijay Kumar (5): > sparc64: Define SPARC default fls function > sparc64: Define SPARC default __fls function > sparc64: SPARC optimized fls function > sparc64: SPARC optimized __fls function > sparc64: Use sparc optimized fls and __fls for T4 and above > > arch/sparc/include/asm/bitops_64.h | 5 ++- > arch/sparc/kernel/head_64.S | 2 + > arch/sparc/lib/Makefile | 3 ++ > arch/sparc/lib/NG4fls.S | 30 ++++++++++++++++ > arch/sparc/lib/NG4patch.S | 9 +++++ > arch/sparc/lib/fls.S | 67 ++++++++++++++++++++++++++++++++++++ > arch/sparc/lib/fls64.S | 61 ++++++++++++++++++++++++++++++++ > 7 files changed, 175 insertions(+), 2 deletions(-) > create mode 100644 arch/sparc/lib/NG4fls.S > create mode 100644 arch/sparc/lib/fls.S > create mode 100644 arch/sparc/lib/fls64.S >