From: Matthias Brugger <matthias.bgg@gmail.com>
To: Xiangsheng Hou <xiangsheng.hou@mediatek.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
benliang.zhao@mediatek.com, bin.zhang@mediatek.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v6 5/5] mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC
Date: Thu, 2 Feb 2023 13:19:36 +0100 [thread overview]
Message-ID: <27d1f8ae-4948-317d-b4a6-be7dc0dfe22a@gmail.com> (raw)
In-Reply-To: <20230201021500.26769-6-xiangsheng.hou@mediatek.com>
On 01/02/2023 03:15, Xiangsheng Hou wrote:
> Add ECC support fot MT7986 IC, and change err_mask value with
> GENMASK macro.
>
> Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/mtd/nand/ecc-mtk.c | 28 +++++++++++++++++++++++++---
> 1 file changed, 25 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/ecc-mtk.c b/drivers/mtd/nand/ecc-mtk.c
> index 9f9b201fe706..c75bb8b80cc1 100644
> --- a/drivers/mtd/nand/ecc-mtk.c
> +++ b/drivers/mtd/nand/ecc-mtk.c
> @@ -40,6 +40,10 @@
> #define ECC_IDLE_REG(op) ((op) == ECC_ENCODE ? ECC_ENCIDLE : ECC_DECIDLE)
> #define ECC_CTL_REG(op) ((op) == ECC_ENCODE ? ECC_ENCCON : ECC_DECCON)
>
> +#define ECC_ERRMASK_MT7622 GENMASK(4, 0)
> +#define ECC_ERRMASK_MT2701 GENMASK(5, 0)
> +#define ECC_ERRMASK_MT2712 GENMASK(6, 0)
> +
> struct mtk_ecc_caps {
> u32 err_mask;
> u32 err_shift;
> @@ -79,6 +83,10 @@ static const u8 ecc_strength_mt7622[] = {
> 4, 6, 8, 10, 12
> };
>
> +static const u8 ecc_strength_mt7986[] = {
> + 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24
> +};
> +
> enum mtk_ecc_regs {
> ECC_ENCPAR00,
> ECC_ENCIRQ_EN,
> @@ -451,7 +459,7 @@ unsigned int mtk_ecc_get_parity_bits(struct mtk_ecc *ecc)
> EXPORT_SYMBOL(mtk_ecc_get_parity_bits);
>
> static const struct mtk_ecc_caps mtk_ecc_caps_mt2701 = {
> - .err_mask = 0x3f,
> + .err_mask = ECC_ERRMASK_MT2701,
> .err_shift = 8,
> .ecc_strength = ecc_strength_mt2701,
> .ecc_regs = mt2701_ecc_regs,
> @@ -462,7 +470,7 @@ static const struct mtk_ecc_caps mtk_ecc_caps_mt2701 = {
> };
>
> static const struct mtk_ecc_caps mtk_ecc_caps_mt2712 = {
> - .err_mask = 0x7f,
> + .err_mask = ECC_ERRMASK_MT2712,
> .err_shift = 8,
> .ecc_strength = ecc_strength_mt2712,
> .ecc_regs = mt2712_ecc_regs,
> @@ -473,7 +481,7 @@ static const struct mtk_ecc_caps mtk_ecc_caps_mt2712 = {
> };
>
> static const struct mtk_ecc_caps mtk_ecc_caps_mt7622 = {
> - .err_mask = 0x1f,
> + .err_mask = ECC_ERRMASK_MT7622,
> .err_shift = 5,
> .ecc_strength = ecc_strength_mt7622,
> .ecc_regs = mt7622_ecc_regs,
> @@ -483,6 +491,17 @@ static const struct mtk_ecc_caps mtk_ecc_caps_mt7622 = {
> .pg_irq_sel = 0,
> };
>
> +static const struct mtk_ecc_caps mtk_ecc_caps_mt7986 = {
> + .err_mask = ECC_ERRMASK_MT7622,
> + .err_shift = 8,
> + .ecc_strength = ecc_strength_mt7986,
> + .ecc_regs = mt2712_ecc_regs,
> + .num_ecc_strength = 11,
> + .ecc_mode_shift = 5,
> + .parity_bits = 14,
> + .pg_irq_sel = 1,
> +};
> +
> static const struct of_device_id mtk_ecc_dt_match[] = {
> {
> .compatible = "mediatek,mt2701-ecc",
> @@ -493,6 +512,9 @@ static const struct of_device_id mtk_ecc_dt_match[] = {
> }, {
> .compatible = "mediatek,mt7622-ecc",
> .data = &mtk_ecc_caps_mt7622,
> + }, {
> + .compatible = "mediatek,mt7986-ecc",
> + .data = &mtk_ecc_caps_mt7986,
> },
> {},
> };
next prev parent reply other threads:[~2023-02-02 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 2:14 [PATCH v6 0/5] Add MediaTek MT7986 NAND ECC engine support Xiangsheng Hou
2023-02-01 2:14 ` [PATCH v6 1/5] dt-bindings: mtd: Split ECC engine with rawnand controller Xiangsheng Hou
2023-02-03 18:10 ` Miquel Raynal
2023-02-01 2:14 ` [PATCH v6 2/5] arm64: dts: mediatek: Fix existing NAND controller node name Xiangsheng Hou
2023-02-02 12:13 ` Matthias Brugger
2023-02-01 2:14 ` [PATCH v6 3/5] arm: " Xiangsheng Hou
2023-02-02 12:13 ` Matthias Brugger
2023-02-01 2:14 ` [PATCH v6 4/5] dt-bindings: mtd: mediatek,nand-ecc-engine: Add compatible for MT7986 Xiangsheng Hou
2023-02-03 18:10 ` Miquel Raynal
2023-02-01 2:15 ` [PATCH v6 5/5] mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC Xiangsheng Hou
2023-02-02 12:19 ` Matthias Brugger [this message]
2023-02-03 18:10 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27d1f8ae-4948-317d-b4a6-be7dc0dfe22a@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benliang.zhao@mediatek.com \
--cc=bin.zhang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=xiangsheng.hou@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®