From: Ziqi Chen <quic_ziqichen@quicinc.com>
To: Po-Wen Kao <powen.kao@mediatek.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
<quic_ziqichen@quicinc.com>
Cc: <wsd_upstream@mediatek.com>, <peter.wang@mediatek.com>,
<stanley.chu@mediatek.com>, <alice.chao@mediatek.com>,
<naomi.chu@mediatek.com>, <chun-hung.wu@mediatek.com>,
<cc.chou@mediatek.com>, <eddie.huang@mediatek.com>,
<mason.zhang@mediatek.com>, <chaotian.jing@mediatek.com>,
<jiajie.hao@mediatek.com>, <quic_cang@quicinc.com>,
<quic_asutoshd@quicinc.com>
Subject: Re: [PATCH v2 5/7] scsi: ufs: core: Remove redundant check
Date: Thu, 23 Feb 2023 18:52:10 +0800 [thread overview]
Message-ID: <27d2a4c4-2a4c-7fc6-4afb-cf5792e91d85@quicinc.com> (raw)
In-Reply-To: <20230222030427.957-6-powen.kao@mediatek.com>
On 2/22/2023 11:04 AM, Po-Wen Kao wrote:
> is_mcq_supported() already check on use_mcq_mode.
>
> Signed-off-by: Po-Wen Kao <powen.kao@mediatek.com>
reviewed-by: Ziqi Chen <quic_ziqichen@quicinc.com>
> ---
> drivers/ufs/core/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index a15a5a78160c..21e3bf5d8f08 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8548,7 +8548,7 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params)
> hba->scsi_host_added = true;
> }
> /* MCQ may be disabled if ufshcd_alloc_mcq() fails */
> - if (is_mcq_supported(hba) && use_mcq_mode)
> + if (is_mcq_supported(hba))
> ufshcd_config_mcq(hba);
> }
>
next prev parent reply other threads:[~2023-02-23 10:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 3:04 [PATCH v2 0/7] Several UFS MCQ Code Changes Po-Wen Kao
2023-02-22 3:04 ` [PATCH v2 1/7] scsi: ufs: core: Fix mcq tag calcualtion Po-Wen Kao
2023-02-23 10:22 ` Ziqi Chen
2023-02-22 3:04 ` [PATCH v2 2/7] scsi: ufs: core: Rename symbols Po-Wen Kao
2023-02-22 3:11 ` Stanley Chu
2023-02-23 10:27 ` Ziqi Chen
2023-02-27 22:41 ` Bart Van Assche
2023-02-22 3:04 ` [PATCH v2 3/7] scsi: ufs: core: Fix mcq nr_hw_queues Po-Wen Kao
2023-02-22 3:16 ` Stanley Chu
2023-02-23 10:32 ` Ziqi Chen
2023-02-23 14:43 ` Powen Kao (高伯文)
2023-02-27 22:41 ` Bart Van Assche
2023-02-22 3:04 ` [PATCH v2 4/7] scsi: ufs: core: Add hwq print for debug Po-Wen Kao
2023-02-23 10:14 ` Ziqi Chen
2023-02-23 10:49 ` Ziqi Chen
2023-02-23 14:13 ` Powen Kao (高伯文)
2023-02-27 3:14 ` Ziqi Chen
2023-02-28 2:57 ` Bao D. Nguyen
2023-03-01 2:17 ` Powen Kao (高伯文)
2023-03-01 18:50 ` Bart Van Assche
2023-03-01 18:55 ` Slade's Kernel Patch Bot
2023-02-27 22:47 ` Bart Van Assche
2023-02-22 3:04 ` [PATCH v2 5/7] scsi: ufs: core: Remove redundant check Po-Wen Kao
2023-02-22 3:33 ` Stanley Chu
2023-02-23 10:52 ` Ziqi Chen [this message]
2023-02-22 3:04 ` [PATCH v2 6/7] scsi: ufs: core: Export symbols for MTK driver module Po-Wen Kao
2023-02-22 5:19 ` Stanley Chu
2023-02-22 3:04 ` [PATCH v2 7/7] scsi: ufs: mtk-host: Add MCQ support for MTK platform Po-Wen Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27d2a4c4-2a4c-7fc6-4afb-cf5792e91d85@quicinc.com \
--to=quic_ziqichen@quicinc.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mason.zhang@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®