From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B804EC6FD1D for ; Fri, 17 Mar 2023 10:47:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbjCQKr5 (ORCPT ); Fri, 17 Mar 2023 06:47:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbjCQKrx (ORCPT ); Fri, 17 Mar 2023 06:47:53 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15BE738E96 for ; Fri, 17 Mar 2023 03:47:52 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32HABu1c032534; Fri, 17 Mar 2023 05:45:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=JhmEC93g+SxlROvIkYC7tyHstq9M2CgefcOULYathYE=; b=i1IWqaIHUhbr7mManT/cOWX/6ohQC9aFxy4tp7CZdivbzuPzdMXbXAMWg6J4PcDoYjpK rUz+bgP0FS0koY6Vaq0pSgYUfLeS8lVL+ePDH9LYS3nGNZX2KTigOZLP3ZKSZtD/tnB1 j06CQ3XI6W6+Ej4iVRCHrv91vhXW95X6gMmsPAP0jrPfatVXlfi6ALKGco5slsB04Oe9 UTy3swRRyU44orn01pJIrLBtLQ/QGGRJG8uhvlnVn/hL6ErU5DtSBTSQEYPIFxvmkWz4 qiz9gRZp9HVctoeMw3f8mQRvbaF5VQo/zDQboWwR7IRUyBUtYZD0lgtXrPxjdCMcjkmW +A== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3pbs3b9x06-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Mar 2023 05:45:45 -0500 Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Fri, 17 Mar 2023 05:45:43 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Fri, 17 Mar 2023 05:45:43 -0500 Received: from [198.90.251.127] (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.127]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id DC8A411D3; Fri, 17 Mar 2023 10:45:42 +0000 (UTC) Message-ID: <27d797fb-c68b-ebc0-7d87-39c6287415e8@opensource.cirrus.com> Date: Fri, 17 Mar 2023 10:45:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 8/8] ASoC: cs35l56: Add driver for Cirrus Logic CS35L56 Content-Language: en-US From: Richard Fitzgerald To: kernel test robot , Richard Fitzgerald via Alsa-devel , , CC: , , , , , , Simon Trimmer References: <167872265923.26.336497278776737619@mailman-core.alsa-project.org> <202303170422.ZYpOtc4P-lkp@intel.com> <2f983fe6-8c43-be16-758b-098ea461836b@opensource.cirrus.com> In-Reply-To: <2f983fe6-8c43-be16-758b-098ea461836b@opensource.cirrus.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: eFWrPVLIvg54Zq8KlnYfb8DSZi5XORmD X-Proofpoint-ORIG-GUID: eFWrPVLIvg54Zq8KlnYfb8DSZi5XORmD X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/03/2023 10:40, Richard Fitzgerald wrote: > On 16/03/2023 20:15, kernel test robot wrote: >> Hi Richard, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on broonie-sound/for-next] >> [also build test ERROR on linus/master v6.3-rc2 next-20230316] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url: >> https://github.com/intel-lab-lkp/linux/commits/Richard-Fitzgerald-via-Alsa-devel/ASoC-wm_adsp-Use-no_core_startstop-to-prevent-creating-preload-control/20230313-235605 >> base: >> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git >> for-next >> patch link: >> https://lore.kernel.org/r/167872265923.26.336497278776737619%40mailman-core.alsa-project.org >> patch subject: [PATCH v2 8/8] ASoC: cs35l56: Add driver for Cirrus >> Logic CS35L56 >> config: s390-randconfig-r044-20230313 >> (https://download.01.org/0day-ci/archive/20230317/202303170422.ZYpOtc4P-lkp@intel.com/config) >> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project >> 67409911353323ca5edf2049ef0df54132fa1ca7) >> reproduce (this is a W=1 build): >>          wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>          chmod +x ~/bin/make.cross >>          # install s390 cross compiling tool for clang build >>          # apt-get install binutils-s390x-linux-gnu >>          # >> https://github.com/intel-lab-lkp/linux/commit/5856c94d659f9c9963f5c37762cf201e1f1765e9 >>          git remote add linux-review >> https://github.com/intel-lab-lkp/linux >>          git fetch --no-tags linux-review >> Richard-Fitzgerald-via-Alsa-devel/ASoC-wm_adsp-Use-no_core_startstop-to-prevent-creating-preload-control/20230313-235605 >>          git checkout 5856c94d659f9c9963f5c37762cf201e1f1765e9 >>          # save the config file >>          mkdir build_dir && cp config build_dir/.config >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >> W=1 O=build_dir ARCH=s390 olddefconfig >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >> W=1 O=build_dir ARCH=s390 SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag where applicable >> | Reported-by: kernel test robot >> | Link: >> https://lore.kernel.org/oe-kbuild-all/202303170422.ZYpOtc4P-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >>     s390x-linux-ld: sound/soc/codecs/cs35l56.o: in function >> `cs35l56_dsp_work': >>>> sound/soc/codecs/cs35l56.c:887: undefined reference to >>>> `sdw_write_no_pm' >>>> s390x-linux-ld: sound/soc/codecs/cs35l56.c:888: undefined reference >>>> to `sdw_read_no_pm' >>>> s390x-linux-ld: sound/soc/codecs/cs35l56.c:889: undefined reference >>>> to `sdw_write_no_pm' >>     s390x-linux-ld: sound/soc/codecs/cs35l56.c:953: undefined >> reference to `sdw_write_no_pm' >>     s390x-linux-ld: sound/soc/codecs/cs35l56.o: in function >> `cs35l56_sdw_dai_hw_params': >>>> sound/soc/codecs/cs35l56.c:710: undefined reference to >>>> `sdw_stream_add_slave' >>     s390x-linux-ld: sound/soc/codecs/cs35l56.o: in function >> `cs35l56_sdw_dai_hw_free': >>>> sound/soc/codecs/cs35l56.c:729: undefined reference to >>>> `sdw_stream_remove_slave' >> > > I don't understand what's happened here. > include/linux/soundwire/sdw.h provides inline dummy versions of these > functions if !IS_ENABLED(CONFIG_SOUNDWIRE) so how can they be > undefined reference? Oh, I see it now. CONFIG_SOUNDWIRE=m but CONFIG_SND_SOC_CS35L56=y so it can't link.