From: Marc Zyngier <marc.zyngier@arm.com>
To: Lina Iyer <ilina@codeaurora.org>, evgreen@chromium.org
Cc: bjorn.andersson@linaro.org, rplsssn@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
rnayak@codeaurora.org, andy.gross@linaro.org, sboyd@kernel.org,
dianders@chromium.org
Subject: Re: [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC
Date: Fri, 28 Sep 2018 11:40:22 +0100 [thread overview]
Message-ID: <27d7df0d-4429-dcdd-f527-a33f9385b4e0@arm.com> (raw)
In-Reply-To: <20180927171810.22968-1-ilina@codeaurora.org>
On 27/09/18 18:18, Lina Iyer wrote:
> The PDC irqchp can convert a falling edge or level low interrupt to a
> rising edge or level high interrupt at the GIC. We just need to setup
> the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH
> as IRQ_TYPE_EDGE_RISING at the GIC.
>
> Reported-by: Evan Green <evgreen@chromium.org>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---
> drivers/irqchip/qcom-pdc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
> index b1b47a40a278..faa7d61b9d6c 100644
> --- a/drivers/irqchip/qcom-pdc.c
> +++ b/drivers/irqchip/qcom-pdc.c
> @@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)
> break;
> case IRQ_TYPE_EDGE_BOTH:
> pdc_type = PDC_EDGE_DUAL;
> + type = IRQ_TYPE_EDGE_RISING;
> break;
> case IRQ_TYPE_LEVEL_HIGH:
> pdc_type = PDC_LEVEL_HIGH;
>
Queued for 4.20, with
Fixes: f55c73aef890 ("irqchip/pdc: Add PDC interrupt controller for QCOM
SoCs")
added. Please consider providing these tags in the future.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-09-28 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 17:18 Lina Iyer
2018-09-27 18:04 ` Evan Green
2018-09-28 10:40 ` Marc Zyngier [this message]
2018-09-28 14:57 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27d7df0d-4429-dcdd-f527-a33f9385b4e0@arm.com \
--to=marc.zyngier@arm.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=rplsssn@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®