From: Markus Elfring <Markus.Elfring@web.de>
To: Keyur Patel <iamkeyur96@gmail.com>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org
Cc: Christian Gromm <christian.gromm@microchip.com>,
Colin Ian King <colin.king@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Suresh Udipi <sudipi@jp.adit-jv.com>,
linux-kernel@vger.kernel.org
Subject: Re: [v3] staging: most: remove redundant print statement when kfifo_alloc fails
Date: Sun, 14 Jul 2019 16:42:11 +0200 [thread overview]
Message-ID: <27df9bec-dbd5-8267-8df2-4948ca14e6d4@web.de> (raw)
In-Reply-To: <20190711175055.25157-1-iamkeyur96@gmail.com>
> This print statement is redundant as kfifo_alloc just calls kmalloc_array
> and without the __GFP_NOWARN flag, already does a dump_stack().
I suggest to omit the word “and” from this sentence.
Will any further wording adjustments become helpful for commit descriptions?
> Changes in v3:
> - fix checkpatch warrning
> ---
Please move such version information below the triple dashes without a typo.
Regards,
Markus
next prev parent reply other threads:[~2019-07-14 14:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 11:08 [PATCH 2/2] " Keyur Patel
2019-07-11 17:39 ` [PATCH v2] staging: most: remove redundant print statement when Keyur Patel
2019-07-11 17:50 ` [PATCH v3] staging: most: remove redundant print statement when kfifo_alloc fails Keyur Patel
2019-07-14 14:42 ` Markus Elfring [this message]
2019-07-14 15:05 ` [PATCH v4] " Keyur Patel
2019-07-14 15:23 ` [v4] " Markus Elfring
2019-07-14 15:45 ` Keyur Patel
2019-07-14 15:47 ` Keyur Patel
2019-07-14 16:20 ` Markus Elfring
2019-07-15 7:32 ` Greg Kroah-Hartman
2019-07-14 16:41 ` [PATCH v4] staging: most: Delete an error message for a failed memory allocation Keyur Patel
2019-07-14 16:55 ` [v4] " Markus Elfring
2019-07-14 17:04 ` Keyur Patel
2019-07-14 17:12 ` Markus Elfring
2019-07-14 17:27 ` [PATCH v5] " Keyur Patel
2019-07-14 17:38 ` [v5] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27df9bec-dbd5-8267-8df2-4948ca14e6d4@web.de \
--to=markus.elfring@web.de \
--cc=christian.gromm@microchip.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=iamkeyur96@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipi@jp.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome