From: Dave Gerlach <d-gerlach@ti.com>
To: Johan Hovold <johan@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Nishanth Menon <nm@ti.com>, <linux-pm@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>, Keerthy J <j-keerthy@ti.com>,
<linux-kernel@vger.kernel.org>, Tero Kristo <t-kristo@ti.com>,
Stephen Boyd <sboyd@kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] cpufreq: ti-cpufreq: Only register platform_device when supported
Date: Thu, 23 Aug 2018 11:24:58 -0500 [thread overview]
Message-ID: <27e25e06-2721-87dd-3e9b-8d91f6c49449@ti.com> (raw)
In-Reply-To: <20180823075058.GR14967@localhost>
On 08/23/2018 02:50 AM, Johan Hovold wrote:
> On Wed, Aug 22, 2018 at 09:44:32PM -0500, Dave Gerlach wrote:
>> Currently the ti-cpufreq driver blindly registers a 'ti-cpufreq' to force
>> the driver to probe on any platforms where the driver is built in.
>> However, this should only happen on platforms that actually can make use
>> of the driver. There is already functionality in place to match the
>> SoC compatible so let's factor this out into a separate call and
>> make sure we find a match before creating the ti-cpufreq driver device.
>>
>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
>> ---
>> drivers/cpufreq/ti-cpufreq.c | 25 ++++++++++++++++++++-----
>> 1 file changed, 20 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
>> index 3f0e2a14895a..541fdcf17b57 100644
>> --- a/drivers/cpufreq/ti-cpufreq.c
>> +++ b/drivers/cpufreq/ti-cpufreq.c
>> @@ -201,19 +201,31 @@ static const struct of_device_id ti_cpufreq_of_match[] = {
>> {},
>> };
>>
>> +static const struct of_device_id *ti_cpufreq_match_node(void)
>> +{
>> + struct device_node *np;
>> + const struct of_device_id *match;
>> +
>> + np = of_find_node_by_path("/");
>> + match = of_match_node(ti_cpufreq_of_match, np);
>> + of_node_put(np);
>> +
>> + if (!match)
>> + return NULL;
>> + else
>> + return match;
>
> Shouldn't this just be "return match"?
Whoops, yes that's an entirely pointless check I added.
>
>> +}
>> +
>> static int ti_cpufreq_probe(struct platform_device *pdev)
>> {
>> u32 version[VERSION_COUNT];
>> - struct device_node *np;
>> const struct of_device_id *match;
>> struct opp_table *ti_opp_table;
>> struct ti_cpufreq_data *opp_data;
>> const char * const reg_names[] = {"vdd", "vbb"};
>> int ret;
>>
>> - np = of_find_node_by_path("/");
>> - match = of_match_node(ti_cpufreq_of_match, np);
>> - of_node_put(np);
>> + match = ti_cpufreq_match_node();
>> if (!match)
>> return -ENODEV;
>>
>> @@ -290,7 +302,10 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
>>
>> static int ti_cpufreq_init(void)
>> {
>> - platform_device_register_simple("ti-cpufreq", -1, NULL, 0);
>> + /* Check to ensure we are on a compatible platform */
>> + if (ti_cpufreq_match_node())
>> + platform_device_register_simple("ti-cpufreq", -1, NULL, 0);
>> +
>> return 0;
>> }
>> module_init(ti_cpufreq_init);
>
> With that fixed, feel free to add:
>
> Reviewed-by: Johan Hovold <johan@kernel.org>
Thanks for the review I will update and resend.
Regards,
Dave
>
> Johan
>
prev parent reply other threads:[~2018-08-23 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 2:44 Dave Gerlach
2018-08-23 7:50 ` Johan Hovold
2018-08-23 16:24 ` Dave Gerlach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27e25e06-2721-87dd-3e9b-8d91f6c49449@ti.com \
--to=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=johan@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®