From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A06253F05 for ; Tue, 7 Apr 2026 21:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775596663; cv=none; b=U79wNyd+o7kydBf3oqeBBG9rX3AufsNUycIXxrbb6j0nc1SWKLVQX67lrVwR6Mz23xXKfYJAFJwPL+geeJnYk+uOEKnKSbv4u2gcfoBxplTpnhaKFIkAGAJ747Ty7d5QmF3CjlA5zwZ0T/D5fqaHH2fUFlvH2ED0DFPIb3mnuiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775596663; c=relaxed/simple; bh=CW2mmqVPJOfpQ+uwXf2PtNaHas3MeOWFcHTYfSdcq0A=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=jYdWEKkWeg+yG69cCVjBR9b0wW5Q+Pro5XYc/LlbvH/egHAnSZZhIHg+MCDdgiR0pPq1B4rTr5a3KGH8yc+AOF3gT+WaeITj0lu1QLcvAeZ1apgN5cZZML/nmbd+wH5BS62FrTbGlGv0koIEHbmvcDnD0fSIwd2XJ1nCqGvB0Ac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L9Z7GZ1Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CRTrAy0U; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L9Z7GZ1Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CRTrAy0U" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637KOC2t249536 for ; Tue, 7 Apr 2026 21:17:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uEwzIG/WP3KfeGGQytAvkF+cLGebDaMgBafkG54molA=; b=L9Z7GZ1Q3EFl1S+D FtFp7TyJHqGUwFpXxRrSIYRA6txv+kkIweUM48X00KEOV6T6z0Cfhchg0Zj3BLbF Z+e0ZUKbBQyQ+V75gWyVBd+fZvhGxjoRj0yIv5DZ3gaQAQYgls2I/T1q2hvze8lY uhtGm2yx691Or2svpfLQvIgv0zFO2MI94EdaY98w+vvBE3IZcAo2GfVrmySKhE6S W1hagftbsjrgTXR2AFh6Ic6/f1AViEoBHwQLyY1TnbqddzDkye3o5x6SmE4+2/jU p+UNWjbhw9618Fa2eU5S7SOTk2D+ZLu7CQe/xMEZSUtT38ihJ7ier+XgGEceV3oz EyD1xQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dd8x984mk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 21:17:42 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c76fdf996a1so780677a12.3 for ; Tue, 07 Apr 2026 14:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775596661; x=1776201461; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=uEwzIG/WP3KfeGGQytAvkF+cLGebDaMgBafkG54molA=; b=CRTrAy0UVS9NLszitUdA2d/it7gkgpWC4UKWYkiv9MOlufKlaPh/zgQ0caiEoTpOsp qLQl7mSxkvVRYHy9FtH5fzD5TMk9TNWo0zFuL1ptpXzgxj52GKb5iW9tT6CdbBVXROxG nlBrGz4MyFy4+x+FJ85STZxJm5e3/+ODAtSaMiiAwGK/LMT86Ksg3yu3d5zicS2bA2HX DrBPz+lH4ZphvoCq85ecUet8kzboxWIzByRUsS1yMTbfyzTZi1T6o5OWv2etyxaFxuCz ztT/ZkdOS7h6S8Z2crQNBHP7fplLCb/Y2YS5hB1UlCCQvM0izSuURqtzc303cnsdkRJS cFGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775596661; x=1776201461; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uEwzIG/WP3KfeGGQytAvkF+cLGebDaMgBafkG54molA=; b=IeSJD3XV/t0gUtuQsnxQfdDUM1iDIQUf/Mxb11U5lWiDBHpDupsr02Hmf8bO34Uj/V +OuxHEnMarYyQOtIuRJfDL3AcxYcWpUDC0thd+cqFgRhkoiS1TG6iBKzAmh8kgA4r2El 4ibzSffca83S5J7hlDkxO5HBltIlJXEHw7P+yHp/Srtr+cCLYKvry87Z2qRwQbx0p47z yPqRUM602nO7AS88R22yheKP3lCpx68kwN5urYYFYbYQyIrmIZyNfpxBZKxez5EPQyd1 l3W4gn2rQ3CROM9fQw1T5hre0F5G07DYfKHGg60MMznO417jld6NS4EnpDL+q21fuP7E +UPA== X-Forwarded-Encrypted: i=1; AJvYcCVUpWlzvEDBvdxmPoHFvto9BXnLsuLGeidpJAoxWDB//SSlRV4O1W22qC1IEwsnrsNeU2KTq+5iMhkUywE=@vger.kernel.org X-Gm-Message-State: AOJu0YzzuuGWmHwlMqBTudnISG0zuaAgzN03Fp3TIqID1q448WZmGg9c E3eo6LqBUmSQJIRXPIgQLVlOwskg8plAL3u7LKBcAn6cqqzC6ACvRCJsqSGJB076J6rYFMo69km fF682bp6PvQ3VNqUApvVpndylRY42nEi2wHTC3NlLsT21i1k1PgDn8eIIfTs+jST8tQM= X-Gm-Gg: AeBDieuT7aS3JwjBTkUE2YpeDhOhu815fBLK4hNqSVavoSLqo08e1jLyZ5gjJ+uzepG lGHxqN0bqkznDywNkwlYELXNXYAK2YxAq31bj0lXdtpKpjQkA4OzatwuLD59Iuk6lzd46nMsGnt XPh44zktrLHs/cciac7ITZbyaor2YO/n0588WAbyo4PdgmiYonTuuh2JTuxkXvsQ8kdXKFSBiq9 YZfraJKB5K9gCbE27+1F7/oOsQ7ASYCWXXz7QVh5RvOq19eEbOG9BmqP+IsdVEvKteRJGji/e7N 9WOF1mwhW8BmAf35GxosCvMIcz8UJhrP6RjAnnj6UKzE7rHuJ+qAKeAzO0J16fRTK/HSufYY9hG ktAQQnBuz+fJmEch1nMyXkALaL2lVuaIBH6F+UKdvs5QDuw== X-Received: by 2002:a05:6a00:1ac9:b0:82d:24f:2516 with SMTP id d2e1a72fcca58-82d0da2b115mr16522215b3a.11.1775596661266; Tue, 07 Apr 2026 14:17:41 -0700 (PDT) X-Received: by 2002:a05:6a00:1ac9:b0:82d:24f:2516 with SMTP id d2e1a72fcca58-82d0da2b115mr16522166b3a.11.1775596660698; Tue, 07 Apr 2026 14:17:40 -0700 (PDT) Received: from [192.168.1.8] ([106.222.229.237]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b6113dsm16813935b3a.23.2026.04.07.14.17.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 14:17:39 -0700 (PDT) Message-ID: <27e2e6c8-fd8b-446a-9ef5-802e1af0fb2b@oss.qualcomm.com> Date: Wed, 8 Apr 2026 02:47:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 4/6] drm/msm/a8xx: use pipe protect slot 15 for last-span-unbound feature From: Akhil P Oommen To: Alexander Koskovich Cc: Luca Weiss , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Bjorn Andersson References: <20260402-adreno-810-v2-0-ce337ca87a9e@pm.me> <20260402-adreno-810-v2-4-ce337ca87a9e@pm.me> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Rr716imK c=1 sm=1 tr=0 ts=69d57476 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=oIjhDLspr5RTlLLUpj0f1A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=qS-k9e48XBCiOm6aCyoA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDE5NCBTYWx0ZWRfX01bNakcz1CSy QuGpQWD+xlahEQqj+6wHxQgqI7DjdY/bO5qlIO7cnXP94C/ZgC4vvW88q2ccV/QTPavo+Zoz49N WAY+cPplL7Lyn/Dqk+LfF3Mb8NYske9zcyngwHZe6CBZHhgTYHZMl1DK+KxLy0gWA21SQ4ciVYk iAeW3TXhuni/q8sMMzL3OFbZi2Jn5Ic/LbiHU5U99KHH3BNZqoQNIZ9UlW0HGz0GWmpTaHZnGJj znyJ85uRkhIeN4nfGEl4ElCin90f8QrQQbyMkSStR3PaiGvyiCh4HBimHTR7IeGxERvHtohuvXi gQ3WHOOK3tpOBK9IcuuOFe0bkEpRjnK1VV/mSWqgnR+U6AHOpEnk/iUyv6O/QpMAwIooknQ5ywl 6ouC7zD+tM80PpxMVhGVBACpLBORYWc9w4iVDhHShZtRkHqSG1xnmi0MN15LJNrF5IIkZXBqw04 3jhGJ1e3vGUxYM3LOgg== X-Proofpoint-ORIG-GUID: hB4J8bbMFA3eXboOMU5UGMJqapO8uk9x X-Proofpoint-GUID: hB4J8bbMFA3eXboOMU5UGMJqapO8uk9x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_04,2026-04-07_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070194 On 4/8/2026 2:44 AM, Akhil P Oommen wrote: > On 4/3/2026 4:39 AM, Alexander Koskovich wrote: >> A8XX GPUs have two sets of protect registers: 64 global slots and 16 >> pipe specific slots. The last-span-unbound feature is only available >> on pipe protect registers, and should always target pipe slot 15. >> >> This matches the downstream driver which hardcodes pipe slot 15 for >> all A8XX GPUs (GRAPHICS.LA.15.0.r1) and resolves protect errors on >> A810. >> >> Reviewed-by: Konrad Dybcio >> Signed-off-by: Alexander Koskovich > > Reviewed-by: Akhil P Oommen > > -Akhil > >> --- >> drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c >> index 8b4b022d9a6b..102d5e751536 100644 >> --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c >> @@ -252,11 +252,12 @@ static void a8xx_set_cp_protect(struct msm_gpu *gpu) >> } >> >> /* >> - * Last span feature is only supported on PIPE specific register. >> - * So update those here >> + * Last span setting is only being applied to the last pipe specific >> + * register. Hence duplicate the last span from protect reg into the >> + * BR and BV protect reg pipe 15. Not sure why you modified the comment. The original comment is accurate. LS feature is present only in the last PIPE specific protect register. -Akhil. >> */ >> - a8xx_write_pipe(gpu, PIPE_BR, REG_A8XX_CP_PROTECT_PIPE(protect->count_max), final_cfg); >> - a8xx_write_pipe(gpu, PIPE_BV, REG_A8XX_CP_PROTECT_PIPE(protect->count_max), final_cfg); >> + a8xx_write_pipe(gpu, PIPE_BR, REG_A8XX_CP_PROTECT_PIPE(15), final_cfg); >> + a8xx_write_pipe(gpu, PIPE_BV, REG_A8XX_CP_PROTECT_PIPE(15), final_cfg); >> >> a8xx_aperture_clear(gpu); >> } >> >