From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbdKHPcC (ORCPT ); Wed, 8 Nov 2017 10:32:02 -0500 Received: from osg.samsung.com ([64.30.133.232]:43822 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751304AbdKHPcA (ORCPT ); Wed, 8 Nov 2017 10:32:00 -0500 Subject: Re: [PATCH] selftests: futex: fix compilation error To: lei yang Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Shuah Khan References: <1509941009-11521-1-git-send-email-Lei.Yang@windriver.com> <6b0b866a-b142-8c07-41e3-d561d4b91fb3@osg.samsung.com> <3605f466-52f7-fdac-0d08-01361648b801@osg.samsung.com> From: Shuah Khan Message-ID: <27e3a0de-3197-01c2-a7ea-780bb5d7533c@osg.samsung.com> Date: Wed, 8 Nov 2017 08:31:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2017 12:55 AM, lei yang wrote: > > > On 2017年11月08日 06:57, Shuah Khan wrote: >> On 11/06/2017 06:18 PM, lei yang wrote: >>> >>> On 2017年11月07日 07:48, Shuah Khan wrote: >>>> On 11/06/2017 04:45 PM, Shuah Khan wrote: >>>>> On 11/05/2017 09:03 PM, Lei Yang wrote: >>>>>> I run into below error when building futext >>>>>> /bin/sh: -c: line 5: syntax error: unexpected end of file >>>>>> >>>>>> the closing ";" and "\" are necessary. >>>>>> My OS is "Ubuntu 14.04.5 LTS" >>>>>> >>>>>> Signed-off-by: Lei Yang >>>>>> --- >>>>>>    tools/testing/selftests/futex/Makefile | 6 +++--- >>>>>>    1 file changed, 3 insertions(+), 3 deletions(-) >>>>>> >>>>>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile >>>>>> index f0c0369..943f3a2 100644 >>>>>> --- a/tools/testing/selftests/futex/Makefile >>>>>> +++ b/tools/testing/selftests/futex/Makefile >>>>>> @@ -11,9 +11,9 @@ all: >>>>>>            BUILD_TARGET=$(OUTPUT)/$$DIR;    \ >>>>>>            mkdir $$BUILD_TARGET  -p;    \ >>>>>>            make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\ >>>>>> -        if [ -e $$DIR/$(TEST_PROGS) ]; then >>>>>> -            rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; >>>>>> -        fi >>>>>> +        if [ -e $$DIR/$(TEST_PROGS) ]; then \ >>>>>> +            rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \ >>>>>> +        fi \ >>>>>>        done >>>>>>      override define RUN_TESTS >>>>>> >>>>> Hmm. I don't see this error on linux_4.14-rc8? >>>>> >>>>> Can you give more details on the gcc version you are using? >>>> I meant gnumake version? I am not seeing the failure with what I am >>>> using >>> $ make -v >>> GNU Make 3.81 >>> Copyright (C) 2006  Free Software Foundation, Inc. >>> This is free software; see the source for copying conditions. >>> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A >>> PARTICULAR PURPOSE. >>> >>> This program built for x86_64-pc-linux-gnu >>> >>> >>> Lei >>> >> I can't take patches that aren't tested on the latest kernel release. >> 3.16 is very old. I am not going reply to other patches you sent. >> >> Please make sure the patches are based on the latest release and tested >> on it as well. > > this error only happens when use old version "make", it has nothing to do with the new or old kernel. > > so the question is  do we need to be compatible with old "make" ? > > Lei > Like I said, Linux 3.16 kernel is very old and I won't take patches that are tested on it. thanks, -- Shuah