From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA32C77B6E for ; Fri, 14 Apr 2023 10:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbjDNKiO (ORCPT ); Fri, 14 Apr 2023 06:38:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbjDNKiJ (ORCPT ); Fri, 14 Apr 2023 06:38:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80EBF7DB6; Fri, 14 Apr 2023 03:37:59 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 700026603222; Fri, 14 Apr 2023 11:37:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681468678; bh=BUuGaSkZM2nCpFU3QyykMjfVSkXvIL1wWXGYo3FGrgw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aaQRE84z8irPODJ03rRb32DA02APcoi4S2lmY6kpI8sCSWhhS2EJmqmrLn7MRQBSB 2Ixia+BLNrJhPEGKM/1Thg6/qpbqr/T0YtFfMr24rZpJ20AOxKAOB0+EJkYDfB0XuE B/F8MSKt9KR3sUZHW8FD07zJT+2TOWdXY2Z8rKZoMjLHWkX9BKNajyENFC7mbNi2tM T08NxTeTC7+q5V5S1mwgLGDNY0aw3twwbJYDp8cP+V4/ygsLctsBtDOsD/OFJLLEla VbCD7U1LKFe6ziaA7WsZu62S3JUVLpLa0mP39Sge4c/os2FoV2EhWcJtJ7t8V6Ho6u 5mSu2S+P/rf4A== Message-ID: <27eb4047-636b-6460-fd48-ae4b606956f0@collabora.com> Date: Fri, 14 Apr 2023 12:37:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2] media: verisilicon: Fix crash when probing encoder Content-Language: en-US To: Benjamin Gaignard , ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org, m.szyprowski@samsung.com Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230413104756.356695-1-benjamin.gaignard@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230413104756.356695-1-benjamin.gaignard@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 13/04/23 12:47, Benjamin Gaignard ha scritto: > ctx->vpu_dst_fmt is no more initialized before calling hantro_try_fmt() > so assigne it to vpu_fmt led to crash the kernel. > Like for decoder case use 'fmt' as format for encoder and clean up > the code. > > Signed-off-by: Benjamin Gaignard > Tested-by: Marek Szyprowski > Fixes: db6f68b51e5c ("media: verisilicon: Do not set context src/dst formats in reset functions") Reviewed-by: AngeloGioacchino Del Regno