From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE44C64E8A for ; Wed, 2 Dec 2020 17:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9469A217A0 for ; Wed, 2 Dec 2020 17:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387629AbgLBRRS (ORCPT ); Wed, 2 Dec 2020 12:17:18 -0500 Received: from smtprelay0019.hostedemail.com ([216.40.44.19]:40802 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727641AbgLBRRS (ORCPT ); Wed, 2 Dec 2020 12:17:18 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 5E9C318029136; Wed, 2 Dec 2020 17:16:37 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: gate97_4517256273b4 X-Filterd-Recvd-Size: 2256 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf20.hostedemail.com (Postfix) with ESMTPA; Wed, 2 Dec 2020 17:16:36 +0000 (UTC) Message-ID: <280235acc0e91365f3fd3b5be5a5244eced1ff61.camel@perches.com> Subject: Re: [PATCH] checkpatch: add fix for non-standard signature - co-authored-by From: Joe Perches To: Aditya Srivastava Cc: lukas.bulwahn@gmail.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Date: Wed, 02 Dec 2020 09:16:35 -0800 In-Reply-To: <20201202090828.12934-1-yashsri421@gmail.com> References: <20201202090828.12934-1-yashsri421@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-12-02 at 14:38 +0530, Aditya Srivastava wrote: > Currently, checkpatch.pl warns for BAD_SIGN_OFF on the usage of > non-standard signatures. > > An evaluation on v4.13..v5.8 showed that out of 539 warnings due to > non-standard signatures, 43 are due to the use of 'Co-authored-by' > tag, which may seem correct, but is not standard. > > The standard signature equivalent for 'Co-authored-by' is > 'Co-developed-by'. > > Provide a fix by suggesting users with this signature alternative and > replacing. This doesn't apply to either today's linux or -next. It is dependent on a patch that is only in Andrew Morton's mmots. Your patch subject should show that in the brackets. Something like: [PATCH -mmots] checkpatch: etc... Adding --fix options to the obvious spelling typos in these signature by-lines tags are a different case but I think this is a relatively low value patch as I don't believe these tags should be limited in this way. Maybe Andrew likes it. > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -2832,6 +2832,9 @@ sub process { >   > >   if ($sign_off !~ /$signature_tags/) { >   my $suggested_signature = find_standard_signature($sign_off); > + if ($sign_off =~ /co-authored-by:/i) { > + $suggested_signature = "Co-developed-by:"; > + }