From: Thomas Backlund <tmb@mageia.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Ulf Magnusson <ulfalizer@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: building in 32bit chroot on x86_64 host broken
Date: Tue, 5 Jun 2018 22:35:43 +0259 [thread overview]
Message-ID: <28026f53-714a-b76d-00da-562c7612e265@mageia.org> (raw)
In-Reply-To: <CA+55aFwiyuA4fKztofM-fdDSc+ZH9aAR1xksL8ZWRDE-pdXruw@mail.gmail.com>
Den 2018-06-05 kl. 22:13, skrev Linus Torvalds:
> On Tue, Jun 5, 2018 at 11:50 AM Thomas Backlund <tmb@mageia.org> wrote:
>>> but why do you care?
>> Because without it running the build in the 32bit chroot will get the
>> initial reported issue:
> Ahh. I can re-create that now.
>
> Yes, doing
>
> make ARCH=i386 allnoconfig
>
> followed by
>
> make oldconfig
>
> is broken. And doing a trivial "git bisect run" to pinpoint where
> CONFIG_64BIT goes away gives us
>
> f467c5640c29ad258c3cd8186a776c82fc3b8057 is the first bad commit
>
> which does that
>
> "kconfig: only write '# CONFIG_FOO is not set' for visible symbols"
>
> and it turns out that CONFIG_64BIT is not a visible symbol on x86-32,
> because that question is disabled when ARCH != "x86".
>
> bool "64-bit kernel" if ARCH = "x86"
>
> And the problem with that, is that *next* time around this config file
> is used, because we don't have that
>
> # CONFIG_64BIT is not set
>
> line, we don't turn it into
>
> CONFIG_64BIT=n
>
> and then the "depends on" in X86_64
>
> config X86_64
> def_bool y
> depends on 64BIT
>
> no longer hides it.
>
> Hmm. Ulf, Masahiro, comments?
>
> Should we just revert that commit?
>
> Thomas, can you verify that a
>
> git revert f467c5640c29ad258c3cd8186a776c82fc3b8057
>
> fixes the problem for you?
>
> Linus
Yep, that fixes it so it works both in the 32bit chroot and on the
64bit host
--
Thomas
next prev parent reply other threads:[~2018-06-05 19:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-03 21:58 Linux 4.17 Linus Torvalds
2018-06-05 17:53 ` building in 32bit chroot on x86_64 host broken (was: Linux 4.17) Thomas Backlund
2018-06-05 18:11 ` Linus Torvalds
2018-06-05 18:24 ` building in 32bit chroot on x86_64 host broken Thomas Backlund
2018-06-05 18:38 ` Linus Torvalds
2018-06-05 18:51 ` Thomas Backlund
2018-06-05 19:13 ` Linus Torvalds
2018-06-05 19:36 ` Thomas Backlund [this message]
2018-06-06 1:37 ` Masahiro Yamada
2018-06-06 1:54 ` Linus Torvalds
2018-06-06 2:19 ` Linus Torvalds
2018-06-06 3:31 ` Masahiro Yamada
2018-06-07 19:36 ` Thomas Backlund
2018-06-07 19:40 ` Linus Torvalds
2018-06-07 19:49 ` Thomas Backlund
2018-06-09 12:16 ` Masahiro Yamada
2018-06-08 9:12 ` Michal Kubecek
2018-06-09 12:23 ` Masahiro Yamada
2018-06-09 16:49 ` Theodore Y. Ts'o
2018-06-05 18:12 ` building in 32bit chroot on x86_64 host broken - IGNORE Thomas Backlund
2018-06-05 20:10 ` python errors in tools/testing/selftests/tc-testing (was: Linux 4.17) Thomas Backlund
2018-06-05 21:01 ` python errors in tools/testing/selftests/tc-testing - IGNORE Thomas Backlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28026f53-714a-b76d-00da-562c7612e265@mageia.org \
--to=tmb@mageia.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®