From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 958B22DA75B for ; Wed, 26 Nov 2025 09:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764149639; cv=none; b=Re3CJdQZMATDRGGFPi59jLFl3aPHPg5wBjWn5StoiVZIWGiku0y84Scw00X/muPldYrvgQKJoLT81U5Q6/mNRFQ9v/WCRt37koTIMEBzAdKs17tbwXuSOEcXL21xoIZ6Y80NGEVnxIxgy/RNEcb2tvx7kQRW2/0/xtJAMShxbV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764149639; c=relaxed/simple; bh=OS1szglYqZNQbgAbx2ew3p6qm09QfSur6l2e5D+8GAA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=tn7vlFZaQWks2G2qCVDC08uCDEkIzck4rXq/lNY5NCw+2ikPMTQebPqcb0rQaohCmj4Y2jV9mgzhJ6lES3XehqWRoEMZpXdwR2QxUYnWFsddnPCeNKSdU9cPwrkwbHNMRXSbRZXjakhZGZ4lvvFeXeD6X2pc9okxevYmjO9UJFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SwEqkG4Y; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=h5JEBtLb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SwEqkG4Y"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="h5JEBtLb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764149636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NCmLktXxJEqVth4IzXw4WRzHYYGXxF/eFRIihcIhd7s=; b=SwEqkG4YB7OpAPhWj5wTxJqJmR23+Qu312JT9NAHui8dbvw8limbFWG7e486JF4znFcHD2 tLuYddIdn8k7hHuLyOkEHL4LkKdciuIip817A33rYLqvmbml8XiCOZuXuGuIzhj6LWkOwD Lb92ySyVPd37hVREDRmt7LcEL1wlelI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-p6JESXoLPQiR6Lnj4TkyCg-1; Wed, 26 Nov 2025 04:33:54 -0500 X-MC-Unique: p6JESXoLPQiR6Lnj4TkyCg-1 X-Mimecast-MFC-AGG-ID: p6JESXoLPQiR6Lnj4TkyCg_1764149634 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779edba8f3so48507865e9.3 for ; Wed, 26 Nov 2025 01:33:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764149634; x=1764754434; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=NCmLktXxJEqVth4IzXw4WRzHYYGXxF/eFRIihcIhd7s=; b=h5JEBtLb3xaxjbMI23axJPzM605SgnZmloQpyDxWsDRG5Xht4VJ6GPq6g5KqdbSuz8 5nsWGXkfJo3gk6zzjs5ZyBXsdV0drSwOPHBIjvh66Z7FEsc3cSCs3hQibqaqafyfrc4t I529IgyxI66q19l/kE2t1tyIj3dJ+w4JSb3chImB6jfpbvErzAmBHD51Gacpf3dWPQtt aj1CtErHJrOH/UgWy8HO5lpChTGTHygTQsry2ylL6khyG1D9Vg3bInemWgywhI5m9lfD CztssXJeIsnYoAv90jrZJrw61atGkbIE3ii00hh3DtwNQFe49u77u8JuDvM7A7cv3smN fayA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764149634; x=1764754434; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NCmLktXxJEqVth4IzXw4WRzHYYGXxF/eFRIihcIhd7s=; b=fGWZL56q383aq3JY4xFFUJoS1s9EeKCnetbgKPgZAHPKVmffFHez2wzzY3swNw5Mzt GwPuOeXJxUXU8Vh3v7Zkx+lMImhQB4cQKijmgFrZS2W5ixWzxaFbO7zvy/C/qOzJglXs YDtUY5bD09ElHa+WSiMIfwxE+kM2ums3DvSEWpBoKXzmS4AYyDdiJwoGX627++Bl/jM/ qexRgSw8H1rpWka6wc6ORqqZKybPbo75p8cgDiiCSRwzrieNbjZFe7KAAh02/GPRBU22 loychD5k+H+49BR3BG9ozVFKMK2iaI63Qu3DFx3d5OQo6KYNiKrGAfjWnoiAFvJOnvzo Zy6A== X-Forwarded-Encrypted: i=1; AJvYcCU/P5SQ1bWa8HM5hZoQ7tv4f0Tw35eeYSpzzSE7kMZCPUfdSTr3KuTaGjcxX/uwjN9qqOKYjz7JPeSHCC8=@vger.kernel.org X-Gm-Message-State: AOJu0YyoDrZRuAsmAcnmi7HIJtDB5+X1nbLv45ZiYQfVJYtZB6Ib0TD1 OUy6+E/ouRKDMVmeEJ8saNhllrZ1018QkV2gV2JtxInfDpNDYlo5Rm406L0kuZwS2RXZx3PIPJ5 pTguhEnhD5WU3vkYWrvRslzRFeyXIMnW5dx/TnwI0hybMFpjYTwqZXQTeTFsN4zzxWuT+rnZ0tI wZ X-Gm-Gg: ASbGncsbR4y9JfQIDWWS3vta157veZeBlTDS3kDO3ZmSaUXBRvPYb37XiaVnsg4vmcG mSOlYqbFvOx2317wyB7BJD+w7rmhpGfv1gEEQp14cD5TsJnbpC2RC5zqFiVNiW/ibWqZ1x+NrSB oCHBcoAByT/toxxmJQtll8WowPRJRiYWu7OqXt8wAnbXaH1PZPAI4l69st11Njtch5DgKt5Bgsd Aql9sTYkiq7rBPCNmAX8iPhAL2Cgs8cdG2rmv3dSxv7WnTDtLAagsrMRs74ZkEsRWfK3ETwfG26 0cSFKAa5zajrxfYP6s1fjEaoh1IY8WpUiUO5LPBQ3eWaDQ85Oloc1eHXVwQrt7HwwKdLXND6XGB w8EPU3CJ8QUv60Hs323YapCFXtOBuUmtorYU= X-Received: by 2002:a05:600c:3553:b0:477:7a78:3016 with SMTP id 5b1f17b1804b1-477c0170782mr181020715e9.8.1764149633662; Wed, 26 Nov 2025 01:33:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTQkcjS1iYZ6d5htepGxVQeLZD2ukrzB85WZqTi1/b6nJWhdURU1dfjzkAAQHs9U7l9KaAjA== X-Received: by 2002:a05:600c:3553:b0:477:7a78:3016 with SMTP id 5b1f17b1804b1-477c0170782mr181020435e9.8.1764149633215; Wed, 26 Nov 2025 01:33:53 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb ([185.107.56.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790adf5387sm32028765e9.12.2025.11.26.01.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 01:33:52 -0800 (PST) Message-ID: <2803da35e4de12ef2ca966a69052bf228f1cd10f.camel@redhat.com> Subject: Re: [PATCH v2 1/2] rv: Convert to use lock guard From: Gabriele Monaco To: Nam Cao , Steven Rostedt Cc: Masami Hiramatsu , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 26 Nov 2025 10:33:51 +0100 In-Reply-To: <878qft5gxk.fsf@yellow.woof> References: <20251125145736.48c3ed9d@gandalf.local.home> <878qft5gxk.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.1 (3.58.1-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-11-26 at 09:36 +0100, Nam Cao wrote: > On Tue, 2025-11-25 at 14:57 -0500, Steven Rostedt wrote: > > On Mon, 17 Nov 2025 09:06:02 +0000 > > Nam Cao wrote: > >=20 > > > @@ -644,13 +640,11 @@ static ssize_t enabled_monitors_write(struct fi= le > > > *filp, const char __user *user > > > =C2=A0 else > > > =C2=A0 retval =3D rv_disable_monitor(mon); > > > =C2=A0 > > > - if (!retval) > > > - retval =3D count; > > > - > > > - break; > > > + if (retval) > > > + return retval; > > > + return count; > >=20 > > No biggy, but I wonder if this would look better as: > >=20 > > return retval ? : count; >=20 > Unless you really prefer it this way, I would rather not. The first time > I saw this syntax, it confused the hell out of me. Took me some time > scratching my head until I figured out that it is a GNU extension. >=20 > I prefer to stay with the C standard unless there is major benefit not > to. To be fair, I find it a bit obscure as well, although it's frequently used within the kernel. Let's not change it then. Thanks, Gabriele