From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A52EB30C62B for ; Sun, 16 Nov 2025 16:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763310043; cv=none; b=G31L6VSWIOBJK8TpcJNUDFgPvOX+F9ECsK4PqKL4lQgPsNb9DqFnhbUkYzgUsAlibzW53pCJt9+uWxBlVlwqQnUzx93iQY7GeUYHV81bknN6aXBI0DhEVAsG1PFRmtR4wkwNHABBwAhQ3b6HhYSb+9dJ0NdJhrXvtGmQXFVmY8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763310043; c=relaxed/simple; bh=IcWG0c7Ap4vHQVKjcGsS3wLPIyj8+cOECPrxfy8qqX8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dJZOX5rrz29N4pVWJNp+aAZ2KcjRhvjyGHnd5dgI4CQNT4jmrUORFlVN8nTSTe0c4Mlm5OguiIzX2NBCn/ylk8XY8GRNwQQ9jeTA76RlkpN22aaftPkafTJUV6KdsRonutKhnQFvJn8TmfDPmXUAdMVg4aTMAW8X1O03VYwVbuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aknmoqcs; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aknmoqcs" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b735e278fa1so489639866b.0 for ; Sun, 16 Nov 2025 08:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763310039; x=1763914839; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IcWG0c7Ap4vHQVKjcGsS3wLPIyj8+cOECPrxfy8qqX8=; b=aknmoqcsJdOe5Kp9laS8fEBxGyp/YzrI9hVWDh+RQ0fJnC32dYSnW20Ed4aUm3EeCH ZJB7+FIt2yYtyNoPQ64z4+VpNe3U9wP0Jyfw6xEVKUjPtIv/6xknlpdZG3P7ZAK9f9mu cFheUJRrUeJh/86ZI0eGZfXL/wuDRJxEJ6KhMDgMAZo0m5VbqqzIhqJ8Y0hXndkNxqdV IG/ir4YRJwZYQzXmz1eDooCV6gAMmw9Q3ZMUKme0ToU8rHjcO2Z/BbmUywkN+Ficesk7 UXnQxPdD9sAl5OpCGibBNdCNj5Lde0PBTv1EIOHzmHMqgkHJvPocDg9tjI7FVjfJ3xGH NMxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763310039; x=1763914839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IcWG0c7Ap4vHQVKjcGsS3wLPIyj8+cOECPrxfy8qqX8=; b=DiGR70JL9rGqWCT4vXc1LV41UzWuIS7gFG/onaO8mLlWdanRdkQdDDdFAEAzsS/+kd eAktAUv9jAtmQJr4g2hr3jrAwSEL6sEQgINkR+sElI/N6Dh3ZKvgzbYPbBiwx0gGk0gr fcgRYG4wsYl+X3d8KhpUbnKW+db/whsMIFP3deOa/4ich5oMDOaDLjeLgKoCyiIf9FXD iYh0eaetLyE+xMEoYWJnvZ/dk609eh9Drk+pAx1VfNVB5QxolT5axFdeLkyHnRYZC17U hpTwj525cWHxC46jASs5L4EuqZgtWplzK0Wu2nS2Nw715Pqqz5f/Q1EQZxzRG1srojXn DlAw== X-Forwarded-Encrypted: i=1; AJvYcCUksu6HfFW/EVn/aWX7dvZagmN4HaVz+M0RmGcK5HPwT1osNBknOxscok7Silm+lWc7m0gj/V5K7IBQcqk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz94adBsxfK87aMoKt7d/1VyJjosCYm5N/scs2mCp+ju+3AJ1rJ ztwj6WcyQiPDIROVXk+cGV6TU23e6sdn4biWiznk2P5vnb9k1MEYlVYs X-Gm-Gg: ASbGncvpBFzr0Ux1vyEZnidq1jPrvaazi2R2fHh/9en1gc2d/X7lj6+P0fPwo+lwo7M XSGn9YxoJkCbJKs8j93oROX/gmwc3gwToaUEj2qLAt8Vs2yspVdBAH4AFpPhyx9rSnYAm3+c8m8 X9KkFVy8Z26znDRNZC3xi6cgmkYqk8yF3Q5SCf3bMwOJnrHkhShRcNaZ3JS7wuILsPJ9vZtFpiO 1y/gukoo+ZlFA4ZxxE1QTRzeb1dwC3S6M3N5VdsQNtIMs1tSAyakGkW06Ql5umKvsCe7zk6/5nZ PKYgWyEHwIqN+O0o6P02rLS9y+bHG9ibHpS++K4d0/Q4qxbNvk+uPHd6kQtWPM3Es7q4PYw3pUm MJq2TfnkL6yboFQzNVM9C3F5F2LoJWpuuUfaUprOoF4MpbMN5/c3DhcdieO5GhaPrv1Nb8V42XL CHWmRz9GLSPDFhXreCVYg8WEhJE3/uAeO5JKMfPS65RFJ6eZ3HLBWq7SLbLCrDO2NQVvvD83pzv FE95Q== X-Google-Smtp-Source: AGHT+IGimZSxkgoIOpfCKAWCHgTmcdkmEWm6/VMebPbmR8mxODGAMWNDh5ErsjYw3DRmDL/5wQcxSw== X-Received: by 2002:a17:907:1c81:b0:b71:2145:dfc8 with SMTP id a640c23a62f3a-b7367962422mr1083057166b.39.1763310038731; Sun, 16 Nov 2025 08:20:38 -0800 (PST) Received: from jernej-laptop.localnet (178-79-73-218.dynamic.telemach.net. [178.79.73.218]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fdae69fsm852257866b.51.2025.11.16.08.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 08:20:38 -0800 (PST) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Vincent Mailhol , Chen-Yu Tsai , Samuel Holland , Gerhard Bertelsmann , Maxime Ripard , Marc Kleine-Budde Cc: kernel@pengutronix.de, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thomas =?UTF-8?B?TcO8aGxiYWNoZXI=?= , Marc Kleine-Budde Subject: Re: [PATCH can] can: sun4i_can: sun4i_can_interrupt(): fix max irq loop handling Date: Sun, 16 Nov 2025 17:20:37 +0100 Message-ID: <2804881.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20251116-sun4i-fix-loop-v1-1-3d76d3f81950@pengutronix.de> References: <20251116-sun4i-fix-loop-v1-1-3d76d3f81950@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne nedelja, 16. november 2025 ob 16:55:26 Srednjeevropski standardni =C4= =8Das je Marc Kleine-Budde napisal(a): > Reading the interrupt register `SUN4I_REG_INT_ADDR` causes all of its bits > to be reset. If we ever reach the condition of handling more than > `SUN4I_CAN_MAX_IRQ` IRQs, we will have read the register and reset all its > bits but without actually handling the interrupt inside of the loop body. >=20 > This may, among other issues, cause us to never `netif_wake_queue()` again > after a transmission interrupt. >=20 > Fixes: 0738eff14d81 ("can: Allwinner A10/A20 CAN Controller support - Ker= nel module") > Cc: stable@vger.kernel.org > Co-developed-by: Thomas M=C3=BChlbacher > Signed-off-by: Thomas M=C3=BChlbacher > Signed-off-by: Marc Kleine-Budde > --- > I've ported the fix from the sja1000 driver to the sun4i_can, which based > on the sja1000 driver. Acked-by: Jernej Skrabec Best regards, Jernej