From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301Ab1AECe0 (ORCPT ); Tue, 4 Jan 2011 21:34:26 -0500 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:25439 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064Ab1AECeZ (ORCPT ); Tue, 4 Jan 2011 21:34:25 -0500 Message-ID: <280596192AA74D208C2C5F6389DBE8C1@hacdom.okisemi.com> From: "Tomoya MORINAGA" To: "Grant Likely" Cc: "David Brownell" , , , , , , , "Toshiharu Okada" References: <1293449027-3219-1-git-send-email-tomoya-linux@dsn.okisemi.com> <20101229064937.GC8172@angua.secretlab.ca> Subject: Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213 Date: Wed, 5 Jan 2011 11:34:20 +0900 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="ISO-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Hosting-Pf: 0 X-NAI-Spam-Score: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Grant, On Wednesday, December 29, 2010 3:49 PM, Grant Likely wrote: > As previously discussed on this list, I would like to see support for > multiple bus instances implemented differently. Rather than storing > the spi_master instances in an array in the pci device private data, > the pci device should register a separate platform_device for each spi > bus instance, and each of those bus instances should get bound to a > topcliff_spi_bus driver which doesn't need to have any special > knowledge about how many spi_master instances actually exist. > > Basically, the way it is implemented in this patch isn't taking > advantage of the infrastructure and instance management provided by > the driver model. I see. I will modify like your suggestion. Could you show the reference SPI driver using multi-instance ? Thanks, --- Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD.