From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51A691F9F70 for ; Thu, 29 Jan 2026 14:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769696308; cv=none; b=DyjU/2+GTHDHk9TO95BrXs447l6guRbcnNgXgj1sL8YV9DOxvz6FcAVPgw+FcDZqcLOB/NCgamUscugXO6w1NJOJZeEDUTAyvxMY3wOOhoqQsJWAJeCK/ZUkMTh/+CcbHq2yya5G9LHPFivWKaMD/vM2UFBdUGu/AlAHXVWSuwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769696308; c=relaxed/simple; bh=EDers8fN2HljLl1KM73ByzR5GscUSEeRnainkZYB2nw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RwrcYaTym6+8V9GkX4hDwAx9M9n8ZImjT30L7EjXITmklFcBIE1+yMxDYPEdYW2bWaFXgqRx2Sbw0mnbkgmtDUJqGd56NOUDiI6xTdqc0Ef75fBeAP9n1zgtPxTKbUX1Bn0W0v9SqZCBf/Cutrad6b2rnmzmic6yh68oN1fnPHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dBKYhtMa; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dBKYhtMa" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c636487ccaeso396637a12.1 for ; Thu, 29 Jan 2026 06:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769696306; x=1770301106; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=Ri7RrmqyAkFYNWJdmG59gMaCqhBOcnxpGMzCXKtgG+Q=; b=dBKYhtMaCahl3pQve4grrg+KQrcnHlDqo72AkZrxMDZRR/05uVySEqPJn3MzWK11Rg 1QZ3Dpbi6vRcZq4LimTI3dG38lMl4/SBSr9JNtNO0WwDN1Tj6kbC7w+CurlJNCw1XjzR 8xsfjWSTMtj/LrQHoD3Mhsfl1pwXzGW94m3xcaWIU4gLLiBx8ulMPQLbjFilM/wfaKDT DecSz6b6ioH9a5CloWvKrviu4U8Y9og4w0quTbzMi3SebLw/m58ExqjXsqM3rM1wtD07 3RgIRWFLx9XdPktzYOdewVSuGsRRyiQQlRrgRmDlIvYtvGykHffGo2L6EZPzzKHkVBaa ir5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769696306; x=1770301106; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ri7RrmqyAkFYNWJdmG59gMaCqhBOcnxpGMzCXKtgG+Q=; b=eumRB8unR8NP2XvqMJmh+OPB39Xyrf0CswjTxbaU9HWqZJhT3P2QILsoKIsqww3DrV Pb6A4P3UwbZfTygJlw0GE2D5rJSJ0N+6tYxj4aujqsvd3gXNm3rGTVmjcZnyf4Airo1u iXijRT5sZvkKj44hLAy0Bfg88CRkh8D/VlRn/TgtS8aqRxowZbZHzMD80MxrvjDn9DUc hyBSTfobak2f1Yywrf9IEaYf0S2VsPpKlcfctZc79Kw4pg+xatPc0WJMg3dTuqowLUO5 LMR7ShaRrHysIR4Lt3exwrZq6rRALszFLLDfFO3LhpC0axHknsEYfl7Rrc/IXtqAeTok X6BQ== X-Forwarded-Encrypted: i=1; AJvYcCVJIRXsDhuH8xfsZh6sSv3RiGhDvV19ZRj0GnFdNbtWoGJpY42cEDw+usE2hQpj4X2xQ/xmbr0k83Q2OqE=@vger.kernel.org X-Gm-Message-State: AOJu0YxFO1LIOQNuwz9Pse9vGv755PDNKmLoCRBI9VaVZ5HkI9Sl6TF2 nR0dWOhRb5CjJr99F3L0AKiR/Wy7273gCZMjQiaSMqInUYZhtmY+5hf9ioNEJYJV X-Gm-Gg: AZuq6aKjAWuw2uHVVKE0IdiZJXQjt9pIdyxiVc3SaSkLtp1i0KEtapfflZmZRLZ5Rlx sG9xKrw9Z7b2Oycm87T6vDC8bhbRLTKzJWQiLpgpHSE/2+qD7FlSSAj290Fa99wP7XeodysPWyY s+jxFdt9lyeLX0hE7SBW+Cop1UmZmrz2pnDthMdWh/EeNAH/Pqu3tI2JnDGOD8rboyYeFWkMnh0 Gmab3Sx4MzZKGDCI42W79ohHIabNjBlY7m8VsppXxsRGTaoBFdKo0UL0v+kPuntSBLxiRR67oQ0 Ncq36mC66Tzb8HGoWggCnNT69u4Ac/l+R66qhUv7ftJcMDcYj80cquty9KhnAm6f/nNLjjSOVTx 46Ykjo7epDk+ejXXkmEPlpuOqdoCSeqP/YdU8S2gc524NG7D6wTCms2vnm5QHawN3iyH5w937Om W/hyixQwr01mLzUxWAPCmi6S1yVnhC7mX+Axg= X-Received: by 2002:a17:90b:5208:b0:341:c964:126c with SMTP id 98e67ed59e1d1-353fedae2a1mr7222180a91.34.1769696306252; Thu, 29 Jan 2026 06:18:26 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3542dd54fa8sm246980a91.3.2026.01.29.06.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 06:18:25 -0800 (PST) Sender: Guenter Roeck Date: Thu, 29 Jan 2026 06:18:24 -0800 From: Guenter Roeck To: Chen Ni Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: (pwm-fan) Add missing check for device_property_read_u32_array Message-ID: <2806020e-725a-4da4-8922-e6d28854b53d@roeck-us.net> References: <20260128072610.2476625-1-nichen@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128072610.2476625-1-nichen@iscas.ac.cn> On Wed, Jan 28, 2026 at 03:26:10PM +0800, Chen Ni wrote: > Add check for the return value of device_property_read_u32_array() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni > --- > drivers/hwmon/pwm-fan.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c > index 37269db2de84..3535007f5c37 100644 > --- a/drivers/hwmon/pwm-fan.c > +++ b/drivers/hwmon/pwm-fan.c > @@ -609,8 +609,11 @@ static int pwm_fan_probe(struct platform_device *pdev) > for (i = 0; i < ctx->tach_count; i++) > ctx->pulses_per_revolution[i] = 2; > > - device_property_read_u32_array(dev, "pulses-per-revolution", > - ctx->pulses_per_revolution, ctx->tach_count); > + ret = device_property_read_u32_array(dev, "pulses-per-revolution", > + ctx->pulses_per_revolution, ctx->tach_count); > + if (ret) > + return dev_err_probe(dev, ret, > + "Failed to read pulses-per-revolution\n"); NACK This would defeat the purpose of setting the default a couple of lines above. Guenter > } > > channels = devm_kcalloc(dev, channel_count + 1, > -- > 2.25.1 > >