From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758446AbcINSdC (ORCPT ); Wed, 14 Sep 2016 14:33:02 -0400 Received: from mail-db5eur01on0098.outbound.protection.outlook.com ([104.47.2.98]:62054 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752151AbcINScz (ORCPT ); Wed, 14 Sep 2016 14:32:55 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dsafonov@virtuozzo.com; Subject: Re: [PATCHv5 0/6] x86: 32-bit compatible C/R on x86_64 To: , References: <20160905133308.28234-1-dsafonov@virtuozzo.com> CC: <0x7f454c46@gmail.com>, , From: Dmitry Safonov Message-ID: <28071a1b-5f2e-be74-0408-8ec0e26957db@virtuozzo.com> Date: Wed, 14 Sep 2016 18:56:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160905133308.28234-1-dsafonov@virtuozzo.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: DB6PR0501CA0012.eurprd05.prod.outlook.com (10.172.232.150) To DB6PR0801MB1736.eurprd08.prod.outlook.com (10.169.227.7) X-MS-Office365-Filtering-Correlation-Id: 25d3f4d9-d681-45d5-f72d-08d3dcb7efec X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1736;2:eRLEjmmsUTACJ7+6Gju2AccxCsmWARDELjksy0Ml68/fs4290jPKmyHM7FKjWvHR1D/u9aXrPnOuHTLFaOoCwVXZ9DmrXUZIYwrVlgF/p14oyK3XrnFthBXf/QFAQ3ZrV3DCh+0Dh5LaPGjeRanjxpIkc0kYY47fdEhA+9sbsNcILRlhAy7VJuvQHVGRi9T7;3:ExCvkpOy28DfucEPJT5LmnzV2bzI2M6oLnS/wsZKliAs3NkJ2gNC6DMH0KhbiL3ydc/a/6JYEDcp5REF+WycSIIomCj4PM4kCNNCKh6rLBdT523Fi+Yun/XrIS5YJHpX X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1736; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1736;25:ELID3m3W2zIb4wV1jNwR8z9o7FrYDg1RhY8GsdmU7AMf8my7zhID2LZt+m2xcTtarQqpelhiGHMJ9HrKW+rsjEWoYBaE+GWgNXvVy/rdAp0xfz7hyI1K13RHK8PLQuUwpWgIhYQlCdv7YjcdBySUDS4o6pQ+sYqabUD3MCMCn9RpDGW3kgilcEGeCgEpV8YOz/eY/Bwy73nCkZJm+68xvsu7NCDor41q6eWSENNwzXqZdhVhQ5Nbx3iQexnlav5nNSGWMYmBOmHmYu3NGTK2/IX+hwvOlLsN9N/Rs/mc52X6n4fX7ho1CPhxHijHBetRKJjwKOeuv4/QP8t9LaJFuSkW6WgDwC+J6dAAjG/5CrVbY50B4n2/QQe+kKhsMSJFQBRx41ZAyoHKKWywaWTccnHzAkqgUpaDW1pLhe+V9tK1Wpn/3kJ0N0DXtm2kZphVhNo2sAbHNOo4RhgJgeNTtms3RDwAV8qdc0sE1tAmQ5ms+to9DRRyUBGC2vb0UK0RruGfEO8Qrtp/7cEyipqtIm93EyGcmS5g1ibPlj2Ih48cN7Lb/bidGWaft78c89xmdGUYdRc9wZ8bENq3YSg1XGy3atWbBJRsin2T8KzC2sN+dWfYmzYo3P1HhNq00x6D6HodctXfH0u7JmkrKh9ohEW67jhzi03CT4REbFesHGZal6zT0YemXjaTkOZP1DU8;31:rVwTcKZvpcAQ/s0XaBYCchGZlEdmiJBGcJqVr6E2BroEGUrJPMXRrGF9YITaLPWRjEeEi0pKE1841sK7uOQQ3pGEbzSsiniJB+C8XXvfGnsRrneI3zgw7/sNRJm0uDteQ3vhfzJ37irVB6SFvewAvdNr0DYleyVEdmvk+GTHIdiu2k5TyKv6a0iCl7c7+Mup7KMOfpYjn+wYaaePMIzx4Qb/8mJ1RR/nee0j9JaX/80= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6043046)(6042046);SRVR:DB6PR0801MB1736;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1736; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1736;4:EJpbL6mTUNFXhalayPlwNTS+QXzRN2fGd0n75KVQGgmbJ6TBSiBmZm1HnmRubEuGAA2p7IHo6Va1rWlYBJviigYA8XrH8n7nFaltbGleZXTmSv3PwUIK5SKjudgfrxtvmIXKZQx1Qn3BsaubRadtF+X0ZQ2GbSa3EY8f0VCPHFMI0SjA3QgpbWFIJ5/et7fUx+J7MslskwGxS+2Jebup4dgndG5dag9GSgftkdlnfVM9P7wSIYXGEqb0mcWWiPH434PXXGYmuAV3kqf0wqGptrhCcRe/9RhMfl4+LG/t/XD39ofHTytiMRMr4yi36rIL5ZqU/OCdzHafL3hGCRxBvGpSA3WYutP6tYVaF0FtJ45UAEW24LFV3FBl4Ho1PkRJ+GuXSCWPUtXzncbDRDumg82xb/SbKsLRZATaP1ztNjM= X-Forefront-PRVS: 006546F32A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(199003)(377454003)(24454002)(106356001)(81166006)(77096005)(230700001)(3846002)(4326007)(305945005)(68736007)(97736004)(105586002)(4001350100001)(8676002)(81156014)(6116002)(5001770100001)(50466002)(33646002)(76176999)(54356999)(31686004)(2906002)(586003)(50986999)(23746002)(92566002)(83506001)(36756003)(47776003)(2950100001)(65956001)(65806001)(189998001)(42186005)(66066001)(86362001)(31696002)(7846002)(64126003)(101416001)(7736002)(65826007)(5660300001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0801MB1736;H:[10.30.26.154];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0801MB1736;23:ra7cHH3xp3p6tYenbkYMFF6SwmdQEouNNyz?= =?Windows-1252?Q?289L9l/gmzizVm/FSPmHpq45wIxHCb2YgC8KyNdZc3MWr1mQvSbiQskI?= =?Windows-1252?Q?GzH42dbO/4KUdzif1z4yaSf7zRkzMVVfJJ/jo3nAXnhrf+Hlr4zLalby?= =?Windows-1252?Q?7Zsq/P7oLsJvBXXvi8iPDuuj5vtN5yp/sTV5qBGrCw2pA4vejZHvC4Lx?= =?Windows-1252?Q?dQ6iGPsgTrM9CD58j1aTQFd2/uoMDUfeCIMITXHITmAgxoHre5Qhoocv?= =?Windows-1252?Q?QIVA9r7Q8FwDb6PZZpDphGz1Kb8TVwdDora+9cI0fg0WwRWmjtDn0n0L?= =?Windows-1252?Q?sf1R3N1rtXwWAzE0akFx0Z1wORzVTaUtI9jLEORDJ3XyyKtTPtpnlmPv?= =?Windows-1252?Q?3LgH2DAz95kdf2ywQYMWtK3ACkpA2TEZrSO5l+82ur95sBoshgvt8XtF?= =?Windows-1252?Q?5/U9MVbK083ourS+5cdyA98xp8l5/rRPotCA4uEqCMAWlKDHzhNGqkIb?= =?Windows-1252?Q?dNS8xg1+ZJdwVjSrO51c4us0G/zS5KdC0EmxDEyJK01U8+dlmyazElTQ?= =?Windows-1252?Q?HhgxhdpsLKm8kgMIrSrUXiUhuauFhVsHFHD8gH9RbNUzBurLt+2/y9Lz?= =?Windows-1252?Q?MQQS7mPubb/DbL8gZ4tR//SF5lkzL2RMFORtLpxm8UXOXgv8CGsN/ngU?= =?Windows-1252?Q?iDLorQgerToRoBmb2XDJXUwTQavvuub+XM8a+7WKBRmhKtxmWlOjfCyI?= =?Windows-1252?Q?NfTHroYUttNnweNZGWDdSkqFMimlTF3hEbYqiVAy4uTg+IXLJMb8Lxoy?= =?Windows-1252?Q?wwuz3ciegmQt0V8Jel5qgHd4h/4OzdejyNEKmqaN69ekHEcN94BK+iwh?= =?Windows-1252?Q?fuiB7ZHbDKBXdf3zMP3rO39euANjgDFcXxjmNOLBy9pHINUxaTuOLRch?= =?Windows-1252?Q?GB6dVr8kSnfHKAaZdt5MmD/TKsk0a+XiQD8EJYcv8p/4DM/wEP48WL54?= =?Windows-1252?Q?4SS1ZwEjTKShPOQ7BU5i/+LYBXMvbBQSffkSlrd7ICw/gGsLDZB3MOXy?= =?Windows-1252?Q?7Sn8bAKBx8+oFwt0yGdZwCjCTaKHX6h8GzzuCmTyv0MR/dq5rqSWBwEe?= =?Windows-1252?Q?7ixEwI+ejTcX/9yfBUu/gN/UmK/8RS3fcIH6gY67tI/h79sYpRgm6WXp?= =?Windows-1252?Q?nDJFG9VGuQh99FEO/UEclfhg9asQgX817Vo7c7EvBVmw+P6630eyk6Sk?= =?Windows-1252?Q?FLv2+0VbWlmfWIwGifqMNmLFX1cfnv51fROwErcaNjjvFjbk45ZSdg5K?= =?Windows-1252?Q?Rwv9dM52+boRyMgGt2a6mmTwdAvf5PJVDy2EtkB2qZ8nFBx8=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1736;6:Cc3nIObQSN1ndo8Q5BILZ9QlsRxRqcZBVlio7ZRc0VnSZQQiAuECwXyPNLoh7aavGdwvv7TMHItiOsE1v36F9a1sqEDXoExsTYyn2+nz+FfSRvv40R73L9nsXmpNC88CT5SFe9xdGBxRpfN4b+BnGP6LjzrFcjUeKOfCoMexWRjgkfIGNcs3GZjWDc7WxWyONpJ1tDFUt85vuJJs+bO3BzDYDbBSS3MXCFLxJEtuzuEx9dF1tg3SRBbaud8+0Q+UyLn4V1lcMBhHrq2gTN1B+W0FHmOgaGjEWTpLubRLIphXZvFn/DU1lSDNU8gbpF+L;5:r8+eC+LljjE168hPVA1UT46y2kIWZ9UNvST9RcV3AJO2Ng2jybikf+OBpmdL6Yn1vLSZC9jrZHQv771G4GBPsXs/V4WLUf/gsQ1TGERt0QEk0qEDeC18h6ffEplIzesuUkNacNs0ZR1EHAJDHH4tNg==;24:Y3XUUQj/IgprA2P9KlmrlBCha3+bu8ilBUG4leT+YIWL+0duL+CMhDNQj7U6ggtj4cMR/spaRXxPiSt3ibaeZXRsbXve2P302P11lTi9Eao=;7:3J96Qm8B0ns1giplWegg5VkoqDLsJVwfnsPg3/c51bsWyrYqntY1Go9vf6D0sm4reY3vxm6A0yfrGWhpJnEAD6lBwrwyUIdGFU5t+UHmMc4jihVzefd1/CF2l0Xf1zhf4bX49VHQaBTAbKZ8+bFiuYheKUr8/bO4KKl5aKylnPUvkBYg0DgPrp21Cvy/zo1ARHgYhXCbifAq+vuKY8mZYgCmqYCwDzjBBYhnvsTiPgSguD/K/OqlgRrk1fLFTkNs SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1736;20:IGdox1syhL1A20SqTTGST6IdjNMXGEVQ7mvSUbKAYkNAi98lpkOaRQ9BY2UWWZwUlZuCc0+VovoU7/8vAJd9+Y1bMFRL1kBByIg6FB6wi8Zz9QJrKlStmfh9T3REHD0Sq2mL2Vuqbk6N1sQhTHK2SZ5oavZR8LLDbyGNC0R56mE= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2016 15:58:14.6647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1736 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/2016 04:33 PM, Dmitry Safonov wrote: > Changes from v4: > - check both vm_ops and vm_private_data to avoid (unlikely) confusion > with some other vma in map_vdso_once (as Andy noticed) - which would > lead to unable to use this API in that unlikely-case > (vm_private_data may be uninitialized and be the same as vvar_mapping > or vdso_mapping pointer) - so I introduced one-liner helper > vma_is_special_mapping(). > > Changes from v3: > - proper ifdefs around vdso_image_32 > - missed Reviewed-by tag Ping? It looks like, all acks are there and there are no objections. -- Dmitry