mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Weiny, Ira" <ira.weiny@intel.com>
To: Arnd Bergmann <arnd@arndb.de>, infinipath <infinipath@intel.com>,
	"Doug Ledford" <dledford@redhat.com>,
	"Hefty, Sean" <sean.hefty@intel.com>,
	"Hal Rosenstock" <hal.rosenstock@gmail.com>
Cc: "Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
	Leon Romanovsky <leon@kernel.org>,
	"Chegondi, Harish" <harish.chegondi@intel.com>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"John, Jubin" <jubin.john@intel.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] IB/qib: fix false-postive maybe-uninitialized warning
Date: Mon, 27 Feb 2017 21:22:45 +0000	[thread overview]
Message-ID: <2807E5FD2F6FDA4886F6618EAC48510E67C59B29@CRSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <20170227204343.3575126-1-arnd@arndb.de>

> 
> aarch64-linux-gcc-7 complains about code it doesn't fully understand:
> 
> drivers/infiniband/hw/qib/qib_iba7322.c: In function
> 'qib_7322_txchk_change':
> include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> 
> The code is right, and despite trying hard, I could not come up with a version
> that I liked better than just adding a fake initialization here to shut up the
> warning.
> 
> Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand
> adapters")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Sounds reasonable to me.

Acked-by: Ira Weiny <ira.weiny@intel.com>

>  drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c
> b/drivers/infiniband/hw/qib/qib_iba7322.c
> index 12c4208fd701..af9f596bb68b 100644
> --- a/drivers/infiniband/hw/qib/qib_iba7322.c
> +++ b/drivers/infiniband/hw/qib/qib_iba7322.c
> @@ -7068,7 +7068,7 @@ static void qib_7322_txchk_change(struct
> qib_devdata *dd, u32 start,
>  	unsigned long flags;
> 
>  	while (wait) {
> -		unsigned long shadow;
> +		unsigned long shadow = 0;
>  		int cstart, previ = -1;
> 
>  		/*
> --
> 2.9.0

      reply	other threads:[~2017-02-27 21:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 20:43 Arnd Bergmann
2017-02-27 21:22 ` Weiny, Ira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2807E5FD2F6FDA4886F6618EAC48510E67C59B29@CRSMSX101.amr.corp.intel.com \
    --to=ira.weiny@intel.com \
    --cc=arnd@arndb.de \
    --cc=dennis.dalessandro@intel.com \
    --cc=dledford@redhat.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=harish.chegondi@intel.com \
    --cc=infinipath@intel.com \
    --cc=jubin.john@intel.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®