From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757575AbdJMLhs (ORCPT ); Fri, 13 Oct 2017 07:37:48 -0400 Received: from alexa-out.qualcomm.com ([129.46.98.28]:44971 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbdJMLhq (ORCPT ); Fri, 13 Oct 2017 07:37:46 -0400 X-IronPort-AV: E=Sophos;i="5.43,370,1503385200"; d="scan'208";a="6287094" X-IronPort-AV: E=McAfee;i="5900,7806,8682"; a="1460905564" X-MGA-submission: =?us-ascii?q?MDFIBD1Yi5x/NFnhohWKRPCMuqzMWwuDhIIAkO?= =?us-ascii?q?68ZCvaxxWv7d33+exMo53kW4GPT15L1NBWxjr3mz+YzXqQYdo+gXTDIv?= =?us-ascii?q?uYNCvR5kTu6EatZjtJS2b0ojNhrvxMdpt0FMw9WU5zpXigBKPKx1c7JX?= =?us-ascii?q?Vy?= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: ath10k: fix core PCI suspend when WoWLAN is supported but disabled From: Kalle Valo In-Reply-To: <20170919232416.108247-1-briannorris@chromium.org> References: <20170919232416.108247-1-briannorris@chromium.org> To: Brian Norris CC: , , "Grant Grundler" , , "Brian Norris" , Ryan Hsu , Michal Kazior User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-ID: <2809b2cf512d4c198d3cef3f5e468c3c@euamsexm01e.eu.qualcomm.com> Date: Fri, 13 Oct 2017 13:37:37 +0200 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01G.na.qualcomm.com (10.85.0.33) To euamsexm01e.eu.qualcomm.com (10.251.127.42) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brian Norris wrote: > For devices where the FW supports WoWLAN but user-space has not > configured it, we don't do any PCI-specific suspend/resume operations, > because mac80211 doesn't call drv_suspend() when !wowlan. This has > particularly bad effects for some platforms, because we don't stop the > power-save timer, and if this timer goes off after the PCI controller > has suspended the link, Bad Things will happen. > > Commit 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > got some of this right, in that it understood there was a problem on > non-WoWLAN firmware. But it forgot the $subject case. > > Fix this by moving all the PCI driver suspend/resume logic exclusively > into the driver PM hooks. This shouldn't affect WoWLAN support much > (this just gets executed later on). > > I would just as well kill the entirety of ath10k_hif_suspend(), as it's > not even implemented on the USB or SDIO drivers. I expect that we don't > need the callback, except to return "supported" (i.e., 0) or "not > supported" (i.e., -EOPNOTSUPP). > > Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > Fixes: 77258d409ce4 ("ath10k: enable pci soc powersaving") > Signed-off-by: Brian Norris > Cc: Ryan Hsu > Cc: Kalle Valo > Cc: Michal Kazior > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 96378bd2c6cd ath10k: fix core PCI suspend when WoWLAN is supported but disabled -- https://patchwork.kernel.org/patch/9960481/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches