From: Lizhi Hou <lizhi.hou@amd.com>
To: Taimuraz Kaitmazov <taimuraz@kaitmazov.com>,
Min Ma <mamin506@gmail.com>, Oded Gabbay <ogabbay@kernel.org>
Cc: "Christian König" <christian.koenig@amd.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Alex Deucher" <alexdeucher@gmail.com>,
"Max Zhen" <max.zhen@amd.com>,
"Sonal Santan" <sonal.santan@amd.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v5 3/5] accel/amdxdna: do not warn when a sync request is rejected
Date: Thu, 17 Sep 2026 13:24:50 -0700 [thread overview]
Message-ID: <280ce606-90f4-ed96-449a-5fe2fa08de68@amd.com> (raw)
In-Reply-To: <99a26a5a-a42a-f0b1-eaca-041629a7c103@amd.com>
Applied to drm-misc-next
On 9/17/26 08:55, Lizhi Hou wrote:
>
> On 8/19/26 15:44, Taimuraz Kaitmazov wrote:
>> amdxdna_drm_sync_bo_ioctl() answers a failed amdxdna_flush_bo() with
>> drm_WARN(). Both of that function's error returns are decided by the
>> ioctl's arguments, so SYNC_BO with an offset past the end of the BO
>> splats and taints the kernel from an unprivileged caller.
>>
>> Log it at debug level, since the same caller can repeat it.
>>
>> Signed-off-by: Taimuraz Kaitmazov <taimuraz@kaitmazov.com>
>> ---
>> drivers/accel/amdxdna/amdxdna_gem.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/amdxdna_gem.c
>> b/drivers/accel/amdxdna/amdxdna_gem.c
>> index 77a9493cd7ba..0e0f844526ca 100644
>> --- a/drivers/accel/amdxdna/amdxdna_gem.c
>> +++ b/drivers/accel/amdxdna/amdxdna_gem.c
>> @@ -1310,7 +1310,7 @@ int amdxdna_drm_sync_bo_ioctl(struct drm_device
>> *dev,
>> amdxdna_gem_unpin(abo);
>> if (ret) {
>> - drm_WARN(&xdna->ddev, 1, "Can not get flush memory");
>> + XDNA_DBG(xdna, "Flush BO %d failed, ret %d",
>> args->handle, ret);
> Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>
>> goto put_obj;
>> }
>> }
next prev parent reply other threads:[~2026-09-17 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260819224458.257346-1-taimuraz@kaitmazov.com>
[not found] ` <20260819224458.257346-5-taimuraz@kaitmazov.com>
2026-09-02 15:39 ` [PATCH v5 4/5] accel/amdxdna: refuse to flush an imported BO Lizhi Hou
[not found] ` <20260819224458.257346-4-taimuraz@kaitmazov.com>
2026-09-17 15:55 ` [PATCH v5 3/5] accel/amdxdna: do not warn when a sync request is rejected Lizhi Hou
2026-09-17 20:24 ` Lizhi Hou [this message]
[not found] ` <20260819224458.257346-6-taimuraz@kaitmazov.com>
2026-09-17 16:11 ` [PATCH v5 5/5] accel/amdxdna: do not fail a sync for a BO with no debug context Lizhi Hou
2026-09-17 20:25 ` Lizhi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=280ce606-90f4-ed96-449a-5fe2fa08de68@amd.com \
--to=lizhi.hou@amd.com \
--cc=alexdeucher@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mamin506@gmail.com \
--cc=max.zhen@amd.com \
--cc=ogabbay@kernel.org \
--cc=sonal.santan@amd.com \
--cc=sumit.semwal@linaro.org \
--cc=taimuraz@kaitmazov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®