From: Xi Ruoyao <xry111@xry111.site>
To: Yulong Han <wheatfox17@icloud.com>, chenhuacai@kernel.org
Cc: kernel@xen0n.name, broonie@kernel.org, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: Add numa_add_reserved_memblk() support in numa
Date: Sun, 01 Jun 2025 19:07:41 +0800 [thread overview]
Message-ID: <280ed3f89c2ca4c97059ef642a092cbcf7cda869.camel@xry111.site> (raw)
In-Reply-To: <20250601102924.2417248-1-wheatfox17@icloud.com>
On Sun, 2025-06-01 at 18:29 +0800, Yulong Han wrote:
> This patch fixes the error below when compiling kernel with
> loongarch's loongson3_defconfig:
>
> drivers/acpi/numa/srat.c: In function ‘acpi_parse_cfmws’:
> drivers/acpi/numa/srat.c:467:13: error: implicit declaration of function
> ‘numa_add_reserved_memblk’ [-Werror=implicit-function-declaration]
> 467 | if (numa_add_reserved_memblk(node, start, end) < 0) {
>
> The error is caused by the missing the newly added
> numa_add_reserved_memblk (under include/linux/numa_memblks.h) definition
> inside loongarch's numa related code.
>
> The commit's code(style) was formatted by ./scripts/checkpatch.pl
> Signed-off-by: Yulong Han <wheatfox17@icloud.com>
Note that numa_add_reserved_memblk would be declared by
linux/numa_memblks.h if CONFIG_NUMA_MEMBLKS, and CONFIG_NUMA_MEMBLKS
would be select after
https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next&id=a24f2fb70cb62180486ad4d74f809ff35ddd1cf9
which would be merged into Torvalds' tree soon. You change fails to
notice this and it's just covering up the issue.
Thus
Nacked-by: Xi Ruoyao <xry111@xry111.site>
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
prev parent reply other threads:[~2025-06-01 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-01 10:29 Yulong Han
2025-06-01 11:07 ` Xi Ruoyao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=280ed3f89c2ca4c97059ef642a092cbcf7cda869.camel@xry111.site \
--to=xry111@xry111.site \
--cc=broonie@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=wheatfox17@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®