From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966362AbcKLO0z (ORCPT ); Sat, 12 Nov 2016 09:26:55 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:35237 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965799AbcKLO0x (ORCPT ); Sat, 12 Nov 2016 09:26:53 -0500 Subject: Re: [PATCH 2/2] staging: iio: ad7606: move out of staging To: Lars-Peter Clausen , Eva Rachel Retuya , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <1478846078-22207-1-git-send-email-eraretuya@gmail.com> <1478846078-22207-3-git-send-email-eraretuya@gmail.com> <266c2aad-1938-1dc7-0b22-b2f3b2d80e68@metafoo.de> Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org From: Jonathan Cameron Message-ID: <280ee49f-7217-6dfc-dcc0-a6c8800144cd@kernel.org> Date: Sat, 12 Nov 2016 14:26:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <266c2aad-1938-1dc7-0b22-b2f3b2d80e68@metafoo.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/16 14:22, Lars-Peter Clausen wrote: > On 11/11/2016 07:34 AM, Eva Rachel Retuya wrote: >> Move the ad7606 driver from staging/iio/adc to iio/adc. Also, update the >> corresponding Makefile and Kconfig associated with the change. > > This is obviously OK, but when you generate a patch that moves files use > `git format-patch -M ...`. This will generate a more compact patch. > I tend to make an exception for staging graduation patches. The mere posting of the whole driver by not using the move detection makes for really easy review of whether we have forgotten something else that needs cleanup before the graduation. Most of the time -M is much more sensible! Jonathan