From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mark Salyzyn <salyzyn@android.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
John Stultz <john.stultz@linaro.org>, Peter Anvin <hpa@zytor.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Prarit Bhargava <prarit@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>, Pavel Machek <pavel@ucw.cz>,
Kevin Easton <kevin@guarana.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SergeySenozhatsky <sergey.senozhatsky@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/urgent] Revert: Unify CLOCK_MONOTONIC and CLOCK_BOOTTIME
Date: Wed, 25 Apr 2018 23:28:27 +0200 [thread overview]
Message-ID: <2814513.Yf7f2L7MUC@aspire.rjw.lan> (raw)
In-Reply-To: <alpine.DEB.2.21.1804252108280.1589@nanos.tec.linutronix.de>
On Wednesday, April 25, 2018 9:09:29 PM CEST Thomas Gleixner wrote:
> On Wed, 25 Apr 2018, Linus Torvalds wrote:
> > On Wed, Apr 25, 2018 at 6:45 AM, tip-bot for Thomas Gleixner
> > <tipbot@zytor.com> wrote:
> > >
> > > As stated in the pull request for the unification of CLOCK_MONOTONIC and
> > > CLOCK_BOOTTIME, it was clear that we might have to revert the change.
> >
> > I'm ok with the revert., but I do want the revert message to talk
> > about *exactly* what broke.
> >
> > I don't see the reported watchdog things, and I run systemd and I ran
> > these patches.
>
> With suspend/resume?
>
> > So it's not just "systemd uses this for a watchdog". It must be
> > something specific that made it trigger for some people and not
> > others, and it's that specific thing that we should document so that
> > we know why this simplification failed.
>
> Fair enough. Do the reporters have more information or do I have to chase
> it down myself?
Well, if CLOCK_MONOTONIC did not count when the system was suspended and now
it does that due to the change in question, then this is a significant
difference in behavior likely to confuse things even in principle.
While it may not confuse things on some systems after all, does this really
matter?
Thanks,
Rafael
next prev parent reply other threads:[~2018-04-25 21:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-757d5a9b3052a4eebd029f207f1e1df59bef7b7d@git.kernel.org>
2018-04-25 17:31 ` Linus Torvalds
2018-04-25 19:09 ` Thomas Gleixner
2018-04-25 19:41 ` Linus Torvalds
2018-04-25 20:19 ` Pavel Machek
2018-04-26 6:53 ` Rafael J. Wysocki
2018-04-26 7:19 ` Pavel Machek
2018-04-26 7:26 ` Rafael J. Wysocki
2018-04-25 20:57 ` Rafael J. Wysocki
2018-04-25 22:41 ` Steven Rostedt
2018-04-26 6:48 ` Rafael J. Wysocki
2018-04-25 21:28 ` Rafael J. Wysocki [this message]
2018-04-26 8:00 ` Rafael J. Wysocki
2018-04-26 8:53 ` Thomas Gleixner
2018-04-26 20:38 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2814513.Yf7f2L7MUC@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=kevin@guarana.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=rostedt@goodmis.org \
--cc=salyzyn@android.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®