From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1171258AbdDXOPG convert rfc822-to-8bit (ORCPT ); Mon, 24 Apr 2017 10:15:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51678 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1171241AbdDXOO5 (ORCPT ); Mon, 24 Apr 2017 10:14:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B30E9AB962 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B30E9AB962 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170421182418.GA12755@gmail.com> References: <20170421182418.GA12755@gmail.com> <20170421083037.12746-4-ebiggers3@gmail.com> <20170421083037.12746-1-ebiggers3@gmail.com> <28373.1492785068@warthog.procyon.org.uk> To: Eric Biggers Cc: dhowells@redhat.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , Mimi Zohar , David Safford Subject: Re: [PATCH 3/5] KEYS: encrypted: sanitize all key material MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28150.1493043294.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Mon, 24 Apr 2017 15:14:54 +0100 Message-ID: <28151.1493043294@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 24 Apr 2017 14:14:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Biggers wrote: > It's not actually needed because it's impossible for the compiler to optimize > away the memset(). memzero_explicit() is only needed on stack data. Okay, also reasonable. David