From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2046.outbound.protection.outlook.com [40.107.105.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B23C201245; Fri, 18 Oct 2024 10:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.46 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729248110; cv=fail; b=Ai9GEq1xKKjdi4JqC1u7ETLrIU8FmD/7g+XXlgSCW7ZhaKnpBVuyxi2HhYKZ7NIkFg76bCSsuwJ6GYE4Fo4FaYApAexhN1QK+U4uyHmjd1RkBrfNssngDf5l2MQcBREH3TW9n8P0h9PK3wMAMHy+cqdkXa5AycOO0hC3r/9LQE4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729248110; c=relaxed/simple; bh=ckdnmTkrtEWUEBJfKDn+Hqld/NSjmQXKnI0CzZKKmjc=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=AZdTbhIo72eZqfgXggTZ/rL42PxUL+j8N2mYgU0H69vXKFDE+w7lYjHn1oglGxwd/h4KugUTRecVE6K/UzbSvvhIgBjYkiZ6xu3I5mmVB0clA8TbiRGHeZOhjuAXO39fKDVmq1n2OvkENZuhrIEIW0hPHa0q/HJM1VWvkOr3YVs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia.com; spf=fail smtp.mailfrom=nokia.com; dkim=pass (2048-bit key) header.d=nokia.com header.i=@nokia.com header.b=dUkyAhj6; arc=fail smtp.client-ip=40.107.105.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nokia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nokia.com header.i=@nokia.com header.b="dUkyAhj6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jXIw1Qpr3TpJbO7yhmiS0v/NKadXojTRQjnJzWgj2EiCxGqGQwb+emExZ2RqMkxxIdY5qaD3Bz/xQIrQ6CgXycKxcZemrFuxpm50KpQYM1cLtW6L4cQCYLTjnxXFicgFaEj4+iSpHkphoCJmuTluMF9qdJ1prWcxkxY1am1U9TQ+VAqT3uI7dmBhH0Zk4JsD6V/Jh2noiFgjv7PvukGrlpqNnJ0h4NtSTyQde6FWfwLsPNdeskWGw5t/th1TVJdqILvlGI9y/mcNmmYbd+Vbiq9m5e+iPkDYKqZACzf6EtJP7KxQinZm12oTH6nE0ovX/cYyW+VdKfYWxDb9fuXrNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/2mmIzjACjR9eRtXM8W+ZCTFsCxS3ffjWrDAVr2kJY=; b=ft/gQkBKUPsEUc9hI8PJSlCABrkF3BsNoKS1z48rVSz+RRtgVG/aUA5GmEuBQ1j7lPNSl1wSHZMZ0/TozqR0GvJu9wUEqFR7n5rAmkA5UTHH0tr14MQFzGJgsdGXsfj+KkEi/r6rDtcDDNx59BS4AcVouz80cmVxP6lYYpbT9jadrP6YhQD8DsYghFNLZIgZZm23jRcOhvT6cp2+k/01CxtAeZvz62nfJnR3P/LJb/+jV8hWJ30F7ZHzvyhCmafoneXT4Xx4ilXh7fn+0hMO9l7KGtdJ3fGDh8/TgCw/58qJJsgb7OcLJqVhta5vcCOH8wxXy8Us6eQXAXfBfKxEiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W/2mmIzjACjR9eRtXM8W+ZCTFsCxS3ffjWrDAVr2kJY=; b=dUkyAhj6rZhoB+ms61GcpEW9/cEJyDdH0ZgPjmjh3pMxs5O6JzMf4dQO6ubPihBPOwoKaEYf/0W5k3Ztnf+ydG9EcHVcSrVUHyccgO4rCWmtNJUyf9V3fNqfury6Yf55CgEm9cjdslpLgEKCg05FYOCTl3g86kZI9JtJlDUbzuv/Fz9oh/IeZIp9nnYzC2McxxUx8qGH2lfyRNSV2KpNlmoaBA6Ps1oZPXEIz4QKLO9MvkKPGtFY2FDEShaPe2CegDs219S3lzHl7rXvEnD3TzDix2aCr5odzBYJ6zAD6v+SV65b7rFD85SZqD6fTVvoaUWhC5vqZbQbauUOFOOc2w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com; Received: from PAWPR07MB9688.eurprd07.prod.outlook.com (2603:10a6:102:383::17) by PAWPR07MB9579.eurprd07.prod.outlook.com (2603:10a6:102:368::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Fri, 18 Oct 2024 10:41:45 +0000 Received: from PAWPR07MB9688.eurprd07.prod.outlook.com ([fe80::6b9d:9c50:8fe6:b8c5]) by PAWPR07MB9688.eurprd07.prod.outlook.com ([fe80::6b9d:9c50:8fe6:b8c5%4]) with mapi id 15.20.8069.018; Fri, 18 Oct 2024 10:41:45 +0000 Message-ID: <2815af1a-d7dd-4679-bb16-842925880b10@nokia.com> Date: Fri, 18 Oct 2024 12:41:44 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v6 05/10] ip6mr: Lock RTNL before ip6mr_new_table() call in ip6mr_rules_init() To: Florian Westphal Cc: "David S . Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241017174109.85717-1-stefan.wiehler@nokia.com> <20241017174109.85717-6-stefan.wiehler@nokia.com> <20241017181022.GB25857@breakpoint.cc> Content-Language: en-US From: Stefan Wiehler Organization: Nokia In-Reply-To: <20241017181022.GB25857@breakpoint.cc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::18) To PAWPR07MB9688.eurprd07.prod.outlook.com (2603:10a6:102:383::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAWPR07MB9688:EE_|PAWPR07MB9579:EE_ X-MS-Office365-Filtering-Correlation-Id: 30407f89-7b0b-453e-663a-08dcef617652 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YWNvVWJLZFpHQmtac1VWclV0MjhwMHJ5Z0xnQzBidUpUK00zcUw3QlJQL0Fv?= =?utf-8?B?Y1VsRHFWMDgzTWxJa2R1VWNsMnc5SGVDSkFuOWxuUks3a1ZicSs5cjYvd0li?= =?utf-8?B?Z3piV21LS3FDT0dWcFU0SitQWFgyaFF6ejJsZkNrOFhpcmRZNHJOa1JNcmFy?= =?utf-8?B?TTUxYkxqb2JjOThVK2RiUkp3cmpXcjhLNnlYako5ckQ5VFhEdGtjZ0VTL3Zp?= =?utf-8?B?OCtkRmtsTGtIdGpFdlhNRmFpMU5RZGY2cjVPcGkxaEx3YkdiNHZ6b2lYVG1K?= =?utf-8?B?bEthdHcvN2phMEtUZy9OMXVEaEhpUTNIdzdKckorYWk2L2diZ3F4S0lYaytJ?= =?utf-8?B?RDc1bXhnNklsVHdpYno5NHUxUVhObXhhWUMzZnhiSXgwYXdJNnRJVlVlT3lk?= =?utf-8?B?V1J3USt3SkhGTDJEVkxHc21nMGd5Q1QyNytVczBScGlJcVhNaThQQkZlQ21D?= =?utf-8?B?RWJsMU9tK0Z2MzlzVndnako5bGFvc1FiWEQ1WFVVMnM4QmlrVjRCZmU5SDZn?= =?utf-8?B?b1hTRVJuaWJQQ2Y4TjFteXJaNWxqNWp5NEtsaVRFenhXcHY2NUNTemhqUkFo?= =?utf-8?B?ZzJPdGV2ZTdJTXQyUnRiaVFmaGtsU3BTOFh2RW1vY01WRzB5U0tidXNqVW5C?= =?utf-8?B?L0lkWmYxTVhpRGYvU1FiYmM3LzUxUEg0VTYydENJclZpWWJGOC8xUTVJOUpz?= =?utf-8?B?a1B2T3d4emlWN21KQVhncU9GOTM1ODI5Tlp2RjZXTXhMYm14TEc3MjA1aSty?= =?utf-8?B?UHljTGJUZGxoc2krMDZKQmx5WTN1NitETnJFazVMWnQvZHNxZmxBQnY2eHdU?= =?utf-8?B?TTQzbXBZTGhNbUEvNXhORk01dkxQNE04ZDlTZjR3cHYwU09iT2M3aXJwbUxs?= =?utf-8?B?bVUzbWNMS1lCa3ZzTHFWVVFRb3N3cnc2MnhJZUtiR2tyWWJVaXpxZ2hNRkFn?= =?utf-8?B?Z2J2ajBEWFMzRXhIbVp2RDk4QnA0c2o5SWVsSTh6am5EVDVMNW94eVFXVFBE?= =?utf-8?B?a3JyU29XRTBTKytzMm52cEhRVWJ6NGkzTURSelQyQjJQaTNtb2t6d1l2S2tW?= =?utf-8?B?TDZKNzFBcjZOalFOVW83cUE0enROWm1NTS9PUzA4Zk5uU0QwaGwrM0FCUFk2?= =?utf-8?B?U3RCd0tBdVFjdks4VkhyYktmVWtUdDAvbzlOT295eUkweDFuczUxWDRBMzMy?= =?utf-8?B?bTYvaUlSdU5XMnhYbWsySFZucjFLZElqNXZuYmFibmJGSjdTbjRCWnM3M2M2?= =?utf-8?B?MThJa0RERDNTUFBBWm1NN1BwSTZMTFpaTXZ4elNTeFFyQXZoWnNOeSs2V0ts?= =?utf-8?B?NTlFMDRIRFluRmE3M3ZEM2pKZFRXaFhqSXpXUW9sbUV1Wk9uaXZEVWd3M1pU?= =?utf-8?B?UENHRU43NVRSY25HRzdPb2g0TS9rSnNxYXpkNmJOZXNFM2hjVGJ6YlkvNjg2?= =?utf-8?B?RHBMbTNEVHhxYm5BZDNldUVFM05CVEJyRmJNQTBIT284b242MTZXTkYvN0Jm?= =?utf-8?B?dDhFZFB3ZGNuKzZnK1Y5bGtiVGlYYXRESEE1bmF6UXhOWlJSbW9Odk95OUw4?= =?utf-8?B?ZllKTWYxbjRadVB5M1BvZDlQK3pUcXcxamlsYVcyTVQwVFp2cm1Rd0MzMEVF?= =?utf-8?B?Tmh3K3cyUVIxR0V5MEpzQ3B6dXN1MGdCWEZzSk1WNHVNU0pxTFNFWU5INWVl?= =?utf-8?B?c3QzUm8zQTRSbS9QZEpMVE9YOWk5WW4yUStsajlUQS9wZWFVQnBnOXJnQVl2?= =?utf-8?Q?Fnl7y2TC0mXfMw5lpMFLVoH/S3i0tF1D4ntEiha?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR07MB9688.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WklwQVNWeFAvMVZWTUdkUUozd0pBNWVVOFZCVGoycmNKUlVFblFDRXZ5cFQz?= =?utf-8?B?OTlhLzUrNE9Vd3RPd3Byek9JeUFGMExBRS90UEZ5QWRPVXJQRTR4V2JEQm1p?= =?utf-8?B?Q1Y3UURpZ3l2SnBtUVF6cXJuQkJGbDNoWjdmZVlHaFY3UGQxMTRoQ1JpUHpq?= =?utf-8?B?YkdIbnhScVR4THdxb1ArbjNac0ord0hhM0p2ZEJCdnZBZnpZRmVpRG5STlBV?= =?utf-8?B?dW9mRTQza1lYMUJmb29RT1hQZU9xd0VnTG5wcm43UGd6R2d3dk1sY1ViUHlK?= =?utf-8?B?NW5pVU9keGlKaFovSHZpWlVaVXFOeUs2VWxnbkNrbVdmcUloMDZ2bm9kemFV?= =?utf-8?B?d0RVUjBNSnlFeTVheDdmbUxqTGsxNXc5NmFPUGplUVZKTkFPUy83OW12QXpy?= =?utf-8?B?cjJPdTM1YVFza2Z2UWw3WWF6U3JZRlZ3VXZYaVp4TFlsUXJ5OTA2YkVQeERa?= =?utf-8?B?R0JiWGhFdEV0eFpyKzV3V3Qvb2RwMm1NTlJxZ3BUdGFmWG9jamxicWYva3or?= =?utf-8?B?SnVhYjZXMGpITm5hMUNXYmtnMEZ0Q2U4dFFNb3o0RkhKRDlNTnRWTHJMVTJl?= =?utf-8?B?ME5SZFdvQXhIRkl4bDJXVFVwVmlTSnRESFcwZFIzTUxCMEJsdytWaEM0QXZq?= =?utf-8?B?OWtNaWNPcTNmSFVkcVA0aE9nV0lhS1JGd1l5VDQwa2JyS3JqTlNPaHV6T3M2?= =?utf-8?B?cEt1dmpCL0RodytFUGg1YW5nRjZJVnZETnd5MnJRMEROVlE5RGNBdHhWUExY?= =?utf-8?B?YVpEcGd2WnpzWG9DVWN1SVJhUUJDdmxnR0RaRHVFdng3eGU1QXZsYlFzMW9z?= =?utf-8?B?SzFhVFJKSUpiMFdKMk5CQXlZYnUwRDRheWljTWp0alR0a3E2cDVOZXJhN1Fz?= =?utf-8?B?Y2tKYW9RRmpKL1JYL3NxUSt1WUFCcmpKbVdOVk45NHJuRklSNkZhNHhmdG9X?= =?utf-8?B?M2pZci9JbzRRNkhiN0ppKzFwenEzeEpBUldLVkhSSkQzR3dBVXpHdFRJUmlj?= =?utf-8?B?REtIL0dFVTJaZS84ZjkwU2tnOG92ODY5NE1lZXNTeDBMZXdLN1c4MHQ0RzJ0?= =?utf-8?B?RGJwNnlScXZ3NDZqcmVvaE9YcXpLRDZ4cEtZSFhBZWRrb05UWTQwWW9Pekkz?= =?utf-8?B?cXo2d3NEWWR4VENGblJHNkV1MlNYbnlKZkE0V2VBUEJERXVCaXllQlhTK00v?= =?utf-8?B?RDA4cDY3VDRtcTFJeFpaT2pCbUtBeWh4SGRlbTg1NTVZTEhueVVqRng0Mi8v?= =?utf-8?B?Yy9YdXhSck9NZzJhQ3hrbE1rck9uaTdzb1pyQ1V0b2VHbU1LVTVFU0VJMEVh?= =?utf-8?B?aWlhbGFvNXNHSjZUU0cyTElVUVZRZEowZHVVaVR1VzNDODMrU3hTTXVWSXpq?= =?utf-8?B?WUNRWW9uZFlNaVZqc0MwcStDbm8yQzBHbzRVMnJLVXZ5SGVZNXVHSXo1Rlh5?= =?utf-8?B?NG5DeG9NbUVpdUQ5dmVHTTBPRmdIQkcxcUFPaUxPZEkrc3gwTFU4QUc5Y2Jr?= =?utf-8?B?ZVNOQUVna0RSRTBqZU45aWZuYmhkdlFrb1VUNXc5ZE5PQ0ZOMGdqcjhkcExt?= =?utf-8?B?Z0EreVBvNkdGNmpkWmdiQU8yT29tRkFwRW54TU1WaHFYVU1IRVdpS1poK3Bw?= =?utf-8?B?ZUVpQzIzREk5am9Bcldwa2FUaFRMMWRZZGZOa1pkY1RsdW42bEdWMVdwVWF6?= =?utf-8?B?YnRLaFhhbWQ2c2NOTVdOS1NoSE5pejRoRkJSTzV4bldYNVFBbytmYmdoN2gw?= =?utf-8?B?S1B2bysvN3JPaHdxenNzTHQyOGNQTDVrWFg0L3hrblR0L2krMkRjVXNyQUxN?= =?utf-8?B?UUZTSUZiTWliM0JScTlTb1FjQ3lWYmxtNkVFLzl2UHRqWW50M3p6blh4NWRl?= =?utf-8?B?TTdHRi94VDBvL0s0aEd5SGdzYmNjcDZHaDRKK3dINm5EREhJMDJwK0RhYmNI?= =?utf-8?B?bCtxVDZGcS9Ta3VqSTFPT29PYXBJNHlpOU5jbWl0VStpZ3AvM0h6ZSsrOWdW?= =?utf-8?B?VXJqUFN6UEpSTndDdXBkNDIxY0lwZk9rQnArZWpDM2tST2FGUEFwWVMvQmZl?= =?utf-8?B?TldJcGx6Mk03ZTJNeGpYYm85cUgvNVM3UnBBMUUxa24xZjZpbmJnYjBidmk3?= =?utf-8?B?T0pqdUh0RlRxSmlSTHV2TnZ2OW0vVmxzcGREc216YUlqTmp5SG9iQ3VFNkJw?= =?utf-8?B?djE3bitmTkdIYkNsaTZUaFNmbFlCSlNpQ1A2c2tnNVMrSFE5TXNhdDU5czY4?= =?utf-8?B?Q202M1paN2dWb1hzM0RYQzhjQ3pBPT0=?= X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30407f89-7b0b-453e-663a-08dcef617652 X-MS-Exchange-CrossTenant-AuthSource: PAWPR07MB9688.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 10:41:45.6879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UNspn1B9+kTgaHsotV70Eusy5ZfvB0xYrnFEHB1MZrAWKiGe+SF3Jt3qbjflip2d8RdT0ht5JKZ5qPR/YR8Uh53JIWULWFbgYOiskUD8rDs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR07MB9579 >> + rtnl_lock(); >> mrt = ip6mr_new_table(net, RT6_TABLE_DFLT); >> if (IS_ERR(mrt)) { >> err = PTR_ERR(mrt); >> goto err1; >> } >> + rtnl_unlock(); >> >> err = fib_default_rule_add(ops, 0x7fff, RT6_TABLE_DFLT, 0); >> if (err < 0) >> @@ -254,6 +256,7 @@ static int __net_init ip6mr_rules_init(struct net *net) >> ip6mr_free_table(mrt); >> rtnl_unlock(); >> err1: >> + rtnl_unlock(); > > Looks like a double-unlock? Thanks, will fix in v7.