From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60FBB282F25 for ; Sat, 25 Jul 2026 14:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784989814; cv=none; b=dvyHlh/cuvUD+9gBh6m81fG4jv7Ha9epQzn/9XmuGeVTKVqCJj7C/ay1K4EfFaiS1DzunYYtddnvctJR1W4j94pdfMfFz1tuFUBGvOqVGBom6LRNh8fp3W1UEuMSxgKTI3jREA/6WdUc6v/iJws9LE3425E6sdVAbtinPPOhSXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784989814; c=relaxed/simple; bh=XqjNgk1Rmeu0o6hz9pyvZO4y9YUjvc294Z2F82jh8Gk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BJPM0aAJg8LYB9mOy4RN5b6AjGMX3RIY8hAycFETQPYKIQ6olCmGAvZ/BYxYgvqlaFYtTRnW7ACYsY7+XUUkCVXVQaLLzo0bu+8kAPJYOgfELt180bv46LSKyAx0+1g/GqTahTDt5B4pVTFEnh1avDb6QUnsgiGWzSrU4lLtbc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o3ZDP+jN; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o3ZDP+jN" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-385ea3ce80dso1402638a91.2 for ; Sat, 25 Jul 2026 07:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784989811; x=1785594611; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8h8dg2EfGa6XzFmZvzgFvfu+2U44UCmWssYckoMASx0=; b=o3ZDP+jNIrYGMBhwC7uCfVnCjyd4Ug8XQjyGpjcwLF5tzy1WkrkrDXJv84G4Rimw8G PMoxfu/cykWvVUbLYbNsD+PiFg2CRd8XjsAu/qc/E6PWnIOREkjFWfOK1fq1neah9Hxs UZiJ6JJoNnr1P8fexBKV1Re7N2CVyi4odcBDZiRQmc9XjROhb1MZt2xRT/fSE4JNgSKl by0KLA8wEDEpmAuYEL2ahSgY1SayJWTsFzOk/PXednERdFcqTSHH1e+phfqV/sLeeHMj /ybEdE8F+NUjah5sh2CbpSD8nEeswfSjNDVA8G+pQhWhjhOCqr+xptftynyuqBFygM8T Y0tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784989811; x=1785594611; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=8h8dg2EfGa6XzFmZvzgFvfu+2U44UCmWssYckoMASx0=; b=WGIjOdiZjfUdjkNgmeC6a5iiOmZJ6NPlGn3Dl31ff15IeWHJHVPqdMX+BkO5RX5buL gsjNv5pBUMP/XvjH97WSDuIDdb+ebngYxouOjXWpDZC44zBRckr6h5qpDeo6d3GGV/Qd cpuB2nzFROZ4HmmEldnX9nv3bioBR6QTpcwOIx1ACkb04zDocLTKoBOU4WMMrx2s+PO8 uMlOVMg1LnlYMOIms8OEMyGmWVpDr6/bInXjDNWB5Ya9zH19iUGGRn42HRPbPSGY4eca YMvz+Yvb9jHkfsF69+YORV7u7v58744ky4MkE/v4Dt37MHq/OgizcA/fATmmt51gt+ov LHPA== X-Forwarded-Encrypted: i=1; AHgh+Rp0vvQZDWtjzyznIsglJsRZky7OBMpftaPyDdE1fVBhn2ihS4xfSugWrh4mnuPBsUuhfmBOQr548zDjAiQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3vEj/Hyw7DXjAm9xhmuw6mLUDzt9h3HnDkOHfn9WpytSRpGNN hUgt7W+/BunQivgSb6ZY5vhCLxk/j8Qz4BHRzo3jJUyIFqPXr5t2CBN3 X-Gm-Gg: AR+sD10QLGqgtbSEUn2X8hLcx316RkJiAfOxkhkB8BDLFoNyudybue6soxEdPe70v6l HgK2xCGoHbsA3QRSilVB/CmWOamxW1x1Z5/DAZWu7g0M73VM3FMN6RmbbxBsxKcJvFud+w6fZ6p 56B8mFGFW/0LEh1fkSVbEzbUoKraSb2PmRhQj+TFwh7rKf9SYhTnzKOMLAhN2T1Eu9UMKWln0Yx ZDLpt5QviijXi8oYRv7O4KJFyg20vnTTLbnzIXl3GbsbA205PWARrDxAo50/46gZ7HB2z9lSlkh UoDP2ueBNF+Pjk6sNo93vgf9fICeaN08COxXQ32FTiMuQAok5g1wnEmjAceAAIvnEOgPvgIAN6+ xBvsdYfI+zUUmFDstVQQDcpoidcLSWzCeDgz9aV6L6vIBNDVn3PJWaGC8b2kwhET8E8S6RF556m p2TwsWfujmCt+ZVKTPJXpxGm6io99tJnSPL0wLInT8+1RIcPjN7ng= X-Received: by 2002:a17:90b:3812:b0:381:6c5:3f63 with SMTP id 98e67ed59e1d1-38f293cf2d2mr2672761a91.6.1784989811520; Sat, 25 Jul 2026 07:30:11 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e585ae882sm1557173c88.6.2026.07.25.07.30.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jul 2026 07:30:11 -0700 (PDT) Sender: Guenter Roeck Message-ID: <281bda77-e1ff-48c2-bb27-2706c735e361@roeck-us.net> Date: Sat, 25 Jul 2026 07:30:10 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 9/9] watchdog: w83627hf_wdt: Use dev_* logging instead of pr_* To: Paul Louvel , Wim Van Sebroeck Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni References: <20260725-w83627hf_wdt-improvements-v1-0-4e9a1b4e8297@bootlin.com> <20260725-w83627hf_wdt-improvements-v1-9-4e9a1b4e8297@bootlin.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260725-w83627hf_wdt-improvements-v1-9-4e9a1b4e8297@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/25/26 03:29, Paul Louvel wrote: > The pr_* logging functions do not identify which device generated a > message. Use dev_* logging functions instead. > Since the device name is printed with this family of function, remove > the duplicate name in the initialization message. > > Signed-off-by: Paul Louvel Please combine this patch with the patch introducing the probe function, and, as mentioned, do not use goto() and do not generate a message for memory allocation failures. Thanks, Guenter > --- > drivers/watchdog/w83627hf_wdt.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/watchdog/w83627hf_wdt.c b/drivers/watchdog/w83627hf_wdt.c > index cf1a3fb3a6fd..83c5d8b52b13 100644 > --- a/drivers/watchdog/w83627hf_wdt.c > +++ b/drivers/watchdog/w83627hf_wdt.c > @@ -471,12 +471,13 @@ static int wdt_probe(struct platform_device *pdev) > const struct platform_device_id *id = platform_get_device_id(pdev); > const struct wdt_pdata *pdata = pdev->dev.platform_data; > enum chips chip = id->driver_data; > + struct device *dev = &pdev->dev; > struct watchdog_device *wdd; > struct w83627hf_data *data; > struct resource *res; > int ret; > > - pr_info("WDT driver for %s Super I/O chip initialising\n", id->name); > + dev_info(dev, "WDT driver initialising\n"); > > res = platform_get_resource(pdev, IORESOURCE_IO, 0); > if (!res) { > @@ -533,11 +534,11 @@ static int wdt_probe(struct platform_device *pdev) > > if (data->early_timer_val) { > if (early_disable) { > - pr_warn("Stopping previously enabled watchdog until userland kicks in\n"); > + dev_warn(dev, "Stopping previously enabled watchdog until userland kicks in\n"); > ret = wdt_stop(wdd); > } else { > - pr_info("Watchdog already running. Resetting timeout to %d sec\n", > - wdd->timeout); > + dev_info(dev, "Watchdog already running. Resetting timeout to %d sec\n", > + wdd->timeout); > ret = wdt_start(wdd); > set_bit(WDOG_HW_RUNNING, &wdd->status); > } > @@ -550,13 +551,12 @@ static int wdt_probe(struct platform_device *pdev) > if (ret) > goto fail; > > - pr_info("initialized. timeout=%d sec (nowayout=%d)\n", wdd->timeout, > - nowayout); > + dev_info(dev, "initialized. timeout=%d sec (nowayout=%d)\n", > + wdd->timeout, nowayout); > > return 0; > fail: > - pr_err("failed to initialize watchdog (err=%d)\n", ret); > - return ret; > + return dev_err_probe(dev, ret, "failed to initialize watchdog\n"); > } > > /* >