From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D01E4383C93 for ; Thu, 26 Mar 2026 19:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774552431; cv=none; b=HY2un1BqgVdusGfGxK/Wo0qAJyjMCTxmW5SHnoc30DpwCxvi66zSMhuKQ2gLiDFohv2jNY+ot1AVQzeQW9nQaWof/jOkQPVA0RyuEgNw0cYnHuXViDnWP7gKwzDiNbXnBP2CjhflFQXGuXd7Oh3yqYTuGCzMucCZAYWWx4gzbD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774552431; c=relaxed/simple; bh=ai3IL45eDAREfWMLbapF1EfVDBFtdYRDwQHSvADc7tw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MXgl0s6xaF81dZy9hS/xMyGV6ffjQdacmxXEP7VkTgTjZ/R2RXZmMZJ0jSPrQGUSgDIIATDuDVGHjfNHaPXE+90Ua9XmizeTNuf8cj4FQ5zVXcQt7JIxbHD7Lzn2BsupvR6rL1mBj9m/A2Puw/Dm8HOx6wFOIT0e+CG9IQg1AuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CFHNKyqk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S1s6YMUY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CFHNKyqk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S1s6YMUY" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QF9sAZ790506 for ; Thu, 26 Mar 2026 19:13:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I8pRdQFOK7i3p0sQMgJhiV+GCt2MC+4BNvCTFNypBOI=; b=CFHNKyqkP/dNZD0J g50OFbVBMt06oP5e//g9SbH6Vfo22br8uvtblaB/5B2w0bd9VVekMJVWCv7N77r4 dKUkY0bCdCb0zBLaAMgo8tIv+dCgukMe+Je8px6HWxakvTOEhb4spkJnAxCC/FkE LJG05GorAHChuNiKWzpW+9AwpFVna6WprFnwhLj4sDRfGrxTAb5mzc2vU9R24EJe y1l7ImFgY+aTPdgoyVTtDYxEyU/391qnfF1XLEpBE0dG0zt38r1loX8x3FleQGkB X4N8yvd04sJo2z9wVVMmmV1DrtNg7zWxwO5wpaL2SxnJZ7ECCObJ25Xwk2NAjkex 5hikMg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d53eqhrhn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 19:13:49 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b07bd30b5eso32717415ad.1 for ; Thu, 26 Mar 2026 12:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774552428; x=1775157228; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I8pRdQFOK7i3p0sQMgJhiV+GCt2MC+4BNvCTFNypBOI=; b=S1s6YMUYAUPus92PaeiWoGWhuak4sGlIZiXaFK1gKrtJ+vye53MYP7wOOhiLNINRrz U1izVoOwjKnw8EZcWandvccvXiK9ZdeNIDXuMv+T4j8cDY+gCh0D4cQ8ei8SOmllt7x4 G2msoA+xTMVEAHUfhUBi93BR0oiGI45/zvHv5gIaCoGiuRyyZxuFe/VIwqewWl5bDM54 rL9azzBpK2rmb/WAkoEQwOt0qD5HnOxgVUmmqbnu+6Cpkxif+ANBp2YfwkXMTH474wgC KbMmMjVfzKarQIb/YYOx2Kz7EUIkikbDtFaP8VV4kYAMXZJ7EM96k1aYQtZSOvvXHCoP 3QRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774552428; x=1775157228; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I8pRdQFOK7i3p0sQMgJhiV+GCt2MC+4BNvCTFNypBOI=; b=huud+sBhHcqNlxwxVa+797BduML2GrDxwExB+bWs98wScH7/MTXLGLRGK7u7E7wspB ESJ1Wpc2Fe06iRjQoJStEh7Vc/nvgqnFU1ET678hc5z9YZl1Jii/QJGqxdjeeiHQsXqJ Kaba81anFjw+D+rNnaC7Wy6HjRImkOT+xv3yvXiWJoCEs6UB6TZfzNcDfKla7mHp+dsf QAP0MS9f69P/aVXJoAtfmuF4rZWGpfNcKFJylqEwFl4kebwSB1cExsXOROml5FcEe5B9 EPFj73KC3fYVrwPgE2+pwDpTcRY3655cM6AhIHBArp/cVeJECLz5caojjEIcjJJYDpMo e0RQ== X-Forwarded-Encrypted: i=1; AJvYcCUQfGm5b+NwLlX8Vul2C4ylpheHREEAI6sPFhSEOp7mmTN/F5ZX8BsKeqLWHsBx6GQ8n9El59iNoxjb22U=@vger.kernel.org X-Gm-Message-State: AOJu0YwZvnGrTMeUgFJDpLVODiewosxMDGPvrIuGe2Jtzb1BXi8Z3F9p OedwxyjolPcsU2Gj6tT1WHKfZcgrHE6tQG5/IECXJBvk6bFDvc9ZpqLn7NeA2wLPEdrULrHYQ+a dWl+cAbPQby6xpXOxMxybIl7x0VeEfDZELBXp1x1GM/frd/FJJLkqQtLtidfegXaN1VR3R+uDNl I= X-Gm-Gg: ATEYQzy9/CTkiKs+BYvgSl9PzTY22hqZCKGqD8/qsBzYyKMY5aV440YjCZ87cltiuce 10vnb1q79rT7QNvSKyC52L0fSHCJuKPMILN9Rrwqru+DZcTdpinB0L3wNv+mtksLyOKGJHBK9tV /kwx/+uu4cyc7QTjOYzg5O9BVtKheSDXx29XmIIXQzwLaKNfn7zVtqLE2NKOvLu8xsghEW8Zu8v KFs2rFmauzX4Jm2ed8hM4nGctoO2EBZ3wDX1jKmbvb0yTXTr+jSP2RFWV4hOqQSuBgM1IFthC1F sl1ZMFVQl4tkHFHRY+N9w6wQbFlbecGcUkmuK/8VkFNWCulMWp+rkTCS8SYozNHWRQdUSjrEgtU +MCXjbGfFawK+kV+nZY9nlVeeZAfEFiaeTz7EQiKqEiix X-Received: by 2002:a17:902:e94c:b0:2b0:5a4c:726f with SMTP id d9443c01a7336-2b0c48e9a76mr28339815ad.15.1774552427555; Thu, 26 Mar 2026 12:13:47 -0700 (PDT) X-Received: by 2002:a17:902:e94c:b0:2b0:5a4c:726f with SMTP id d9443c01a7336-2b0c48e9a76mr28339615ad.15.1774552427007; Thu, 26 Mar 2026 12:13:47 -0700 (PDT) Received: from [10.91.121.222] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc8f3b98sm34857235ad.70.2026.03.26.12.13.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 12:13:46 -0700 (PDT) Message-ID: <281e5ea3-ae44-4939-b800-face97ac2d6e@oss.qualcomm.com> Date: Fri, 27 Mar 2026 00:43:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/16] drm/msm/a6xx: Add SKU detection support for X2-85 To: Dmitry Baryshkov Cc: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-12-fc95b8d9c017@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDEzOCBTYWx0ZWRfXxboFcpOqaz8z eNHT9MbqvNbtmMmCGaB6hc760AWJQiqLS7QdUBa99e4t/B++4gp45EZEUTwYseQxbt1fTLAWItg gBVI1ueYC21o21ae76qOxMl+2DRZn7UbUnVdSg+8+U/BxsPrxYu9bnmXotWSPYhtCOLIQiB+dcH uEs3sUkguzALAeTzba5a+VpiDB2eRHsXRz+9/pYnulzHGIOrCQ0wYnjdMkCNI17S8IONns2VARH U7Jzh2G2ULpJH/oA5exFfcR1cI+DKQ5yuFIAd6nyUiMPIMQAGCHnmJJx3xLXdjbiqctmGIDyGNF e3q2Qbe+bCYove5CgEwM9F6nTHPMbCioBTwJvfL0SnYpR0Za2HFQIdfs+/rA4+RlU917r33nhJh xaRwcOYTfLzHSm/tcD+A/lPyBB78DoC5fjWjrOjRPVpEPHpFsRoWDenZmNpnWRU6l02egMgmQ6t 98x4/7639Hqxfy41Mhg== X-Proofpoint-GUID: d2cfvci8BaQnBxGHnh--l6HyO0JPcxpe X-Authority-Analysis: v=2.4 cv=S4bUAYsP c=1 sm=1 tr=0 ts=69c5856d cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=pFeaMtMCVmKtNNfMW7wA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: d2cfvci8BaQnBxGHnh--l6HyO0JPcxpe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_03,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260138 On 3/24/2026 3:04 AM, Dmitry Baryshkov wrote: > On Tue, Mar 24, 2026 at 01:42:24AM +0530, Akhil P Oommen wrote: >> Adreno X2-85 series present in Glymur chipset supports a new mechanism >> for SKU detection. A new CX_MISC register exposes the combined (or >> final) speedbin value from both HW fuse register and the Soft Fuse >> register. >> >> Implement this new SKU detection along with a new quirk to identify the >> GPUs that has SOFT SKU support. Also, enable this quirk for Adreno X2-85 > > SOFT SKU -> Soft fuse? > >> and add its SKU table to the catalog. >> >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 ++++ >> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 +++++- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 41 ++++++++++++++++++++++----- >> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 ---- >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + >> drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 4 +++ >> 6 files changed, 53 insertions(+), 13 deletions(-) >> >> @@ -1213,10 +1212,6 @@ int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev, >> devm_pm_opp_set_clkname(dev, "core"); >> } >> >> - if (adreno_read_speedbin(dev, &speedbin) || !speedbin) >> - speedbin = 0xffff; >> - adreno_gpu->speedbin = (uint16_t) (0xffff & speedbin); >> - > > You have removed this from the generic code and then added it to a5xx > and a6xx+. Wouldn't this cause a change on a2xx - a4xx? In the the devicetree, only a5x and a6x chipsets are users of the speed_bin cells. Also, I believe Mesa handles speedbin=0 correctly for A4x and older chipsets. So we can ignore those. -Akhil. > >> gpu_name = devm_kasprintf(dev, GFP_KERNEL, "%"ADRENO_CHIPID_FMT, >> ADRENO_CHIPID_ARGS(config->chip_id)); >> if (!gpu_name) >