From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A92B92FFDE1 for ; Tue, 27 Jan 2026 15:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527540; cv=none; b=O90xwqUgqKZLuVfQQkR+sDk6DJAsHqhc6uBWeXHk1FaaIrL8DECoatIL+/llkJaG8QkmFlVejRNQCcqDrrhuY18e98rXEs7NHuX+J0Fw5YGwqKOF3aldhGa5Q3p7qvAc3FQXjo71CUluIgZcR8gnsC+Lw5SS7kd9yNVvjCw8k8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527540; c=relaxed/simple; bh=oJsQe++H6Rqjbyx6V9OzRVv3sGku3JKQqo0CW+QedNU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WiGBmTOkhzUCPJPTUYPDveauERIhTVF6MpnxrQzMpD+uZhQRrxl18m0rpcX1nyyHJw3uyJx4qRT6DiIyP/ZX9sVF0ud5kg+FGW3FjrFaclCnPpb1DkFCdggWD9VBqGoQMz6VFZCFdahQMAbOEt/oQoFX8U1SgGLLLf/TY/84o5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=GszS5X1c; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="GszS5X1c" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 60R78aQp019537; Tue, 27 Jan 2026 15:25:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=hc8sBb 7qZ7q1h7xJCJd3MYULXw0/8B1rUcThvKhhf+s=; b=GszS5X1cRLnKUn/homTQBP yFsApetT0DExwYG7rptgt6N0M6dISEVUBbdwja0IRfkmR1TkbLL/w48r5VfWjQoI NfzbN9w+4McHlUW+fiS1ooFC5F+TVM//4+SgvX4lxjibcBoc9KCZFOE8Rwmmgk82 Bpe/juz95Q30W48kymJ7EV8WcUf5SCqjI3VOOIZJ6M9zUOLJjD7ze/lEnUW4M9nN O/6gQBXQ6X2ZwNzyDeERKlybUxEaTJ4hkVCqOroBxrhlwkGxgp2ESMxQOf4+xzXa MPFeJZ2wh2EsJdhT/lmEs829tOb63DKkpR7GItoAGYAopGo97N+H9xCzdjqXp6tg == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4bvnr649qq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:25:34 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 60REgUAE023624; Tue, 27 Jan 2026 15:25:33 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4bwamjryhn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:25:33 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 60RFPWXH63177144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jan 2026 15:25:32 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 566AA58052; Tue, 27 Jan 2026 15:25:32 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF5B958056; Tue, 27 Jan 2026 15:25:31 +0000 (GMT) Received: from [9.61.135.234] (unknown [9.61.135.234]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 27 Jan 2026 15:25:31 +0000 (GMT) Message-ID: <281fd870-cc1a-4ca1-a896-10fcc2f7bc3b@linux.ibm.com> Date: Tue, 27 Jan 2026 09:25:31 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/13] fsi: Assign driver's bus in fsi_driver_register() To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <54804c2cd4d84a6b5fb679831122b6acdd36b168.1765279318.git.u.kleine-koenig@baylibre.com> Content-Language: en-US From: Eddie James In-Reply-To: <54804c2cd4d84a6b5fb679831122b6acdd36b168.1765279318.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEyNSBTYWx0ZWRfXzN2GczMVIlQZ DAFWEUoPJgOdaSHH8rOfGrjobzljxihZMD8drJgKmC8WBO1nmva7i2x69Nce/ej01Ug6jkfHvxK yGVCQX67xy8kEWnaWvLIBm+qpCFOCC9SipOkuGGBMTTBVqk26uhf8YH06H1Us4bDIL8WZXgb4yx QFBTyrf/DSxJJlqCGI/0Q/DOyYAwcDI7T4y88hl8JX8ABvBN7g1fUon3G1VmyGA4vSiLemuOWt7 Y14YGFb4HyNbAbDt9UPs9Dri+G2YnGv/y1DsHVxiZm6/gmzU+3dHjNsZF9vGiPfpnx2H0+gJRxn WdQkgDzr9H43YcJfcTkwv68C1YfuguhZDS/poM9/FAK5RCDTuYuujf2TssOsS5S7cxeRqxjsnyA Gw13UJRVtsaAXNCeCFCup4FfGRwMt7SKVGe1vHDj+OngdS1LjyYCP4yhwH2A/DpxUvxqNjTN7uY QP8oUHEDQryE5Et9FNg== X-Proofpoint-GUID: 2XFuVeCF5uikkQZeYybU5nGEDslb90Cm X-Proofpoint-ORIG-GUID: 2XFuVeCF5uikkQZeYybU5nGEDslb90Cm X-Authority-Analysis: v=2.4 cv=X+Vf6WTe c=1 sm=1 tr=0 ts=6978d8ee cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=IpJZQVW2AAAA:8 a=hbNmydH_IgioPhH3UvAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1011 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2601150000 definitions=main-2601270125 On 12/9/25 5:40 AM, Uwe Kleine-König wrote: > Instead of letting each driver assign the bus, do it once in the fsi > driver register function. > > Simplify the fsi drivers that are living in drivers/fsi accordingly. > > Once all fsi drivers dropped assigning the bus, fsi_bus_type can be made > a static variable. Acked-by: Eddie James > > Signed-off-by: Uwe Kleine-König > --- > drivers/fsi/fsi-core.c | 2 ++ > drivers/fsi/fsi-master-hub.c | 1 - > drivers/fsi/fsi-sbefifo.c | 1 - > drivers/fsi/fsi-scom.c | 1 - > drivers/fsi/i2cr-scom.c | 1 - > 5 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c > index c6c115993ebc..e1ea1124282e 100644 > --- a/drivers/fsi/fsi-core.c > +++ b/drivers/fsi/fsi-core.c > @@ -1394,6 +1394,8 @@ int fsi_driver_register(struct fsi_driver *fsi_drv) > if (!fsi_drv->id_table) > return -EINVAL; > > + fsi_drv->drv.bus = &fsi_bus_type; > + > return driver_register(&fsi_drv->drv); > } > EXPORT_SYMBOL_GPL(fsi_driver_register); > diff --git a/drivers/fsi/fsi-master-hub.c b/drivers/fsi/fsi-master-hub.c > index 6568fed7db3c..d389856d18ac 100644 > --- a/drivers/fsi/fsi-master-hub.c > +++ b/drivers/fsi/fsi-master-hub.c > @@ -288,7 +288,6 @@ static struct fsi_driver hub_master_driver = { > .id_table = hub_master_ids, > .drv = { > .name = "fsi-master-hub", > - .bus = &fsi_bus_type, > .probe = hub_master_probe, > .remove = hub_master_remove, > } > diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c > index 5a08423d0c7e..fde1c34743a0 100644 > --- a/drivers/fsi/fsi-sbefifo.c > +++ b/drivers/fsi/fsi-sbefifo.c > @@ -1133,7 +1133,6 @@ static struct fsi_driver sbefifo_drv = { > .id_table = sbefifo_ids, > .drv = { > .name = DEVICE_NAME, > - .bus = &fsi_bus_type, > .probe = sbefifo_probe, > .remove = sbefifo_remove, > } > diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c > index f533106085ac..2eda44451cc1 100644 > --- a/drivers/fsi/fsi-scom.c > +++ b/drivers/fsi/fsi-scom.c > @@ -606,7 +606,6 @@ static struct fsi_driver scom_drv = { > .id_table = scom_ids, > .drv = { > .name = "scom", > - .bus = &fsi_bus_type, > .of_match_table = scom_of_ids, > .probe = scom_probe, > .remove = scom_remove, > diff --git a/drivers/fsi/i2cr-scom.c b/drivers/fsi/i2cr-scom.c > index cb7e02213032..dfdb16afd205 100644 > --- a/drivers/fsi/i2cr-scom.c > +++ b/drivers/fsi/i2cr-scom.c > @@ -140,7 +140,6 @@ static struct fsi_driver i2cr_scom_driver = { > .id_table = i2cr_scom_ids, > .drv = { > .name = "i2cr_scom", > - .bus = &fsi_bus_type, > .of_match_table = i2cr_scom_of_ids, > .probe = i2cr_scom_probe, > .remove = i2cr_scom_remove,