From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A68042D8DDF for ; Wed, 17 Dec 2025 11:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765971803; cv=none; b=Kfgr/tLvuJln0PEVNXM22vJr7OO7v9dFxR5B6dOHFMPzrvgT9gzFUACw995BozwEFchB1q2Ya+Rc7pvLWANIKF3dQnakBPu4wLUGPc8aqvQ+eiaP7h2VT8O9i4tRM3NRgdxESkCBu8nOiVBPTv7wq5FvyHxg/hD/e61PSejZb8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765971803; c=relaxed/simple; bh=3EnvTxY0/bfuIeNDRDiGlF/1dOg95S8RcBq4z93kXFQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HtHRYsyk0m+DpQgly5YWwJdbzYgoCylVEERnu9AOz3NEdMIssOH9KE4bp4fZ5dR8kxyrSAqUYu9ewB6acTNEZjFdjBQZnq34bHp9MTBgU7/acJNt1+oTiExuYBnaOKfulWie229om+S2M7AJNp3Nlp3LhMvXARBCMFOyW4PqtbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KWjXZXOX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M+pmSA2r; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KWjXZXOX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M+pmSA2r" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHA1ivI1501347 for ; Wed, 17 Dec 2025 11:43:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Uc8r4ogfZe3Nfe8rm/DbzqbRnN7GoD19BnhRvcrJm6s=; b=KWjXZXOX8V/XajIs dv+x3rVmMcP3G/RFoEAbmHBI8QKT9Es6ZSbcA+kSr+II3wFXJYIe+DFj0ubQZNEc q/niq4jd6tmb/mXx6GWfIFdZh5sH/HKv6GVos8q1hykwec7aJRBxTcyxRcRyLtiA UhEC+oUGYNRYXJMaHg/H0Uz5N6Ih8nLmZ59GniY0GSl7sroz4/oLo7cKdaXwmEoF qasCxppR8EaCDL2QLUhmQZyqrSK+746V+4hQbxC0toUTB1RH2BuJ7M/X8fV05ZjW 7rJCA/mv77xlHhH7O0BrSAx4OULV4ZXg8kCVdI/xu0Vy/0HwapmuZ55xpNGT1ULj fcMSJw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3kkesn65-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 11:43:20 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f34c24e2cbso3706281cf.3 for ; Wed, 17 Dec 2025 03:43:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765971800; x=1766576600; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Uc8r4ogfZe3Nfe8rm/DbzqbRnN7GoD19BnhRvcrJm6s=; b=M+pmSA2rRflhVHilb2At9muUc+Odx4mezkfLC1FWMIpT6G3Ywc27NTy+3qGK40lpPb aJ813Do0TJDZuAUl13crWods8fWP1DQClvotSB7eCSMHmxHY8dH7VQ+vJt0DhAJLqt+c aDsIk9YyP9njEulsGkA51tM55wYYjmY2c9iQXPRbJdXSXYgCEbbWr0o1XNe+C+f8GzfC QHU2UQ61Q5km0XeUbOFuc5XVpWs1yF+/VlTfqmWAUD1yHmSA/8U7gmtxFKhfWvVv+lst IpNhzGCyXSK9cX6JStoKIW1dhexDwpko3oFNYgMejtdZbh69zIDmGv/Y5U20Vf0RkUwk HTjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765971800; x=1766576600; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uc8r4ogfZe3Nfe8rm/DbzqbRnN7GoD19BnhRvcrJm6s=; b=GjNpNzD/PcZeiGmqJpwjiuQ8gblWgMMqDjzyhDtm7tVAlvl4l/CHoBabfurp6geSSE QQJnGDaxJpDwjLtCVnMw0eNP001hP8S8ygJyvvCjQrDKpVeZJchrLgktStDZeVIIdChs qtIFE4hjAPji2VqRqBV/GsjHnEnDHnBypzLq0u1ObsN1suk5aW/r84HKEEonT5Ob5v7N L0MSdoDcs7kQzhO28iK8bF55mqY0DTZegjtA9MtZMfO2T5NWIf9GAbSLQvlbORGaVchB b0xgWqtKe8hA1kzuhqM65jtwDEkUKATYRJ47V49EI5ou8NPdZjr9ixcoIf/42sNYCk5b E/iA== X-Forwarded-Encrypted: i=1; AJvYcCWsNq8Jnsw14/ZK6zSqmuqPq9YU/gl/4NZKLy86+z3+fj7lgRGF/yHpMgIqrV3FISH9TDToI2DBakWvNdY=@vger.kernel.org X-Gm-Message-State: AOJu0YwEgx9t67CfCnJ1yyyS0JbyWTQbAcHOfuJXwoygxTD2n1YwysaB xlKLJoaz3MUUswWUW8u2IHSu/D94dv3QtUw0yufjAwb98irYFslGT//n4NEQSqbIqt5vGka5Fjf W1mOZGHufRz9TQfQ3i+GcLE7VRb40F6WlPDGR1WDI9qHxucTX8hlGXnmFVkNLBVLWzS8= X-Gm-Gg: AY/fxX4hl1Uf0IyvdLdk2hqXcZ3TiMAmbpXCkxOSmTqjZQiB8yW5OOsrDZoTDxmIGyg RDFd8gSgnPKJIWZBp4RTU+yyBzq0rxFTWEmhruh7pDnHc4hLukpDCONlCatybdRgFzeYvO4b4ZU mTc8FgC3GfsN5Kj5zAUXa79aMGVa1anbLV3+fUtP3sKtb42NNbUH/eYVrqSpiGcPmVfOZFFuzEp e1SqpWEwLyOw4MQVRm5tGVPZWvVouuX4uFh60vREyxMxYGJtNdmacSLYONI23113w+YnvQDZJq7 9Q1jjHRGOzL33PNRleoDtkPxXnyMn3hewL8TTPp78x/9MtgKi0a9I760xrFGR8rLWK6umJ/yIhx BmOl8TLyB11TLUdAfGWY1zNcal58IxwNdbdxhr1SV6ui60Z3LnbWgjiagTajeilGnwA== X-Received: by 2002:ac8:5e09:0:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4f1d06772cemr182329451cf.9.1765971799795; Wed, 17 Dec 2025 03:43:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPGUpg1VEdJQV0I0ezVEgDQeWCJmbibhBI34HanVShebTFaB9WoF8Il/29YJ8qGQzBrQH8pw== X-Received: by 2002:ac8:5e09:0:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4f1d06772cemr182329231cf.9.1765971799255; Wed, 17 Dec 2025 03:43:19 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7fc04f6015sm1023112366b.50.2025.12.17.03.43.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 03:43:18 -0800 (PST) Message-ID: <28207f1f-31f0-4007-bab5-e073ddf2d262@oss.qualcomm.com> Date: Wed, 17 Dec 2025 12:43:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 00/14] Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2 To: Vikash Garodia , Dmitry Baryshkov Cc: Bjorn Andersson , Mukesh Ojha , Bryan O'Donoghue , Bryan O'Donoghue , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251121-kvm_rproc_v8-v8-0-8e8e9fb0eca0@oss.qualcomm.com> <0156c327-b867-481e-af24-679f037bfa56@linaro.org> <20251121113751.tnqw5abm5sd2rgr7@hu-mojha-hyd.qualcomm.com> <9dfe5343-824d-42c2-aab8-8389602601e9@kernel.org> <20251202083650.luk2jpcquq2pcf2r@hu-mojha-hyd.qualcomm.com> <623225c2-166a-49a1-9856-d02ed55f1e47@oss.qualcomm.com> <64dbe824-a94c-4394-8cbe-ebdb7a3c42fd@oss.qualcomm.com> <55f68c6f-9b7e-4393-9ca2-b94551cd81b8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <55f68c6f-9b7e-4393-9ca2-b94551cd81b8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA5MiBTYWx0ZWRfX9Gw84qisNOIi 02d7kMxtLVjjgLLEtk/GwDsOlLSSwLeq9OS2Cmy2KLAloliykC7iup9UsSqSE/cg25wbC3fF5zt QwXWlq8fSm3xu2yZgAlT7vdHLhF7t85TUYPcLZFypi48b4OhE6/eUzYw16rQ1AwQnoNL26VF2MP /SwJj9mDX3JmFJswQUMsd7goqfBSjxTQcygCWNpEhWWOQf2kJya9V5oRvChVXKmir0ThsxgkTpH GhRDnNbK3ryZQKhjdGIKadQUhcGcsApu2arx3b91cU5qYzvxfdsWwk27LnoUo6g4yJ6DTEdvKBX xZUqOpwziqNNsc/n68dQP/DfpYe7b7ExSzc/sruJ+ucp0PRMcW7pmaJ2O56379iDUmuoI73aenq nAQtzgkQ7uypNQGj3QFvOZtvkQjvYg== X-Proofpoint-GUID: eT5ZdebYqGnmtcgWCGZcapvdlL0oM80M X-Authority-Analysis: v=2.4 cv=Fcw6BZ+6 c=1 sm=1 tr=0 ts=69429758 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=QbrqHIRdYo9yJpEGGWUA:9 a=AxdYRY707WvbTN9U:21 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: eT5ZdebYqGnmtcgWCGZcapvdlL0oM80M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170092 On 12/17/25 11:08 AM, Vikash Garodia wrote: > > On 12/6/2025 2:48 AM, Dmitry Baryshkov wrote: >> On Wed, Dec 03, 2025 at 10:48:14AM +0530, Vikash Garodia wrote: >>> >>> On 12/3/2025 2:54 AM, Bjorn Andersson wrote: >>>> On Tue, Dec 02, 2025 at 03:43:17PM +0530, Vikash Garodia wrote: >>>>> >>>>> On 12/2/2025 2:06 PM, Mukesh Ojha wrote: >>>>>> On Thu, Nov 27, 2025 at 10:25:23AM +0000, Bryan O'Donoghue wrote: >>>>>>> On 21/11/2025 11:37, Mukesh Ojha wrote: >>>>>>>>> Sorry. >>>>>>>>> >>>>>>>>> Did we actually come up with a cogent reason to omit the video firmware >>>>>>>>> loading here ? >>>>>>>>> >>>>>>>>> AFAIU it is required for Lemans and Glymur - leaving it out is blocking >>>>>>>>> getting video stuff done and storing up trouble. >>>>>>>>> >>>>>>>>> What exactly is the blockage - is it something you want help with ? >>>>>>>> I replied to you here[1] and given my reason..till something concluded on >>>>>>>> "multi-cell IOMMU[2]", I can not add video and block what is working >>>>>>>> already. >>>>>>>> >>>>>>>> [1] >>>>>>>> https://lore.kernel.org/lkml/20251105081421.f6j7ks5bd4dfgr67@hu-mojha- >>>>>>>> hyd.qualcomm.com/ >>>>>>> >>>>>>> Why though ? >>>>>>> >>>>>>> You are mixing together the issue of multiple SIDs and the original loading >>>>>>> of firmware which could easily reuse the venus method of >>>>>>> >>>>>>> &iris { >>>>>>>     video-firmware { >>>>>>>         iommus = <&apss_smmu hex>; >>>>>>>     }; >>>>>>> }; >>>>>> >>>>>> I completely understand what you are saying, and it would be very easy >>>>>> for me to do that if it gets accepted. However, I doubt that the people >>>>>> who raised this concern would agree with the approach. >>>>>> >>>>>> I’m not sure if the video team would like to pursue pixel/non-pixel/firmware context >>>>>> banks separately. I’ll leave this to @Vikas to answer. >>>>> >>>>> Not exactly as a separate sub-node, but i do like the idea of introducing a >>>>> simple iommu property, something like this, which Stephan proposed earlier >>>>> in the discussion [1] >>>>> >>>>> firmware-iommus = <&apps_smmu ...>; >>>>> >>>>> I understand that we are doing the iommu-map thing, but a property >>>>> exclusively for firmware like above look much simpler to me. >>>>> >>>> >>>> "We know we need to find a generic solution to this very problem, but >>>> while we work on that let's add this quick hack to the ABI"? >>> >>> I would not call that as hack, rather a simpler solution instead of packing >>> everything into the generic iommu-map. >>> >>> "firmware-iommus" is much more readable to interpret something running in >>> el2 mode, than digging into function ids inside iommu-map and then matching >>> it up with specific SIDs to confirm. >> >> If you want it formally, NAK from my side for firmware-iommus. Either >> reuse an existing approach (at least it makese sense from the historical >> point of view) or introduce a generic approach, which is iommu-maps. The >> proposed firmware-iommus is definitely a hack around the IOMMU >> properties. >> >> But it's really off-topic here. > > Infact i see a concern with the iommu-map approach for firmware SIDs. Let say the hardware generates 10 SIDs, including firmware. So video binding should describe those 10 SIDs and the DTS should have all those 10 SIDs as well, including firmware SID. > Given above, video driver cannot distinguish if the SOC is running in EL2 (KVM) mode or Gunyah mode. EL2 vs Gunyah is not hard (something like is_hyp_mode_available()), but again, this should all be calling some sort of is_gunyah() which would come from the gunyah hyp drivers, which have seen no activity on lkml for over a year.. Konrad