From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E06C5DF60 for ; Tue, 5 Nov 2019 18:14:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BE4621928 for ; Tue, 5 Nov 2019 18:14:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="es3U/VTn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390654AbfKESOs (ORCPT ); Tue, 5 Nov 2019 13:14:48 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:44566 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390520AbfKESOs (ORCPT ); Tue, 5 Nov 2019 13:14:48 -0500 Received: by mail-wr1-f65.google.com with SMTP id f2so13670836wrs.11 for ; Tue, 05 Nov 2019 10:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Mw8czg66zR2+XmJKwa/SXDogHRiTTqLG37/U0FeQDZg=; b=es3U/VTnDu+3ZM21xrCRx4/uVUrsUqwUTRpNRnvLrAbHOVmG+6WQf77+yKNgRhhGMx 2wlKSomvPnoON7hMHNQ/XyukARpjX6NdkzxmVDIz+I3iDEExZGT65Q93GxMksYMPWqnP Aj1BZX+rzUEtq/tgb/h1VhsCsFb+XKeCSV/qc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Mw8czg66zR2+XmJKwa/SXDogHRiTTqLG37/U0FeQDZg=; b=uWk6R+0OWux2KhfqLNFF0bobpR5m26oGs6cMKJg8I3UL2f8zR8rDoZjfQj1oAYI/SI nOS0PaMf2/c4PMtninpFyTM2LCqwHxKHUEl4TOYiLDLLc/PATVozbE/0bJ6VmSolSpT/ jncbAt2EA6zuo6eVx/pMtgMjbY3WkugmscZTfR/4zvaJfZcyCzULb5NtHjhOpOUFKr/y D0o0MqiaUuFclb6neiBNBIjT+Cyd9/AoQkgXchK2bJw3Ayo1UBUuKGkpDJ2Qq8Dt4sXK N3vqqYJGIPEJHMuz0M87SUX9Vnv/86xpfVryu5liKmNQ37y/D6lWNCX7dt/ERaDUaC2w ouVg== X-Gm-Message-State: APjAAAVIto3V6FHA7zyZF+T3kRkczp6OsQsH8dyvYXA/Feeu7uK4EyRa 6Jeht2KPWC7IOK7i+Iu+i8RK/xe5BczSO1//+vvOJXK+74ho3xBUV081i3OIxI+PV8DhE8gbSyq nGxSkFxxIFt3wvP8YezgZ0mv+WqEZIVWrO0mvLlTNodKabxtSs08Nzk7aM12enhFptMgc4eqabk LwCXys2+b2NlY= X-Google-Smtp-Source: APXvYqz3lwEhvIyzPTbk4V3OVt/etmjJyMV0E398p2+KNGQJzZjbszoYvSVEBrTbNZbnkL8toT4L5Q== X-Received: by 2002:adf:da4a:: with SMTP id r10mr30681330wrl.356.1572977685512; Tue, 05 Nov 2019 10:14:45 -0800 (PST) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id b4sm37107131wrh.87.2019.11.05.10.14.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Nov 2019 10:14:44 -0800 (PST) Subject: Re: [PATCH 08/62] gpio: gpio-bcm-kona: Use new GPIO_LINE_DIRECTION To: Matti Vaittinen , mazziesaccount@gmail.com Cc: Ray Jui , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <47840e5f6268d598ed511dcdefcfeb9435109c21.1572945719.git.matti.vaittinen@fi.rohmeurope.com> From: Scott Branden Message-ID: <2820c3aa-0fc0-a18a-7043-00d12d8cf6b4@broadcom.com> Date: Tue, 5 Nov 2019 10:14:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <47840e5f6268d598ed511dcdefcfeb9435109c21.1572945719.git.matti.vaittinen@fi.rohmeurope.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unlike some other opinions I've seen, I like the use of an understandable define. On 2019-11-05 2:13 a.m., Matti Vaittinen wrote: > t's hard for occasional GPIO code reader/writer to know if values 0/1 > equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and > GPIO_LINE_DIRECTION_OUT to help them out. > > Signed-off-by: Matti Vaittinen Acked-by: Scott Branden > --- > drivers/gpio/gpio-bcm-kona.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c > index 9fa6d3a967d2..4122683eb1f9 100644 > --- a/drivers/gpio/gpio-bcm-kona.c > +++ b/drivers/gpio/gpio-bcm-kona.c > @@ -127,7 +127,7 @@ static int bcm_kona_gpio_get_dir(struct gpio_chip *chip, unsigned gpio) > u32 val; > > val = readl(reg_base + GPIO_CONTROL(gpio)) & GPIO_GPCTR0_IOTR_MASK; > - return !!val; > + return val ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT; > } > > static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) > @@ -144,7 +144,7 @@ static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) > raw_spin_lock_irqsave(&kona_gpio->lock, flags); > > /* this function only applies to output pin */ > - if (bcm_kona_gpio_get_dir(chip, gpio) == 1) > + if (bcm_kona_gpio_get_dir(chip, gpio) == GPIO_LINE_DIRECTION_IN) > goto out; > > reg_offset = value ? GPIO_OUT_SET(bank_id) : GPIO_OUT_CLEAR(bank_id); > @@ -170,7 +170,7 @@ static int bcm_kona_gpio_get(struct gpio_chip *chip, unsigned gpio) > reg_base = kona_gpio->reg_base; > raw_spin_lock_irqsave(&kona_gpio->lock, flags); > > - if (bcm_kona_gpio_get_dir(chip, gpio) == 1) > + if (bcm_kona_gpio_get_dir(chip, gpio) == GPIO_LINE_DIRECTION_IN) > reg_offset = GPIO_IN_STATUS(bank_id); > else > reg_offset = GPIO_OUT_STATUS(bank_id);