From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B679EECE561 for ; Thu, 20 Sep 2018 08:53:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BA7120671 for ; Thu, 20 Sep 2018 08:53:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BA7120671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731817AbeITOf7 (ORCPT ); Thu, 20 Sep 2018 10:35:59 -0400 Received: from mail-sh2.amlogic.com ([58.32.228.45]:50642 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbeITOf7 (ORCPT ); Thu, 20 Sep 2018 10:35:59 -0400 Received: from [10.18.19.215] (10.18.19.215) by mail-sh2.amlogic.com (10.18.11.6) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 20 Sep 2018 16:54:11 +0800 Subject: Re: [PATCH v4 2/2] arm64: dts: meson-g12a: add initial g12a s905d2 SoC DT support To: Neil Armstrong , Kevin Hilman , CC: Rob Herring , Jerome Brunet , Carlo Caione , Jian Hu , Yixun Lan , Hanjie Lin , Qiufang Dai , Victor Wan , , , References: <1537427368-11104-1-git-send-email-jianxin.pan@amlogic.com> <1537427368-11104-3-git-send-email-jianxin.pan@amlogic.com> From: Jianxin Pan Message-ID: <282176bb-2780-b8f4-5619-4edb24d37469@amlogic.com> Date: Thu, 20 Sep 2018 16:54:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.19.215] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/2018 3:54 PM, Neil Armstrong wrote: > On 20/09/2018 09:09, Jianxin Pan wrote: >> Try to add basic DT support for the Amlogic's Meson-G12A S905D2 SoC, >> which describe components as follows: Reserve Memory, CPU, GIC, IRQ, >> Timer, UART. It's capable of booting up into the serial console. >> >> Signed-off-by: Jianxin Pan >> Reviewed-by: Jerome Brunet >> --- >> arch/arm64/boot/dts/amlogic/Makefile | 1 + >> arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts | 22 +++ >> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 172 ++++++++++++++++++++++++ [...] >> +#include "meson-g12a.dtsi" >> + >> +/ { >> + compatible = "amlogic,u200", "amlogic,g12a"; >> + model = "Amlogic Meson G12A U200 Development Board"; >> + >> + aliases { >> + serial0 = &uart_AO; >> + }; > > Hi Jianxin, > > Please add the /memory and /chosen nodes. > > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > > Thanks, > Neil > > Hi Neil Thanks for the review! I will add them. >> +}; >> + >> +&uart_AO { >> + status = "okay"; >> +}; >> + > [...] > > . >