From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F4E37BE83 for ; Fri, 27 Mar 2026 11:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774611833; cv=none; b=ggOOhnF/W05jd7ZdkKvExhtDKxBjGS1Vh/kjkLzK9SADSk168p6+BcCdpcH5dMOCkbljIE9yW+QvEEBp2eGi3/ezu7hcpOltCYSKBz27fdCPIhwYPMsfb2DltZsIrKSXR5AnXqQfXS+WOAQ88GFrVliy6YWAKlvoLc9Pbq3k8iI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774611833; c=relaxed/simple; bh=FEc9lT0BW2KeKXQ3ChIovGLpCHr9pq972Nq5Th8ooKA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G+mjqZBfthfCg2YNcSi/Or/HYM47GmxgFIkA0CqmNB/nNcA3Vbsmwj51tvXEDHHlq3wkmsy55EyGoaAQmWVOio59Xw8ibLEOPZChFHyS1/bYhY0SLgdLHLOtgIVxV2lyvsQPGv22xdBdq93nNi/Q59sIn4Z6UNvM4827pcCrfNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BabSZsKn; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BabSZsKn" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-486fd5360d4so25291955e9.1 for ; Fri, 27 Mar 2026 04:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774611830; x=1775216630; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FEc9lT0BW2KeKXQ3ChIovGLpCHr9pq972Nq5Th8ooKA=; b=BabSZsKnOO99HHWQQXFoIzpAxk3giCxlB76Y+7KLcZeZmxpVZgmiW+YW9jCAXCgAiX AE3eDs+oS6YqW3cb/fXeIZPUlCUlxXrTk53O7vi0DzfloC+3IQpRzEDG/VbEq9DVfAtf SzWCrtjghdEXC/fe4cEjIPGvx4IxNX4TECqyKauorHzyxNiydYY83F6PbuSDbF1Pnk7t F/DR3Bilwdey/aBj5hi3h7LKMZ4967TXtn8ZG6+cbdl/ZaC8j8R9CYuvy+/wuBDxKUwm 2ly+4iLa9+ZzKlUkMKkh8/gLYbdzKtJse9e43Dk7+j84OiwRzjFuiMjIujgnCwXYt6oZ EQyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774611830; x=1775216630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FEc9lT0BW2KeKXQ3ChIovGLpCHr9pq972Nq5Th8ooKA=; b=hvQ/zCQBcf3kWJTbpv5PfIi7S4UgXuoPpSScF+7uLUFhJ4f+U4Aw8t+geYajIAk7qx PqCfwg6tpq82IVDJfspqpwCPXPyaPhtkSePlmoSEM1Zn3aXo/Ekg4d9ulLlqLqJf7WSI c/zzo440sGvxWzBY84Yo9fbrUtkKo93tWmBu2/UEFCbhysAutZH8talW2QiFJl6Mfba8 Kt5gEfYWM4bY5uLqTlFD7vDWMtDdQM/Rnj0uEa39GbjASoLPuSlS72k8ns16vmiEXOeW JmT7zg2h6RHAeWf9hVE/Htrh1rj72HkN/ieG+/rhRy5KzxZQDr0fUfocgJvaZvFkJ4uT Px/g== X-Forwarded-Encrypted: i=1; AJvYcCU/paSaMHWQW78oRKd5O+psyDxBHyHCXl3QCpKob2PoWvXK6UxfH2Gcc03BmrbpRC76VnqPeUJ2BWv6GpY=@vger.kernel.org X-Gm-Message-State: AOJu0YwRmPUGwbrK3aT43Vu2LyB5neet8FSf7h3trZdQLNKaYINTduXb WvJYbMEZBrIa3AbG+MKW/Rh2VYrQ+eJHGtHuI37GbeHjCt8p1uRK7mb2 X-Gm-Gg: ATEYQzz4Ub5LmtzqzLgIAVipUeGuApooMFTHCvBkmXUZJAWB/MGnbEvG6WoskNZs6BO 5d92CmpyIplUavG48MyJ5hkLjEoaDtO/pOKYlxNiIwnRLVuvrsSqKgnVIPAI8h+KpyauOknsJT5 Tx/bIjiHByl+wEZk494HwwEc+Yvc+MbFNn3nk4Zo5chsAAo/em0FkWsktWXV4UD6krJlV4c5KkP 0WVJR2SNSu31oamXxE8NnwxpJx0oGXqbsAiOX4Zqi1hhPXp9UknjVDzGZSAA6iKg8cjMRu1eYsY Xih6bw5LQcNLIHOvisc3pGesjUxxOnBf6sXctnOEX3T9jS6XSJrma32lL6EKchX07lFMKDFmCYy cAZwKvqZbbZEtmKSvqA5OaAe6pltLYIxcKwOpbeS6zdVtRAWW8wlx32DzoeqgahnG1zzIAH7IEX AcuiXsOcLrz3Ewf7yqrs+m+Ym/lYSWGMgz3cPvQOdVEVpdO/nz4Cv4zVW80+hDrzijcwJ8OaGvh RXs/45tKAJeEY82tw== X-Received: by 2002:a05:600c:a06:b0:487:1108:48af with SMTP id 5b1f17b1804b1-48727d59ce3mr37657225e9.4.1774611829936; Fri, 27 Mar 2026 04:43:49 -0700 (PDT) Received: from jernej-laptop.localnet (118.red-213-98-130.staticip.rima-tde.net. [213.98.130.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df903sm14813099f8f.30.2026.03.27.04.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 04:43:49 -0700 (PDT) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Andre Przywara Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] pinctrl: sunxi: a523: Remove unneeded IRQ remuxing flag Date: Fri, 27 Mar 2026 12:39:42 +0100 Message-ID: <2822911.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20260327113006.3135663-2-andre.przywara@arm.com> References: <20260327113006.3135663-1-andre.przywara@arm.com> <20260327113006.3135663-2-andre.przywara@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne petek, 27. marec 2026 ob 12:30:04 Srednjeevropski standardni =C4=8Das j= e Andre Przywara napisal(a): > The Allwinner A10 and H3 SoCs cannot read the state of a GPIO line when > that line is muxed for IRQ triggering (muxval 6), but only if it's > explicitly muxed for GPIO input (muxval 0). Other SoCs do not show this > behaviour, so we added a optional workaround, triggered by a quirk bit, > which triggers remuxing the pin when it's configured for IRQ, while we > need to read its value. >=20 > For some reasons this quirk flag was copied over to newer SoCs, even > though they don't show this behaviour, and the GPIO data register > reflects the true GPIO state even with a pin muxed to IRQ trigger. >=20 > Remove the unneeded quirk from the A523 family, where it's definitely > not needed (confirmed by experiments), and where it actually breaks, > because the workaround is not compatible with the newer generation > pinctrl IP used in that chip. >=20 > Together with a DT change this fixes GPIO IRQ operation on the A523 > family of SoCs, as for instance used for the SD card detection. >=20 > Signed-off-by: Andre Przywara > Fixes: b8a51e95b376 ("pinctrl: sunxi: Add support for the secondary A523 = GPIO ports") Reviewed-by: Jernej Skrabec Best regards, Jernej