From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6546DC32773 for ; Thu, 18 Aug 2022 07:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243738AbiHRHCi (ORCPT ); Thu, 18 Aug 2022 03:02:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235733AbiHRHCh (ORCPT ); Thu, 18 Aug 2022 03:02:37 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B101C86B6F for ; Thu, 18 Aug 2022 00:02:33 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id z20so862422ljq.3 for ; Thu, 18 Aug 2022 00:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Ue7+dLTS9HtxTPrFYVqCFYSq/oTJauCpRZyChqde9i4=; b=i0NkYkwb9axhr+B/PWooFtVIbh5+86wm/+fbgKl/dKuQA2D61nFTdV6OI+wEVniZeE x238BpbsQ1x4a7RHM64nYIUjxzTp/7HF4SIKzMK6XQFHhtOGHDVmVBgdeD9cCIunGBHp 83w7KPlyM59kNFOIkViS1F5HaYY7koaX4sYPKlAHmEFvOq4CvkiXWc7LK2zIecbCJBv7 /SVxpM8i/clE+3+6D/yAi3lckJC36pmJTsMIEjvGJIiDDGstfNnmYnpziZTQP8QV9Fpu CsQfKGmXNOJBFNy87Mq+pIFXPKbZbmlMP+GeGN4bgwDcx5yl+WOU3CgEFI7MqnqiyFkR Yg0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Ue7+dLTS9HtxTPrFYVqCFYSq/oTJauCpRZyChqde9i4=; b=Dtrwge085LH4ynZGj2nUdLD3OID9g1Ttxjo9dMycaUv6eOcTILkQLN4/Xa1cFdnkXI ZxkxqIT3cf4clNNlBW0kDBu4eZqvi2PI6x5EBXDbuADQp6BTIBGntBKw+Ddr+46PJzae Y+HLjPgfmqc7lNVWgW3YBF/Vgh0Uks5M4pMceReyr/ycRuFRT1OLPS+RXmzSGDiSpnZl lUVSUqxScXXOhprQgUy160o3ynS9Qq+WCWsGlhNHlgqayQwPuKJvLmlA99csvZ5GjoBk 9jTK3UZdMSO/qo7RG41NBmHOhzYWhbvQ1z4JPjURx3UcHCV0oPe1CC+eJURhT9AmBu7W RZQw== X-Gm-Message-State: ACgBeo15b0OmVhGEcghCmzMCk8Sja9+l9zyQjYGg2Shml7pmMwQtPHA8 AcuZTolvow7LCY9CNLIVdds54w== X-Google-Smtp-Source: AA6agR47H/AvKjCxlUoA9J8rhI+zKwWJcqe09u39XlOJFuSv7PI5ijvh+4mTedgjzI2slrvSuUI1zA== X-Received: by 2002:a05:651c:543:b0:25f:dbbb:9cd4 with SMTP id q3-20020a05651c054300b0025fdbbb9cd4mr453724ljp.495.1660806152102; Thu, 18 Aug 2022 00:02:32 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:53ab:2635:d4f2:d6d5? (d15l54z9nf469l8226z-4.rev.dnainternet.fi. [2001:14bb:ae:539c:53ab:2635:d4f2:d6d5]) by smtp.gmail.com with ESMTPSA id c22-20020a056512325600b0048b998be041sm98016lfr.309.2022.08.18.00.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Aug 2022 00:02:31 -0700 (PDT) Message-ID: <2823e662-55a1-0d9f-e95d-40d6f3b93723@linaro.org> Date: Thu, 18 Aug 2022 10:02:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFT PATCH v2 02/14] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> <20220817130342.568396-3-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/08/2022 23:57, Konrad Dybcio wrote: > > > On 17.08.2022 15:03, Krzysztof Kozlowski wrote: >> The TCSR halt regs are next to TCSR mutex, so before converting the TCSR >> mutex into device with address space, we need to split the halt regs to >> its own syscon device. This also describes more accurately the devices >> and their IO address space. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > Not tested on a device, but looks good to the eye: > Reviewed-by: Konrad Dybcio > > On a note, are they really named TCSR_1 and TCSR_2 in the docs? > Qualcomm is usually more exquisite in their naming :P This is not entirely separate address space, therefore it does not have a separate name. The address space name is still TCSR_MUTEX which consists of actual MUTEX regs, halt regs and bunch of others. The second one 0x7a0000 (where label I renamed to tcsr_2) is called TCSR_REGS. This applies to other patches as well, so maybe you prefer to have labels matching the spec? The first would be tcsr_mutex_regs, although it is not entirely correct, because it does not include now the TCSR mutex regs... Best regards, Krzysztof