From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AAC11CEEAA for ; Fri, 24 Jan 2025 10:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737716309; cv=none; b=ls8CD1l0ZRCkh6LF0TdrMwlmJx/gmm6VR8RfwJyaA5IyNzSsSgOAeyImg6xcF8EUhd5O6jnYaa18IQlAWW9K/224SOYGHhuk0aibp6sUaH3h7ImzbcsqJ2mCW0WbGIWsiWN1Bpbhod4RGan35JBk4Jrvwdw6bXc8RaxCiHCeQZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737716309; c=relaxed/simple; bh=sbEBeAA4tFoSk+b62opzzrzqZXSAeiZClFCJpKPq2ps=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JfN4YKWJdyWW5Ru0MmMjlYsQJ9V7IQwlrElpyneX7KMbhMkOQFt97hCFeGCI4OMDNKAo2AoU0SX5m65DKyHwoCfP4VsiVewLV9h/bcxLJl6wTKJGnotnLOaxgCTGr2u6Yjdau8KycwnhYoAPzVPe3M+whzDvFcDOdNEvVpFIwls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=NVpCoCct; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="NVpCoCct" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21644db9f3cso4404615ad.2 for ; Fri, 24 Jan 2025 02:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1737716307; x=1738321107; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Pda3ELabzjHMCz9NofWB5XWgpAksp0H0JyV9tun2x64=; b=NVpCoCcthWlbgojWasR/lX+XkQXJeE9Ecte0blStMKqTOVLhobOejMdyUuN//obWOS RGhhfMvSLzKGqA3rJoTTUDRAabJq0hH7JZ3O/7dmCp81uOQcMVLnZ78EdpLkP97plfwo FxJwC0/3rvFE3IQ4ThM9brQv+xQCt9HM065LKZMmonL09EkDKeRhX5Q+envXQ2YN1v/q yhGVo8ppAQDPHayB2MmGJEschHPZy7UtRfAvmo7rJzghjfNpr5dgfKEw4Qf3BOiUgVRO YBTT8GDa9TA/Ahr17TZtZKsX56JrRAGhuRc1yQyhGy5I+LiDfVZg8rIeWr8AL9NELIsx CC5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737716307; x=1738321107; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pda3ELabzjHMCz9NofWB5XWgpAksp0H0JyV9tun2x64=; b=bBGQHqkFsn0FXSNFgLBj38yOeN+OzrOfpL2SyL/lBjqdNwwwAjrQq5CeAylh0uzk8W z1uBsPsPCm9yAuDxQeVlvKPlW4fP57WSG9j60RnX/NurleVdh9ww5zQklJN7uRS4LJFP DyklpjOkyxpqu5iV6ezmUlQzo2u6MeMdRkIqJ2Sh46Dh1dHEz893QuiF0au0lMCu0IbR Soiv47PXX+/0cwbXnj2Y/1zyup0MukZO3WV6AaZpBtQHoWagnsETc2aHVFv366hP9vZ7 2pTI5vycfvrKFSsk8BqYn6khifNOcyoEeZpyx+EejMAvrpck1GBVZBqbvRTLlZUjURyy 8itw== X-Forwarded-Encrypted: i=1; AJvYcCUqS6O6PdCDm6N3mwp3Z57XgBipe6AtErpxOq6Lgrb4+pAkicGNEYlZIzvQPozRJKbgTcnn7j2pPw0pBHQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyECij2zUI5rrb5kmn0FRD/BQcsLhfMceHnGd1GzVkb+1BQyfPx usNYjSaG5TbPK+ffuUJAnu0AkRb/x2MSsWq5TD0JEO0Rtvy2zy9Z6nTUZOGTDZI= X-Gm-Gg: ASbGncv3gV888Y6zoaWj399ofMR6HovDpfEpWHI6gELWL6kEjynlpPRqJwMaeYh+pld k77IeFejXpouPqJoQbBe3vDbbx3GdFWlzppk2thrnioft/ROzbLMiEtplJ4KkCheQBEBmEOxWW/ HDTBQQQGXQ43kvP5yXRahLKyEwaMh9HuhTJ7gkdxwWcmAPSzNjg04gNkrWBblH1i4p+ogar4YY6 dwWst0nPLoQtH5GEPwnQo0p86qmgN4voejQy1thGsGVBz9wVCBUowG5/lcEjA6dXrBon2JPYt9K AggD1B5deFWX1Tj7ulGUY2xJtnWlSA== X-Google-Smtp-Source: AGHT+IFPPAFtKUdWUrQ1fZ9ztKOZDVBkhLa1n4uWXAzzo9DG3Aj4Kym2pHd3B4/CvxBQ8m2/WgEEgQ== X-Received: by 2002:a17:902:d4c3:b0:21b:d105:26ca with SMTP id d9443c01a7336-21c35560010mr170856325ad.4.1737716307400; Fri, 24 Jan 2025 02:58:27 -0800 (PST) Received: from [10.254.144.106] ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da3d9dedcsm13807185ad.46.2025.01.24.02.58.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jan 2025 02:58:26 -0800 (PST) Message-ID: <2824d739-235d-46d5-8559-aa3f374bccbe@bytedance.com> Date: Fri, 24 Jan 2025 18:58:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] cgroup/rstat: Fix forceidle time in cpu.stat Content-Language: en-US To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Tejun Heo , Johannes Weiner , Jonathan Corbet , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Thomas Gleixner , Yury Norov , Andrew Morton , Bitao Hu , Chen Ridong , "open list:CONTROL GROUP (CGROUP)" , "open list:DOCUMENTATION" , open list References: <20250123174713.25570-1-wuyun.abel@bytedance.com> <20250123174713.25570-2-wuyun.abel@bytedance.com> From: Abel Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/24/25 6:39 PM, Michal Koutný Wrote: > On Fri, Jan 24, 2025 at 05:58:26PM +0800, Abel Wu wrote: >> The following hunk deleted the snapshot of cgrp->bstat.forceidle_sum: > > But there's no such hunk in your PATCH 1/3 :-o if (cgroup_parent(cgrp)) { cgroup_rstat_flush_hold(cgrp); - usage = cgrp->bstat.cputime.sum_exec_runtime; + bstat = cgrp->bstat; cputime_adjust(&cgrp->bstat.cputime, &cgrp->prev_cputime, - &utime, &stime); - ntime = cgrp->bstat.ntime; + &bstat.cputime.utime, &bstat.cputime.stime); cgroup_rstat_flush_release(cgrp); } else { Because @bstat takes a full snapshot of @cgrp->bstat which contains forceidle time. I think the lack of readability is the reason why TJ doesn't like this :(