From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbdHQMbX (ORCPT ); Thu, 17 Aug 2017 08:31:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdHQMbR (ORCPT ); Thu, 17 Aug 2017 08:31:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 78B5A78749 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH v2 2/5] KVM: MMU: check guest CR3 reserved bits based on its physical address width. To: Yu Zhang , kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, xiaoguangrong@tencent.com, joro@8bytes.org References: <1502999558-2517-1-git-send-email-yu.c.zhang@linux.intel.com> <1502999558-2517-3-git-send-email-yu.c.zhang@linux.intel.com> From: Paolo Bonzini Message-ID: <28276aa5-76e5-1826-5b1f-e18a62cd903d@redhat.com> Date: Thu, 17 Aug 2017 14:31:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502999558-2517-3-git-send-email-yu.c.zhang@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 17 Aug 2017 12:31:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/08/2017 21:52, Yu Zhang wrote: > + if (efer & EFER_LMA) { > + u64 maxphyaddr; > + u32 eax = 0x80000008; > + > + if (ctxt->ops->get_cpuid(ctxt, &eax, NULL, NULL, NULL, > + NO_CHECK_LIMIT)) { > + maxphyaddr = eax & 0xff; > + rsvd = rsvd_bits(maxphyaddr, 62); > + } You should use 36 here if ctxt->ops->get_cpuid returns false, for consistency with cpuid_query_maxphyaddr. Paolo