From: Andrew Lunn <andrew@lunn.ch>
To: Javen <javen_xu@realsil.com.cn>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"nic_swsd@realtek.com" <nic_swsd@realtek.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v1 4/6] r8169: add support for RTL8116af
Date: Mon, 8 Jun 2026 09:37:56 +0200 [thread overview]
Message-ID: <282e4c64-a088-4602-b053-7a8e1cd32c5a@lunn.ch> (raw)
In-Reply-To: <b54b5f3a6703498fbc17e64548550ba0@realsil.com.cn>
On Mon, Jun 08, 2026 at 06:32:19AM +0000, Javen wrote:
> >> +static bool rtl_is_8116af(struct rtl8169_private *tp) {
> >> + return tp->mac_version == RTL_GIGA_MAC_VER_52 &&
> >> + (r8168_mac_ocp_read(tp, 0xdc00) & 0x0078) == 0x0030 &&
> >> + (r8168_mac_ocp_read(tp, 0xd006) & 0x00ff) == 0x0000;
> >
> >Do we know what these magic numbers mean?
>
> 0xdc00 is a package-detect field. 0xd006 is internal HW id. RTL8116AF shares the same RTL_GIGA_MAC_VER_52 mac_version with other variants.
Since you know what they are, please add #defines.
> >> @@ -2509,9 +2543,10 @@ void r8169_apply_firmware(struct
> >rtl8169_private *tp)
> >> tp->ocp_base = OCP_STD_PHY_BASE;
> >>
> >> /* PHY soft reset may still be in progress */
> >> - phy_read_poll_timeout(tp->phydev, MII_BMCR, val,
> >> - !(val & BMCR_RESET),
> >> - 50000, 600000, true);
> >> + if (tp->phydev)
> >> + phy_read_poll_timeout(tp->phydev, MII_BMCR, val,
> >> + !(val & BMCR_RESET),
> >> + 50000, 600000, true);
> >
> >Maybe this all needs to move into the PHY driver?
>
> This is after firmware application. And PHY_MDIO_CHG opcode switches the access callbacks between PHY and MAC accessors.
> data == 0: phy_read/phy_write
> data != 0: mac_mcu_read/mac_mcu_write
> So the firmware may contain mixed PHY and MAC.
Normally, the MAC does not touch the PHY, it only calls phylib/phylink
API methods. If standard MII interfaces are used, you can connect any
MAC to any PHY.
If it is all integrated into silicon, then there is no choice, you
know the MAC/PHY relationship. However, it is still good practice to
keep MAC code in the MAC driver and PHY code in the PHY driver.
Can firmware programming be moved into the PHY driver?
> >> - rg_saw_cnt = phy_read_paged(tp->phydev, 0x0c42, 0x13) & 0x3fff;
> >> - if (rg_saw_cnt > 0) {
> >> - u16 sw_cnt_1ms_ini;
> >> + if (tp->phydev) {
> >> + rg_saw_cnt = phy_read_paged(tp->phydev, 0x0c42, 0x13) & 0x3fff;
> >> + if (rg_saw_cnt > 0) {
> >> + u16 sw_cnt_1ms_ini;
> >>
> >> - sw_cnt_1ms_ini = (16000000 / rg_saw_cnt) & 0x0fff;
> >> - r8168_mac_ocp_modify(tp, 0xd412, 0x0fff, sw_cnt_1ms_ini);
> >> + sw_cnt_1ms_ini = (16000000 / rg_saw_cnt) & 0x0fff;
> >> + r8168_mac_ocp_modify(tp, 0xd412, 0x0fff, sw_cnt_1ms_ini);
> >> + }
> >
> >Can this move into the PHY driver?
>
> It reads a counter from PHY, but the calculated value is programmed into MAC OCP register via r8168_mac_ocp_modify, which accesses r8169 through tp->mmio_addr. So I think this can not be moved.
So, big picture, what is this doing? What is rg_saw_cnt?
Andrew
next prev parent reply other threads:[~2026-06-08 7:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 10:38 [PATCH net-next v1 0/6] add support for phylink javen
2026-06-05 10:39 ` [PATCH net-next v1 1/6] r8169: add current_speed in private struct javen
2026-06-06 9:57 ` Andrew Lunn
2026-06-05 10:39 ` [PATCH net-next v1 2/6] r8169: add support for phylink javen
2026-06-06 10:02 ` Maxime Chevallier
2026-06-08 7:40 ` Javen
2026-06-08 14:23 ` Maxime Chevallier
2026-06-08 18:40 ` Andrew Lunn
2026-06-06 10:07 ` Andrew Lunn
2026-06-05 10:39 ` [PATCH net-next v1 3/6] r8169: decoupling tp->phydev javen
2026-06-05 10:39 ` [PATCH net-next v1 4/6] r8169: add support for RTL8116af javen
2026-06-06 10:20 ` Andrew Lunn
2026-06-08 6:32 ` Javen
2026-06-08 7:37 ` Andrew Lunn [this message]
2026-06-10 8:40 ` Javen
2026-06-10 20:25 ` Andrew Lunn
2026-06-05 10:39 ` [PATCH net-next v1 5/6] r8169: add ltr " javen
2026-06-05 10:39 ` [PATCH net-next v1 6/6] r8169: fix RTL8116af can not enter s0idle and c10 javen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=282e4c64-a088-4602-b053-7a8e1cd32c5a@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=javen_xu@realsil.com.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®