From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E883C10DCE for ; Wed, 18 Mar 2020 08:27:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEB2C2076C for ; Wed, 18 Mar 2020 08:27:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OQyJWYtz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727499AbgCRI1t (ORCPT ); Wed, 18 Mar 2020 04:27:49 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:29135 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727439AbgCRI1s (ORCPT ); Wed, 18 Mar 2020 04:27:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584520066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VH0+XlPo10NyA/xz91Ej5gjsjWF5TbKzK+mngsaI8Lo=; b=OQyJWYtzDd6/SfjlVR5AekUXhPqKnAUYbuurb/fpICxE/LUgZfVeLvIpcgnkiMWgoel+7A 6iWgGpjE12ES/Lq99k+IRN6JBQGzMilKEvM/iVA5euWcL+9o3zw1nSM2ylEt/v2mi+oTx/ iiYFx3y8CEnAL4osX/iO8vSUKTrYZIk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-yA7fyRPiO0KsCqIveqAp5A-1; Wed, 18 Mar 2020 04:27:43 -0400 X-MC-Unique: yA7fyRPiO0KsCqIveqAp5A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D72D4800D4E; Wed, 18 Mar 2020 08:27:40 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-113-126.rdu2.redhat.com [10.10.113.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id D081819C70; Wed, 18 Mar 2020 08:27:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200317194140.6031-5-longman@redhat.com> References: <20200317194140.6031-5-longman@redhat.com> <20200317194140.6031-1-longman@redhat.com> To: Waiman Long Cc: dhowells@redhat.com, Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Mimi Zohar , "David S. Miller" , Jakub Kicinski , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, Sumit Garg , Jerry Snitselaar , Roberto Sassu , Eric Biggers , Chris von Recklinghausen Subject: Re: [PATCH v4 4/4] KEYS: Avoid false positive ENOMEM error on key read MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2832138.1584520054.1@warthog.procyon.org.uk> Date: Wed, 18 Mar 2020 08:27:34 +0000 Message-ID: <2832139.1584520054@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Waiman Long wrote: > +static inline void __kvzfree(const void *addr, size_t len) > +{ > + if (addr) { > + memset((void *)addr, 0, len); > + kvfree(addr); > + } > +} I wonder if that would be better as "kvfree(memset(...))" as memset() will return the address parameter. If memset is not inline, it avoids the need for the compiler to save the parameter. David