mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Ozgur Karatas <mueddib@yandex.com>,
	Joao Pinto <joao.pinto@synopsys.com>,
	Rayagond Kokatanur <rayagond@vayavyalabs.com>,
	Rabin Vincent <rabin@rab.in>
Cc: mued dib <kreptor@gmail.com>, David Miller <davem@davemloft.net>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	"jiri@mellanox.com" <jiri@mellanox.com>,
	"saeedm@mellanox.com" <saeedm@mellanox.com>,
	"idosch@mellanox.com" <idosch@mellanox.com>,
	netdev <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"CARLOS.PALMINHA@synopsys.com" <carlos.palminha@synopsys.com>,
	"andreas.irestal@axis.com" <andreas.irestal@axis.com>,
	"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
	"lars.persson@axis.com" <lars.persson@axis.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: Synopsys Ethernet QoS Driver
Date: Wed, 23 Nov 2016 09:02:45 +0100	[thread overview]
Message-ID: <283da053-3754-ca06-70e3-a988221fc3e9@st.com> (raw)
In-Reply-To: <1806171479803900@web16j.yandex.ru>

Hello Ozgur

On 11/22/2016 9:38 AM, Ozgur Karatas wrote:
> Hello all,
>
> I think, ethtool and mdio don't work because the tool's not support to "QoS", right?
>
> Maybe, need a new API. I'm looking for dwceqos code but "tc" tools is very idea.
>
> I hope to be me always helpful.

tools work but indeed should be extended to support more for QoS.
This is another task we have to keep in mind, well spot.

Peppe

>
> Regards,
>
> Ozgur
>
> 21.11.2016, 16:38, "Giuseppe CAVALLARO" <peppe.cavallaro@st.com>:
>> Hello Joao
>>
>> On 11/21/2016 2:48 PM, Joao Pinto wrote:
>>>  Synopsys QoS IP is a separated hardware component, so it should be reusable by
>>>  all implementations using it and so have its own "core driver" and platform +
>>>  pci glue drivers. This is necessary for example in hardware validation, where
>>>  you prototype an IP and instantiate its drivers and test it.
>>>
>>>  Was there a strong reason to integrate QoS features directly in stmmac and not
>>>  in synopsys/dwc_eth_qos.*?
>>
>> We decided to enhance the stmmac on supporting the QoS for several
>> reasons; for example the common APIs that the driver already exposed and
>> actually suitable for other SYNP chips. Then, PTP, EEE,
>> S/RGMII, MMC could be shared among different chips with a minimal
>> effort. This meant a lot of code already ready.
>>
>> For sure, the net-core, Ethtool, mdio parts were reused. Same for the
>> glue logic files.
>> For the latter, this helped to easily bring-up new platforms also
>> because the stmmac uses the HW cap register to auto-configure many
>> parts of the MAC core, DMA and modules. This helped many users, AFAIK.
>>
>> For validation purpose, this is my experience, the stmmac helped
>> a lot because people used the same code to validate different HW
>> and it was easy to switch to a platform to another one in order to
>> verify / check if the support was ok or if a regression was introduced.
>> This is important for complex supports like PTP or EEE.
>>
>> Hoping this can help.
>>
>> Do not hesitate to contact me for further details
>>
>> peppe
>

  parent reply	other threads:[~2016-11-23  8:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CADvZ6ErjyVR5ShWTk0QesWLYR1m3p8yAMkK8v9gm2kN5xTv8zw@mail.gmail.com>
2016-11-18 14:20 ` Joao Pinto
2016-11-19 13:56   ` Rabin Vincent
2016-11-21  5:29     ` Rayagond Kokatanur
2016-11-21 12:32       ` Joao Pinto
2016-11-21 12:52         ` Giuseppe CAVALLARO
2016-11-21 13:28           ` Lars Persson
2016-11-21 14:25             ` Giuseppe CAVALLARO
2016-11-21 15:06               ` Joao Pinto
2016-11-21 15:43                 ` Lars Persson
2016-11-21 16:11                   ` Joao Pinto
2016-11-22 14:16                     ` Joao Pinto
2016-11-23 10:59                       ` Giuseppe CAVALLARO
2016-11-23 11:10                         ` Joao Pinto
2016-11-23 11:41                           ` Lars Persson
2016-11-23 11:43                             ` Joao Pinto
2016-11-25  8:55                               ` Giuseppe CAVALLARO
2016-12-07  9:41                       ` Pavel Machek
2016-11-21 13:48           ` Joao Pinto
2016-11-21 14:36             ` Giuseppe CAVALLARO
2016-11-21 15:00               ` Joao Pinto
2016-11-21 15:03                 ` Giuseppe CAVALLARO
2016-11-21 15:14                   ` Joao Pinto
     [not found]               ` <1806171479803900@web16j.yandex.ru>
2016-11-23  8:02                 ` Giuseppe CAVALLARO [this message]
2016-12-07 20:15           ` Andy Shevchenko
2016-11-18 12:28 Joao Pinto
2016-11-18 12:31 ` Joao Pinto
2016-11-18 14:53 ` Florian Fainelli
2016-11-18 16:31   ` Joao Pinto
2016-11-18 16:35     ` Florian Fainelli
2016-11-18 16:40       ` Joao Pinto
2016-11-18 18:29         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=283da053-3754-ca06-70e3-a988221fc3e9@st.com \
    --to=peppe.cavallaro@st.com \
    --cc=alexandre.torgue@st.com \
    --cc=andreas.irestal@axis.com \
    --cc=carlos.palminha@synopsys.com \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jiri@mellanox.com \
    --cc=joao.pinto@synopsys.com \
    --cc=kreptor@gmail.com \
    --cc=lars.persson@axis.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mueddib@yandex.com \
    --cc=netdev@vger.kernel.org \
    --cc=rabin@rab.in \
    --cc=rayagond@vayavyalabs.com \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®